Looks like a straightforward move
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jun 2 2023
Jun 2 2023
ginsu retitled D8076: [landing] introduce glow effect for hero image from [landing] introduce blur effect for hero image
Looks good overall, might be worth trying box-shadow instead of blur if it's easy... but feel free to land as-is if it takes too long to investigate + achieve the same effect
change name from blur to glow
Maybe glow instead of blur? Kind of associate blur with being some sort of "filter" "above" some other content
fix text vertical alignment
Saw a css class that could be moved to a different file to improve readability
atul added inline comments to D8057: [native] Introduce `CommunityCreationContentContainer` component.
addressed feedback
rebase before addressing feedback
rebase and land
In D8056#239068, @ashoat wrote:In D8056#239034, @atul wrote:I can try to pull something generic out of CommunityCreationMembers and see if it can be used in other components where we have TagInput and UserList (ComposeSubchannel, AddUsersModal, etc) later in this stack.
That would be great
ashoat requested changes to D8072: [lib] Remove parent admin from members list if they are not part of the thread.
This diff makes sense, but from a code search it looks like it might impact ThreadSettingsLeaveThread and its use of otherUsersButNoOtherAdmins.
ashoat added inline comments to D8067: [web] Refactor the members modal to support any variety of role labels.
• jon added a comment to D8066: [identity] update login_password_user_start and register_password_user_start.
Since this is just a migration code path, I'm okay with it.
Looks fine to me, let bartek have a look
rust looks fine. Not a big fan of parsing text for certain values though.
Removed code duplication (function was introduced in D8010)
Comment and readonly
Extracted the shared code (here and not in D8013, because that's how I have my git stack set up).
michal added inline comments to D8009: [lib] Include searchUsers results in getPotentialMemberItems.
Change the function to take a object of params, fix
rohan updated the summary of D8068: [native] Refactor the members list to support any variety of role labels.
rohan updated the summary of D8072: [lib] Remove parent admin from members list if they are not part of the thread.
Makes sense to me if the messages all get replaced & a local test of this seemed to work as expected
rohan updated the diff for D8068: [native] Refactor the members list to support any variety of role labels.
Rename 'parent admin' to 'Admins'
rohan updated the diff for D8067: [web] Refactor the members modal to support any variety of role labels.
Rename "Parent admin" to "Admins" [discussed in DES-44]
Restricted Repository Identity closed D8035: [web][fix] Fixed cursor issue in the message editing.
kosmydel <kukubaczek@gmail.com> committed rCOMM9461175282dc: [web][fix] Fixed cursor issue in the message editing.
Add comment
Jun 1 2023
Jun 1 2023
rohan requested review of D8068: [native] Refactor the members list to support any variety of role labels.
rohan requested review of D8067: [web] Refactor the members modal to support any variety of role labels.
varun requested review of D8066: [identity] update login_password_user_start and register_password_user_start.
In D8056#239034, @atul wrote:I can try to pull something generic out of CommunityCreationMembers and see if it can be used in other components where we have TagInput and UserList (ComposeSubchannel, AddUsersModal, etc) later in this stack.
Do we really need another low-level component for this? Don't we have something we can reuse? If not, can't we refactor something / make it generic, rather than implementing a new one of these?
Back to you with questions:
but I'm not clear on how all of them connect to the JS.