Use the otherUsersButNoOtherAdmins selector
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jun 8 2023
Jun 8 2023
rohan updated the diff for D8140: [web] Add functionality on save to actually change a member's role.
Address inline comment
Address feedback
Jun 7 2023
Jun 7 2023
ginsu requested changes to D8137: [web] Create a modal that allows admins to change a member's role (modal, description, avatar).
Overall looks good, let's just address the onClose behavior
putting this back in your queue
• jon added inline comments to D8134: [identity] implement addReservedUsername and removeReservedUsername RPCs.
few suggestions inline
• jon added 1 blocking reviewer(s) for D8102: [blob-service] Use S3 errors in HTTP endpoints: varun.
LGTM, varun should review though
looks fine to me, but varun should also take a look
ashoat added inline comments to D8140: [web] Add functionality on save to actually change a member's role.
Add failing test case
Had to change text encoding in Phabricator to "see the difference," but looks good.
Don't think the plus-circle icon makes sense for "Change Role," but defer to @ted on that.
ashoat requested review of D8146: [lib] Use RegExp.source instead of RegExp.toString() in emojis.js.
atul requested changes to D8067: [web] Refactor the members modal to support any variety of role labels.
Label having a bg prop that expects a CSS variable is a weird API. Is there a way we can introduce a variant prop to Label instead and style accordingly within?
atul added inline comments to D8129: [native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers`.
I think we need some way to authenticate this request. We can't use the access token until keyservers are able to register with the identity service, which is still several weeks away. In yesterday's 1:1, you and I had talked about using a signed message for this, similar to how RegisterReservedPasswordUserStart works. To make that work we'd have to change the .proto here, though. What do you think?
ashoat requested changes to D8126: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys.
Accepting, but please take a look at the trailing space
rohan updated the diff for D8068: [native] Refactor the members list to support any variety of role labels.
Show Members
rohan updated the diff for D8067: [web] Refactor the members modal to support any variety of role labels.
Spoke with @ted after some updated designs, we want to show the Members role label and make the background grey
rohan updated the diff for D8098: [native] Block TimeStamp from rendering in the pinned messages screen.
Remove the IIFE
rohan added inline comments to D8098: [native] Block TimeStamp from rendering in the pinned messages screen.
inka requested review of D8144: [kayserver] Fix search endpoint failing when called with a stopword.
Address review
rohan updated the test plan for D8140: [web] Add functionality on save to actually change a member's role.
inka updated the diff for D8105: [native] Add functions to filter thread descendants in community drawer.
Address review
rohan requested review of D8140: [web] Add functionality on save to actually change a member's role.
rohan requested review of D8139: [web] Confirm a user wants to exit if changes are made in the modal.
rohan updated the test plan for D8137: [web] Create a modal that allows admins to change a member's role (modal, description, avatar).
Requesting review again because I changed quite a lot
Address review and simplify code
tomek requested changes to D8105: [native] Add functions to filter thread descendants in community drawer.
kamil published D8121: [web-db] generate and persist encryption key on main thread on Safari for review.
kamil published D8120: [web-db] add optional encryption key param while initializing database on web for review.