Page MenuHomePhabricator
Differential D5911

[native] [17/40] RN 0.70: Move font files
ClosedPublic
Actions

Authored by ashoat on Dec 18 2022, 9:03 AM.
Tags
None
Referenced Files
F4087841: D5911.diff
Sun, Feb 16, 10:36 AM
Unknown Object (File)
Jan 13 2025, 6:21 PM
Unknown Object (File)
Jan 12 2025, 6:26 PM
Unknown Object (File)
Dec 14 2024, 2:37 PM
Unknown Object (File)
Dec 14 2024, 2:35 PM
Unknown Object (File)
Dec 14 2024, 2:14 PM
Unknown Object (File)
Nov 29 2024, 5:13 AM
Unknown Object (File)
Nov 29 2024, 12:03 AM
View All 91 Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMM4b18fa069ccc: [native] [17/40] RN 0.70: Move font files
Summary

expo-dev-client wants these files in the same place for iOS / Android. This diff dedups them because iOS and Android. Android uses a symlink, iOS just has a path directly there.

Depends on D5910

Test Plan

Tested along with whole stack: test plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 18 2022, 9:03 AM
Herald added a subscriber: atul. · View Herald TranscriptDec 18 2022, 9:03 AM
ashoat published this revision for review.Dec 18 2022, 9:03 AM

Please ignore CI until the end of the stack

Harbormaster failed remote builds in B14240: Diff 19479!Dec 18 2022, 9:04 AM
ashoat added a child revision: D5912: [native] [18/40] RN 0.70: Fix custom icons in dev mode.Dec 18 2022, 9:06 AM
ashoat updated this revision to Diff 19501.Dec 18 2022, 8:16 PM

Rebase

Harbormaster failed remote builds in B14262: Diff 19501!Dec 18 2022, 8:21 PM
ashoat updated this revision to Diff 19528.Dec 18 2022, 8:29 PM

Rebase

Harbormaster failed remote builds in B14289: Diff 19528!Dec 18 2022, 8:52 PM
ashoat updated this revision to Diff 19590.Dec 19 2022, 8:20 AM

Rebase

bartek accepted this revision.Dec 19 2022, 8:25 AM
This revision is now accepted and ready to land.Dec 19 2022, 8:25 AM
Harbormaster failed remote builds in B14341: Diff 19590!Dec 19 2022, 8:31 AM
ashoat updated this revision to Diff 19623.Dec 19 2022, 8:37 AM

Rebase

Harbormaster failed remote builds in B14374: Diff 19623!Dec 19 2022, 9:00 AM
ashoat updated this revision to Diff 19696.Dec 19 2022, 12:28 PM

Rebase

Harbormaster failed remote builds in B14441: Diff 19696!Dec 19 2022, 12:32 PM
tomek accepted this revision.Dec 20 2022, 5:00 AM
ashoat updated this revision to Diff 19816.Dec 20 2022, 11:01 AM

Rebase

Harbormaster failed remote builds in B14556: Diff 19816!Dec 20 2022, 11:12 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:01 PM
Closed by commit rCOMM4b18fa069ccc: [native] [17/40] RN 0.70: Move font files (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM4b18fa069ccc: [native] [17/40] RN 0.70: Move font files.

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
main/
assets/
fonts/
1 line
1 line
fonts/
ios/
Resources/
ios/
Comm.xcodeproj/
16 lines
Resources/

Diff 19857

View Options

native/android/app/src/main/assets/fonts/CommIcons.ttf

Loading...
View Options

native/android/app/src/main/assets/fonts/SWMansionIcons.ttf

Loading...
View Options

native/fonts/CommIcons.ttf

Loading...
View Options

native/fonts/SWMansionIcons.ttf

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...
View Options

native/ios/Resources/CommIcons.ttf

Loading...
View Options

native/ios/Resources/SWMansionIcons.ttf

Loading...