Details

Reviewers

bartek
kamil
inka

Commits

rCOMMd49051d1f18a: [keyserver] Create an endpoint returning primary invite links

Summary

This endpoint will be used to display exiting link. In near future we will need an endpoint that returns all the links - it will reuse most of the logic from this endpoint.

Test Plan

Call the endpoint and check if all the primary links were returned.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.May 5 2023, 8:34 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 5 2023, 8:34 AM

tomek added a child revision: D7727: [lib] Allow calling endpoints with empty payload.May 5 2023, 8:39 AM

Harbormaster returned this revision to the author for changes because remote builds failed.May 5 2023, 8:51 AM

Harbormaster failed remote builds in B19070: Diff 26118!

Fix flow issue - move endpoint update from the next diff

Harbormaster completed remote builds in B19111: Diff 26165.May 8 2023, 3:28 AM

tomek requested review of this revision.May 8 2023, 3:28 AM

I think this is a bit vulnerable, we fetch all the links to the client - which means if the user is not part of a given community can get possession of the invite link and join the community when I think only members of the community should invite others. Fetching invite links to communities in which the user is a part will help.

Not a huge deal but I think worth improving.

This revision now requires changes to proceed.May 9 2023, 1:24 AM

tomek removed a child revision: D7727: [lib] Allow calling endpoints with empty payload.May 10 2023, 2:59 AM

tomek added a child revision: D7728: [lib] Add client side boilerplate for the new endpoint.

tomek added a parent revision: D7727: [lib] Allow calling endpoints with empty payload.

tomek mentioned this in D7727: [lib] Allow calling endpoints with empty payload.May 10 2023, 3:05 AM

Return only the invitations where a user is a member. Tested this by creating a new
community with a primary link - the endpoint doesn't return its link.

In D7726#229991, @kamil wrote:

I think this is a bit vulnerable, we fetch all the links to the client - which means if the user is not part of a given community can get possession of the invite link and join the community when I think only members of the community should invite others. Fetching invite links to communities in which the user is a part will help.

Not a huge deal but I think worth improving.

That's a valid point! Update the diff.

Harbormaster completed remote builds in B19231: Diff 26331.May 10 2023, 4:18 AM

tomek mentioned this in rCOMMee8762ce834c: [lib] Allow calling endpoints with empty payload.May 10 2023, 5:34 AM

Fetch all the fields

Harbormaster completed remote builds in B19249: Diff 26351.May 10 2023, 8:54 AM

kamil accepted this revision.May 10 2023, 9:12 AM

This revision is now accepted and ready to land.May 10 2023, 9:12 AM

Closed by commit rCOMMd49051d1f18a: [keyserver] Create an endpoint returning primary invite links (authored by tomek). · Explain WhyMay 16 2023, 3:56 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMd49051d1f18a: [keyserver] Create an endpoint returning primary invite links.