[keyserver] Validate notifications
ClosedPublic
Actions

Authored by michal on May 15 2023, 3:51 AM.

Details

Reviewers

kamil
tomek
marcin

Commits

rCOMM7c7b43562c94: [keyserver] Validate notifications

Summary

Introduce validators and validate notifications.

Depends on D7805

Test Plan

Tested web and ios (emulator) notifications and checked if there were any errors.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.May 15 2023, 3:51 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 15 2023, 3:51 AM

michal added a child revision: D7807: [keyserver] Validate link responders.May 15 2023, 3:55 AM

Harbormaster completed remote builds in B19332: Diff 26446.May 15 2023, 4:08 AM

michal requested review of this revision.May 15 2023, 4:08 AM

Might be good for @marcin to take a look as well, as he is very familiar with this code

marcin accepted this revision.May 16 2023, 1:05 AM

This revision is now accepted and ready to land.May 16 2023, 1:05 AM

Closed by commit rCOMM7c7b43562c94: [keyserver] Validate notifications (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 17 2023, 1:29 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM7c7b43562c94: [keyserver] Validate notifications.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

send.js

64 lines

lib/

types/

notif-types.js

10 lines

Diff 26446

View Options

keyserver/src/push/send.js

This file was added.

				// @flow

				import { threadIsChannel } from '../shared/thread-utils.js';
				import {
				type ThreadInfo,
				type ResolvedThreadInfo,
				communitySubthreads,
				} from '../types/thread-types.js';

				export type CommunityDrawerItemData<T> = {
				+threadInfo: ThreadInfo,
				+itemChildren?: $ReadOnlyArray<CommunityDrawerItemData<T>>,
				+hasSubchannelsButton: boolean,
				+labelStyle: T,
				};

				function createRecursiveDrawerItemsData<LabelStyleType>(
				childThreadInfosMap: { +[id: string]: $ReadOnlyArray<ThreadInfo> },
				communities: $ReadOnlyArray<ResolvedThreadInfo>,
				labelStyles: $ReadOnlyArray<LabelStyleType>,
				maxDepth: number,
				): $ReadOnlyArray<CommunityDrawerItemData<LabelStyleType>> {
				const result = communities.map(community => ({
				threadInfo: community,
				itemChildren: [],
				labelStyle: labelStyles[0],
				hasSubchannelsButton: false,
				}));
				let queue = result.map(item => [item, 0]);

				for (let i = 0; i < queue.length; i++) {
				const [item, lvl] = queue[i];
				const itemChildThreadInfos = childThreadInfosMap[item.threadInfo.id] ?? [];

				if (lvl < maxDepth) {
				item.itemChildren = itemChildThreadInfos
				.filter(childItem => communitySubthreads.includes(childItem.type))
				.map(childItem => ({
				threadInfo: childItem,
				itemChildren: [],
				labelStyle: labelStyles[Math.min(lvl + 1, labelStyles.length - 1)],
				hasSubchannelsButton:
				lvl + 1 === maxDepth &&
				threadHasSubchannels(childItem, childThreadInfosMap),
				}));
				queue = queue.concat(
				item.itemChildren.map(childItem => [childItem, lvl + 1]),
				);
				}
				}
				return result;
				}

				function threadHasSubchannels(
				threadInfo: ThreadInfo,
				childThreadInfosMap: { +[id: string]: $ReadOnlyArray<ThreadInfo> },
				): boolean {
				if (!childThreadInfosMap[threadInfo.id]?.length) {
				return false;
				}
				return childThreadInfosMap[threadInfo.id].some(thread =>
				threadIsChannel(thread),
				);
				}

				function appendSuffix(
				chats: $ReadOnlyArray<ResolvedThreadInfo>,
				): ResolvedThreadInfo[] {
				const result = [];
				const names = new Map<string, number>();

				for (const chat of chats) {
				let name = chat.uiName;
				const numberOfOccurrences = names.get(name);
				names.set(name, (numberOfOccurrences ?? 0) + 1);
				if (numberOfOccurrences) {
				name = `${name} (${numberOfOccurrences.toString()})`;
				}
				result.push({ ...chat, uiName: name });
				}
				return result;
				}

				export { createRecursiveDrawerItemsData, appendSuffix };