Page MenuHomePhabricator
Differential D7806

[keyserver] Validate notifications
ClosedPublic
Actions

Authored by michal on May 15 2023, 3:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 12:55 PM
Unknown Object (File)
Mon, Mar 17, 12:55 PM
Unknown Object (File)
Mon, Mar 17, 12:54 PM
Unknown Object (File)
Mon, Mar 17, 12:39 PM
Unknown Object (File)
Sat, Mar 8, 4:58 AM
Unknown Object (File)
Sun, Feb 23, 10:13 PM
Unknown Object (File)
Feb 18 2025, 3:05 AM
Unknown Object (File)
Feb 16 2025, 2:32 PM
View All Files
Subscribers
ashoat
atul
marcin

Details

Reviewers
kamil
tomek
marcin
Commits
rCOMM7c7b43562c94: [keyserver] Validate notifications
Summary

Introduce validators and validate notifications.

Depends on D7805

Test Plan

Tested web and ios (emulator) notifications and checked if there were any errors.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
64 lines
lib/
types/
10 lines

Diff 26572

View Options

keyserver/src/push/send.js

Show First 20 Lines • Show All 302 Lines • ▼ Show 20 Lines
async function serverThreadInfoFromMessageInfo( async function serverThreadInfoFromMessageInfo(
message: RawMessageInfo | MessageInfo, message: RawMessageInfo | MessageInfo,
): Promise<?ServerThreadInfo> { ): Promise<?ServerThreadInfo> {
const threadID = message.threadID; const threadID = message.threadID;
const threads = await fetchServerThreadInfos(SQL`t.id = ${threadID}`); const threads = await fetchServerThreadInfos(SQL`t.id = ${threadID}`);
return threads.threadInfos[threadID]; return threads.threadInfos[threadID];
} }
async function fetchContainedThreadIDs(
parentThreadID: string,
): Promise<Array<string>> {
const query = SQL`
WITH RECURSIVE thread_tree AS (
SELECT id, containing_thread_id
FROM threads
WHERE id = ${parentThreadID}
UNION ALL
SELECT t.id, t.containing_thread_id
FROM threads t
JOIN thread_tree tt ON t.containing_thread_id = tt.id
)
SELECT id FROM thread_tree
`;
const [result] = await dbQuery(query);
return result.map(row => row.id.toString());
}
export { export {
fetchServerThreadInfos, fetchServerThreadInfos,
fetchThreadInfos, fetchThreadInfos,
rawThreadInfosFromServerThreadInfos, rawThreadInfosFromServerThreadInfos,
verifyThreadIDs, verifyThreadIDs,
verifyThreadID, verifyThreadID,
determineThreadAncestry, determineThreadAncestry,
personalThreadQuery, personalThreadQuery,
fetchPersonalThreadID, fetchPersonalThreadID,
serverThreadInfoFromMessageInfo, serverThreadInfoFromMessageInfo,
fetchContainedThreadIDs,
}; };
View Options

lib/types/notif-types.js

Show First 20 Lines • Show All 302 Lines • ▼ Show 20 Lines
async function serverThreadInfoFromMessageInfo( async function serverThreadInfoFromMessageInfo(
message: RawMessageInfo | MessageInfo, message: RawMessageInfo | MessageInfo,
): Promise<?ServerThreadInfo> { ): Promise<?ServerThreadInfo> {
const threadID = message.threadID; const threadID = message.threadID;
const threads = await fetchServerThreadInfos(SQL`t.id = ${threadID}`); const threads = await fetchServerThreadInfos(SQL`t.id = ${threadID}`);
return threads.threadInfos[threadID]; return threads.threadInfos[threadID];
} }
async function fetchContainedThreadIDs(
parentThreadID: string,
): Promise<Array<string>> {
const query = SQL`
WITH RECURSIVE thread_tree AS (
SELECT id, containing_thread_id
FROM threads
WHERE id = ${parentThreadID}
UNION ALL
SELECT t.id, t.containing_thread_id
FROM threads t
JOIN thread_tree tt ON t.containing_thread_id = tt.id
)
SELECT id FROM thread_tree
`;
const [result] = await dbQuery(query);
return result.map(row => row.id.toString());
}
export { export {
fetchServerThreadInfos, fetchServerThreadInfos,
fetchThreadInfos, fetchThreadInfos,
rawThreadInfosFromServerThreadInfos, rawThreadInfosFromServerThreadInfos,
verifyThreadIDs, verifyThreadIDs,
verifyThreadID, verifyThreadID,
determineThreadAncestry, determineThreadAncestry,
personalThreadQuery, personalThreadQuery,
fetchPersonalThreadID, fetchPersonalThreadID,
serverThreadInfoFromMessageInfo, serverThreadInfoFromMessageInfo,
fetchContainedThreadIDs,
}; };