Updating to Expo 47! Linear issue
Depends on D5906
Paths
| Differential D5907 Authored by ashoat on Dec 18 2022, 7:59 AM.
Details
Summary Updating to Expo 47! Linear issue Depends on D5906 Test Plan Tested along with whole stack: test plan
Diff Detail
Event TimelineHerald added a subscriber: atul. · View Herald TranscriptDec 18 2022, 7:59 AM2022-12-18 07:59:24 (UTC-8) Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:00 AM2022-12-18 08:00:58 (UTC-8) Comment Actions Most of these changes are from https://docs.expo.dev/bare/installing-expo-modules/
Harbormaster failed remote builds in B14258: Diff 19497!Dec 18 2022, 8:16 PM2022-12-18 20:16:43 (UTC-8) Harbormaster failed remote builds in B14285: Diff 19524!Dec 18 2022, 8:49 PM2022-12-18 20:49:49 (UTC-8) Comment Actions Generally looks like a standard Expo upgrade steps, just have two questions before accepting
Harbormaster failed remote builds in B14337: Diff 19586!Dec 19 2022, 8:29 AM2022-12-19 08:29:03 (UTC-8) Harbormaster failed remote builds in B14370: Diff 19619!Dec 19 2022, 8:58 AM2022-12-19 08:58:02 (UTC-8) This revision is now accepted and ready to land.Dec 19 2022, 9:08 AM2022-12-19 09:08:14 (UTC-8) This revision now requires review to proceed.Dec 19 2022, 9:45 AM2022-12-19 09:45:18 (UTC-8)
Comment Actions Just making sure that you haven't missed my previous comment about package versions of expo-* dependencies: This revision now requires changes to proceed.Dec 19 2022, 12:14 PM2022-12-19 12:14:33 (UTC-8) Comment Actions Ouch, we commented at the same time ;) Edit:
Sounds reasonable to me. The lockfile should stay unchanged so this shoulnd't be a problematic change This revision is now accepted and ready to land.Dec 19 2022, 12:18 PM2022-12-19 12:18:50 (UTC-8) Harbormaster failed remote builds in B14437: Diff 19692!Dec 19 2022, 12:25 PM2022-12-19 12:25:30 (UTC-8) Harbormaster failed remote builds in B14552: Diff 19812!Dec 20 2022, 11:13 AM2022-12-20 11:13:30 (UTC-8) This revision was landed with ongoing or failed builds.Dec 20 2022, 12:00 PM2022-12-20 12:00:57 (UTC-8) Closed by commit rCOMMec08688339f1: [native] [13/40] RN 0.70: Expo upgrade (authored by ashoat). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 19853 native/android/app/build.gradle
native/android/app/src/main/java/app/comm/android/MainApplication.java
native/ios/Comm.xcodeproj/project.pbxproj
native/ios/Comm/AppDelegate.h
native/ios/Comm/AppDelegate.mm
native/ios/Podfile
native/ios/Podfile.lock
|