Page MenuHomePhabricator
Differential D7733

[native] Display a button and navigate to invite links if they are present
ClosedPublic
Actions

Authored by tomek on May 5 2023, 9:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 2:18 PM
Unknown Object (File)
Mon, Mar 17, 2:18 PM
Unknown Object (File)
Mon, Mar 17, 2:18 PM
Unknown Object (File)
Mon, Mar 17, 2:18 PM
Unknown Object (File)
Mon, Mar 17, 2:18 PM
Unknown Object (File)
Mon, Mar 17, 2:18 PM
Unknown Object (File)
Mon, Mar 17, 2:18 PM
Unknown Object (File)
Mon, Mar 17, 2:18 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
bartek
kamil
inka
Commits
rCOMM3042239308b1: [native] Display a button and navigate to invite links if they are present
Summary

When a community has a primary link, display three dots button next to it. The links are updated on every drawer open. Clicking this link shows a button that can be used to open a modal with the links.

Depends on D7730

Test Plan

Create a primary link for one community. Check if the button is displayed next to it. Click the button and open invite links modal - it should contain the link.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.May 5 2023, 9:00 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 5 2023, 9:00 AM
tomek edited the summary of this revision. (Show Details)May 5 2023, 9:02 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 5 2023, 9:12 AM
Harbormaster failed remote builds in B19077: Diff 26125!
tomek updated this revision to Diff 26177.May 8 2023, 4:03 AM

Rebase

Harbormaster completed remote builds in B19123: Diff 26177.May 8 2023, 4:26 AM
tomek requested review of this revision.May 8 2023, 4:26 AM
ashoat added inline comments.May 8 2023, 6:48 AM
native/navigation/community-drawer-item.react.js
208 ↗(On Diff #26177)

It looks like we don't care about the return type, so should we return mixed there? That will make it easier to eg. pass in an async function in case we ever need to do that

inka added inline comments.May 9 2023, 5:37 AM
lib/utils/drawer-utils.react.js
49 ↗(On Diff #26177)

can there be links for subchannels?

tomek added inline comments.May 10 2023, 8:44 AM
lib/utils/drawer-utils.react.js
49 ↗(On Diff #26177)

Maybe in the future we could consider this, but probably not in the near future. Going to make inviteLink undefined for the subchannels.

native/navigation/community-drawer-item.react.js
208 ↗(On Diff #26177)

I've been suggesting this to people, but now I've made the same mistake. Sure, it should be mixed.

tomek updated this revision to Diff 26352.May 10 2023, 8:46 AM

Do not pass invite links to subchannels. Update return type to mixed.

Harbormaster failed remote builds in B19250: Diff 26352!May 10 2023, 9:01 AM
tomek updated this revision to Diff 26441.May 15 2023, 3:11 AM

Rebase

Harbormaster failed remote builds in B19327: Diff 26441!May 15 2023, 3:17 AM
Harbormaster completed remote builds in B19327: Diff 26441.May 15 2023, 7:41 AM
tomek updated this revision to Diff 26550.May 16 2023, 8:34 AM

Use new navigation structure

tomek edited the summary of this revision. (Show Details)May 16 2023, 8:38 AM
Harbormaster completed remote builds in B19407: Diff 26550.May 16 2023, 8:54 AM
tomek updated this revision to Diff 26557.May 16 2023, 9:01 AM

Select action sheet theme

Harbormaster completed remote builds in B19414: Diff 26557.May 16 2023, 9:19 AM
kamil accepted this revision.May 17 2023, 3:35 AM
This revision is now accepted and ready to land.May 17 2023, 3:35 AM
tomek updated this revision to Diff 26680.May 19 2023, 9:51 AM

Extract button component

tomek requested review of this revision.May 19 2023, 9:52 AM

The code changed significantly. It is much simpler, though.

tomek added a child revision: D7762: [lib] Introduce a new permission for managing invite links.May 19 2023, 9:53 AM
Harbormaster completed remote builds in B19513: Diff 26680.May 19 2023, 10:09 AM
kamil accepted this revision.May 22 2023, 7:54 AM
kamil added inline comments.
native/invite-links/invite-links-button.react.js
46 ↗(On Diff #26680)

I think this can be defined outside of the component

This revision is now accepted and ready to land.May 22 2023, 7:54 AM
tomek added inline comments.May 23 2023, 5:32 AM
native/invite-links/invite-links-button.react.js
46 ↗(On Diff #26680)

Yes, but a couple of diffs later D7881 this becomes more complicated.

Closed by commit rCOMM3042239308b1: [native] Display a button and navigate to invite links if they are present (authored by tomek). · Explain WhyMay 24 2023, 4:23 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM3042239308b1: [native] Display a button and navigate to invite links if they are present.
ashoat mentioned this in D10174: [native] Remove async IIFE in CommunityDrawerContent effect.Dec 4 2023, 1:16 PM
ashoat mentioned this in rCOMM1167f5350c24: [native] Remove async IIFE in CommunityDrawerContent effect.Dec 5 2023, 12:33 PM

Revision Contents
Changeset List

PathSize
lib/
utils/
4 lines
native/
navigation/
65 lines
72 lines

Diff 26550

View Options

lib/utils/drawer-utils.react.js

Show All 18 Linesset(NATIVE_HDRS
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h" "ThreadActivityStoreOperations.h"
"EntryStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h ${_data_stores_path}/ThreadActivityStore.h
${_data_stores_path}/EntryStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp ${_data_stores_path}/ThreadActivityStore.cpp
${_data_stores_path}/EntryStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines
View Options

native/navigation/community-drawer-content.react.js

Show All 18 Linesset(NATIVE_HDRS
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h" "ThreadActivityStoreOperations.h"
"EntryStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h ${_data_stores_path}/ThreadActivityStore.h
${_data_stores_path}/EntryStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp ${_data_stores_path}/ThreadActivityStore.cpp
${_data_stores_path}/EntryStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines
View Options

native/navigation/community-drawer-item.react.js

Show All 18 Linesset(NATIVE_HDRS
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h" "ThreadActivityStoreOperations.h"
"EntryStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h ${_data_stores_path}/ThreadActivityStore.h
${_data_stores_path}/EntryStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp ${_data_stores_path}/ThreadActivityStore.cpp
${_data_stores_path}/EntryStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines