[native] Add a link to manage public link screen
ClosedPublic
Actions

Authored by tomek on May 19 2023, 10:18 AM.

Details

Reviewers

bartek
kamil
inka

Commits

rCOMMe6891cd75195: [native] Add a link to manage public link screen

Summary

The link is visible only to admin users.

Depends on D7884

Test Plan

Check if a link is visible only to admin users and if clicking it navigates the user to manage links screen.

Diff Detail

Repository

rCOMM Comm

Branch

invite2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.May 19 2023, 10:18 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 19 2023, 10:18 AM

Harbormaster completed remote builds in B19521: Diff 26688.May 19 2023, 10:35 AM

tomek requested review of this revision.May 19 2023, 10:35 AM

tomek added a child revision: D7906: [keyserver] Create an endpoint that allows disabling links.May 22 2023, 6:25 AM

Can you share a screenshot of how this looks like?

native/invite-links/view-invite-links-screen.react.js
17–18	can be merged
59	maybe it'll be better to call this once and store result in variable instead of calling twice

This revision is now accepted and ready to land.May 22 2023, 9:52 AM

tomek edited the summary of this revision. (Show Details)May 23 2023, 6:29 AM

Minor fixes

In D7885#234677, @kamil wrote:

Can you share a screenshot of how this looks like?

Added to a summary.

Harbormaster completed remote builds in B19673: Diff 26881.May 23 2023, 6:54 AM

tomek mentioned this in D7730: [native] Create a modal where invite links are displayed.May 23 2023, 7:20 AM

Closed by commit rCOMMe6891cd75195: [native] Add a link to manage public link screen (authored by tomek). · Explain WhyMay 24 2023, 4:23 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMe6891cd75195: [native] Add a link to manage public link screen.

Revision Contents
Changeset List

Path

Size

native/

invite-links/

view-invite-links-screen.react.js

47 lines

Diff 26688

View Options

native/invite-links/view-invite-links-screen.react.js

[native] Add a link to manage public link screenClosedPublicActions