[keyserver] Convert flag to a boolean
ClosedPublic
Actions

Authored by tomek on May 23 2023, 6:04 AM.

Tags

None

Referenced Files

	F3349312: D7941.id26874.diff
	Fri, Nov 22, 5:38 PM

	Unknown Object (File)
	Mon, Oct 28, 8:48 AM

	Unknown Object (File)
	Oct 22 2024, 9:14 PM

	Unknown Object (File)
	Oct 22 2024, 1:36 PM

	Unknown Object (File)
	Oct 22 2024, 1:12 PM

	Unknown Object (File)
	Oct 22 2024, 6:54 AM

	Unknown Object (File)
	Oct 18 2024, 9:42 PM

	Unknown Object (File)
	Oct 1 2024, 7:48 AM

View All 72 Files

Subscribers

ashoat

atul

Details

Reviewers

bartek
kamil
inka
michal

Commits

rCOMM4f0eb1d7c7a6: [keyserver] Convert flag to a boolean

Summary

Instead of returning a boolean we were returning a number. Everything worked correctly, because 0 is falsy. Only recently introduced output validator made the bug evident.

Test Plan

Check if fetching invite links works.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.May 23 2023, 6:04 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 23 2023, 6:04 AM

tomek added a parent revision: D7876: [lib] Update invite link type.May 23 2023, 6:06 AM

tomek added a child revision: D7877: [lib] Create a store in redux for the invite links.

Harbormaster completed remote builds in B19666: Diff 26874.May 23 2023, 6:23 AM

tomek requested review of this revision.May 23 2023, 6:23 AM

michal accepted this revision.May 23 2023, 7:12 AM

This revision is now accepted and ready to land.May 23 2023, 7:12 AM

Closed by commit rCOMM4f0eb1d7c7a6: [keyserver] Convert flag to a boolean (authored by tomek). · Explain WhyMay 24 2023, 4:23 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM4f0eb1d7c7a6: [keyserver] Convert flag to a boolean.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

link-fetchers.js

2 lines

Diff 26962

View Options

keyserver/src/fetchers/link-fetchers.js

[keyserver] Convert flag to a booleanClosedPublicActions