- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Mar 16 2023
Looks good to me
Mar 15 2023
i'm a little confused why we're moving config.rs and constants.rs into this cargo project. they seem pretty specific to the identity service.
Open to decreasing media width
I feel like we should still reduce the width for viewer-composed multimedia messages so all the multimedia messages have a consistently smaller size,
rebase before landing
rebase and land
extract useSignedIdentityKeysBlob hook to cut repetition
fix maxWidth for chat bubble so it's not poking out anymore (see test plan for visulization)
Seems uncontroversial
This is the last diff in the stack that I planned on putting up Monday/Tuesday, but ran into issues with D7081. Going to do some additional testing before landing to be extra careful.
rebase
i'm a little confused why we're moving config.rs and constants.rs into this cargo project. they seem pretty specific to the identity service. if we decide we want to store the secret key in a different location, it feels awkward that we'd have to modify a library that the identity service consumes rather than the service's own config
Thanks!! Can you send that over to Ted on the design team to make sure he approves of the changes to FailedSend? (It's worth mentioning to Ted that it's not possible for both FailedSend and the edited label to appear at the same time.)
In D7017#209805, @ashoat wrote:Can you share an updated screenshot?
Hmm, not sure if that's an issue or not. I think it might be best to try using things like paddingLeft / marginLeft instead of left and position: 'absolute'... worried that border miscalculations can lead to issues, but not immediately sure what sort of concrete issues
With the red border, is that a parent component of the message box? (Generally I would expect the parent component to enclose the child component.)
Should I decrease the width of the inner message (the chat bubble that is sticking out), or should we increase the width of the message box of the composed message (currently has the red border around it)? I personally think there is still enough space on the right side to just increase the width of the message box, but if we think it would be better to decrease the width of the inner message to fit inside the message box lmk
Have you made sure that that the height measurement code is still working correctly?
thanks for doing this!
In D6993#209859, @tomek wrote:Do we know how this diff corresponds to https://linear.app/comm/issue/ENG-3322/fix-stale-cache-error-for-olmwasm#comment-d1aabe3d? Maybe this will somehow improve the experience about the path's configuration?
In D7058#209899, @ashoat wrote:Why hasn't this been landed? It's an urgent issue and the diff was accepted on Monday...
In D6921#209900, @ashoat wrote:Why hasn't this been landed? As mentioned on Monday, we need to create a release with these changes ASAP so we can test the before the end of the month...
Rebase before landing. Add check for code version
Rebase before landing. Extract thread ID key to constant
Rebase before landing