Page MenuHomePhabricator
Feed All Stories

Mar 16 2023

atul committed rCOMMccb5daf8d543: Bump activesupport from 6.1.7.1 to 6.1.7.3 in /native (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump activesupport from 6.1.7.1 to 6.1.7.3 in /native
Mar 16 2023, 8:14 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D7032: [desktop] Handle autoUpdate errors.
Mar 16 2023, 7:47 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMe37c0d6f5d79: [desktop] Handle autoUpdate errors (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[desktop] Handle autoUpdate errors
Mar 16 2023, 7:47 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D7030: [web] Use notifPermissionAlertInfo.
Mar 16 2023, 7:45 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMabde466ef6fe: [web] Use notifPermissionAlertInfo (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web] Use notifPermissionAlertInfo
Mar 16 2023, 7:45 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D7029: [native] Move NotifPermissionAlertInfo to lib.
Mar 16 2023, 7:45 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM350edf6e7f6d: [native] Move NotifPermissionAlertInfo to lib (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[native] Move NotifPermissionAlertInfo to lib
Mar 16 2023, 7:45 AM
michal updated the test plan for D7029: [native] Move NotifPermissionAlertInfo to lib.
Mar 16 2023, 5:23 AM
michal updated the diff for D7030: [web] Use notifPermissionAlertInfo.

Rebase

Mar 16 2023, 5:21 AM
ashoat closed D7072: [landing][web] Migrate from assets-webpack-plugin to webpack-manifest-plugin.
Mar 16 2023, 3:59 AM
ashoat committed rCOMM731fe43071a3: [landing][web] Migrate from assets-webpack-plugin to webpack-manifest-plugin (authored by ashoat).
[landing][web] Migrate from assets-webpack-plugin to webpack-manifest-plugin
Mar 16 2023, 3:59 AM
ashoat closed D7074: [lib][keyserver] Update reaction permission checks to check REACT_TO_MESSAGE.
Mar 16 2023, 3:59 AM
ashoat committed rCOMMc65b067cd70a: [lib][keyserver] Update reaction permission checks to check REACT_TO_MESSAGE (authored by ashoat).
[lib][keyserver] Update reaction permission checks to check REACT_TO_MESSAGE
Mar 16 2023, 3:59 AM
ashoat closed D7073: [lib][keyserver] Introduce new threadPermissions types for reactions.
Mar 16 2023, 3:59 AM
ashoat committed rCOMM84b7cc6a4472: [lib][keyserver] Introduce new threadPermissions types for reactions (authored by ashoat).
[lib][keyserver] Introduce new threadPermissions types for reactions
Mar 16 2023, 3:59 AM
michal accepted D7072: [landing][web] Migrate from assets-webpack-plugin to webpack-manifest-plugin.

Looks good to me

Mar 16 2023, 2:59 AM
bartek accepted D7075: [keyserver] Add natural library for stemming and removing stopwords.
Mar 16 2023, 1:05 AM

Mar 15 2023

• jon planned changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

i'm a little confused why we're moving config.rs and constants.rs into this cargo project. they seem pretty specific to the identity service.

Mar 15 2023, 9:04 PM
ginsu added inline comments to D7067: [native] render user avatars in chat screen.
Mar 15 2023, 5:25 PM
ashoat added a comment to D7067: [native] render user avatars in chat screen.

Open to decreasing media width

Mar 15 2023, 5:21 PM
ginsu attached a referenced file: F428875: 336223399_740379237747150_8312429542900821292_n.jpg.
Mar 15 2023, 5:16 PM
ginsu attached a referenced file: F428877: 336353513_590716002715617_5037247747435841645_n.jpg.
Mar 15 2023, 5:16 PM
ginsu attached a referenced file: F428879: 336162309_908146963557437_5514534208953352892_n.jpg.
Mar 15 2023, 5:16 PM
ginsu added a comment to D7067: [native] render user avatars in chat screen.

I feel like we should still reduce the width for viewer-composed multimedia messages so all the multimedia messages have a consistently smaller size,

Mar 15 2023, 5:15 PM
ginsu attached a referenced file: F428871: Screenshot 2023-03-15 at 7.38.28 PM.png.
Mar 15 2023, 5:01 PM
ginsu planned changes to D7067: [native] render user avatars in chat screen.
Mar 15 2023, 5:01 PM
atul closed D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.
Mar 15 2023, 4:35 PM
atul committed rCOMM734df39d7857: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response (authored by atul).
[keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response
Mar 15 2023, 4:35 PM
atul added inline comments to D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.
Mar 15 2023, 4:32 PM
atul updated the diff for D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.

rebase before landing

Mar 15 2023, 4:32 PM
atul added inline comments to D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.
Mar 15 2023, 4:24 PM
atul closed D7070: [web] Add `CryptoStore` to `persistConfig.whitelist`.
Mar 15 2023, 4:20 PM
atul committed rCOMM6bfaf0746b8f: [web] Add `CryptoStore` to `persistConfig.whitelist` (authored by atul).
[web] Add `CryptoStore` to `persistConfig.whitelist`
Mar 15 2023, 4:20 PM
ashoat added inline comments to D7067: [native] render user avatars in chat screen.
Mar 15 2023, 4:18 PM
atul updated the diff for D7070: [web] Add `CryptoStore` to `persistConfig.whitelist`.

rebase and land

Mar 15 2023, 4:12 PM
atul closed D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.
Mar 15 2023, 3:48 PM
atul committed rCOMM61f34545c837: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();` (authored by atul).
[web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`
Mar 15 2023, 3:48 PM
atul updated the diff for D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.

extract useSignedIdentityKeysBlob hook to cut repetition

Mar 15 2023, 3:34 PM
ginsu added inline comments to D7067: [native] render user avatars in chat screen.
Mar 15 2023, 2:27 PM
ginsu updated the summary of D7067: [native] render user avatars in chat screen.
Mar 15 2023, 2:26 PM
ginsu attached a referenced file: F428737: Screenshot 2023-03-15 at 4.06.49 PM.png.
Mar 15 2023, 2:26 PM
ginsu attached a referenced file: F428736: Screenshot 2023-03-15 at 2.13.21 PM.png.
Mar 15 2023, 2:26 PM
ginsu updated the summary of D7067: [native] render user avatars in chat screen.
Mar 15 2023, 2:26 PM
ginsu updated the diff for D7067: [native] render user avatars in chat screen.

fix maxWidth for chat bubble so it's not poking out anymore (see test plan for visulization)

Mar 15 2023, 2:17 PM
ashoat accepted D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.
Mar 15 2023, 1:54 PM
ashoat accepted D7069: [native] render the rest of the user avatars.

Seems uncontroversial

Mar 15 2023, 1:53 PM
ashoat accepted D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.
Mar 15 2023, 1:51 PM
atul updated the test plan for D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.
Mar 15 2023, 1:45 PM
atul published D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response for review.

This is the last diff in the stack that I planned on putting up Monday/Tuesday, but ran into issues with D7081. Going to do some additional testing before landing to be extra careful.

Mar 15 2023, 1:43 PM
atul updated the diff for D7070: [web] Add `CryptoStore` to `persistConfig.whitelist`.

rebase

Mar 15 2023, 1:16 PM
atul updated the summary of D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.
Mar 15 2023, 1:13 PM
atul updated the summary of D7070: [web] Add `CryptoStore` to `persistConfig.whitelist`.
Mar 15 2023, 1:12 PM
atul updated the test plan for D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.
Mar 15 2023, 1:12 PM
atul published D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();` for review.
Mar 15 2023, 1:10 PM
ashoat requested review of D7079: [lib] Don't refer to children of GENESIS as channels.
Mar 15 2023, 12:35 PM
ashoat requested review of D7080: [lib] Don't mention GENESIS in chat creation notifs.
Mar 15 2023, 12:35 PM
ashoat requested review of D7078: [lib] Pass threadType and parentThreadID to alwaysDisplayShortName ThreadEntity.
Mar 15 2023, 12:33 PM
varun requested changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 15 2023, 12:29 PM
varun added a comment to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

i'm a little confused why we're moving config.rs and constants.rs into this cargo project. they seem pretty specific to the identity service. if we decide we want to store the secret key in a different location, it feels awkward that we'd have to modify a library that the identity service consumes rather than the service's own config

Mar 15 2023, 12:29 PM
ashoat added a comment to D7017: [web] Added displaying 'Labels' to InlineEngagment.

Thanks!! Can you send that over to Ted on the design team to make sure he approves of the changes to FailedSend? (It's worth mentioning to Ted that it's not possible for both FailedSend and the edited label to appear at the same time.)

Mar 15 2023, 12:24 PM
• kuba added a comment to D7017: [web] Added displaying 'Labels' to InlineEngagment.

Can you share an updated screenshot?

Mar 15 2023, 12:16 PM
ashoat added a comment to D7067: [native] render user avatars in chat screen.

Hmm, not sure if that's an issue or not. I think it might be best to try using things like paddingLeft / marginLeft instead of left and position: 'absolute'... worried that border miscalculations can lead to issues, but not immediately sure what sort of concrete issues

Mar 15 2023, 12:14 PM
ginsu added a comment to D7067: [native] render user avatars in chat screen.

With the red border, is that a parent component of the message box? (Generally I would expect the parent component to enclose the child component.)

Mar 15 2023, 12:11 PM
ashoat added a comment to D7067: [native] render user avatars in chat screen.

Should I decrease the width of the inner message (the chat bubble that is sticking out), or should we increase the width of the message box of the composed message (currently has the red border around it)? I personally think there is still enough space on the right side to just increase the width of the message box, but if we think it would be better to decrease the width of the inner message to fit inside the message box lmk

Mar 15 2023, 12:05 PM
ginsu attached a referenced file: F428518: Screenshot 2023-03-15 at 2.13.21 PM.png.
Mar 15 2023, 11:36 AM
ginsu planned changes to D7067: [native] render user avatars in chat screen.

Have you made sure that that the height measurement code is still working correctly?

Mar 15 2023, 11:35 AM
atul committed rCOMM7bbc37d4486f: Bump sqlite3 from 5.1.2 to 5.1.5 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump sqlite3 from 5.1.2 to 5.1.5
Mar 15 2023, 11:10 AM
atul committed rCOMMd5870e96ded1: Bump openssl-src in /services/tunnelbroker (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump openssl-src in /services/tunnelbroker
Mar 15 2023, 11:08 AM
atul committed rCOMMead0fc5d467d: Bump webpack from 5.75.0 to 5.76.0 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump webpack from 5.75.0 to 5.76.0
Mar 15 2023, 11:07 AM
atul committed rCOMMaf9e74003217: Revert "[native] Temporary changes for staff release" (authored by atul).
Revert "[native] Temporary changes for staff release"
Mar 15 2023, 11:04 AM
atul added a reverting change for rCOMM52f4a8f5d972: [native] Temporary changes for staff release: rCOMMaf9e74003217: Revert "[native] Temporary changes for staff release".
Mar 15 2023, 11:04 AM
atul committed rCOMMeaa353868c78: [native] `codeVersion` -> 200 (authored by atul).
[native] `codeVersion` -> 200
Mar 15 2023, 11:04 AM
atul committed rCOMM52f4a8f5d972: [native] Temporary changes for staff release (authored by atul).
[native] Temporary changes for staff release
Mar 15 2023, 11:04 AM
atul committed rCOMM62a4d758338d: [native] `codeVersion` -> 199 (authored by atul).
[native] `codeVersion` -> 199
Mar 15 2023, 11:04 AM
michal accepted D6996: [web-db] generate `CryptoKey` and persist.
Mar 15 2023, 10:53 AM
michal accepted D6987: [web-db] add Shared Worker config.
Mar 15 2023, 10:52 AM
ginsu accepted D7074: [lib][keyserver] Update reaction permission checks to check REACT_TO_MESSAGE.

thanks for doing this!

Mar 15 2023, 9:19 AM
ginsu accepted D7073: [lib][keyserver] Introduce new threadPermissions types for reactions.
Mar 15 2023, 9:18 AM
marcin closed D6922: Permanently enable rescind and visible notifications processing via NotificationService.
Mar 15 2023, 7:45 AM
marcin closed D6920: Modify TemporaryMessageStorage API, so that we can have two storages: one (created by default init) for messages and the other for rescinds..
Mar 15 2023, 7:45 AM
marcin closed D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start..
Mar 15 2023, 7:45 AM
marcin committed rCOMM523b192eaa62: Permanently enable rescind and visible notifications processing via… (authored by marcin).
Permanently enable rescind and visible notifications processing via…
Mar 15 2023, 7:45 AM
marcin committed rCOMMfaf07ac262f5: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses… (authored by marcin).
Persist rescinds payloads in NSE so that AppDelegate can update thread statuses…
Mar 15 2023, 7:45 AM
marcin committed rCOMM7d230d26f9cb: Modify TemporaryMessageStorage API, so that we can have two storages: one… (authored by marcin).
Modify TemporaryMessageStorage API, so that we can have two storages: one…
Mar 15 2023, 7:45 AM
marcin closed D6918: Silence rescinds in NSE.
Mar 15 2023, 7:45 AM
marcin closed D6919: Remove relevant notification from notifications center when receiving rescind in NSE.
Mar 15 2023, 7:45 AM
marcin committed rCOMMb155617fd0d7: Remove relevant notification from notifications center when receiving rescind… (authored by marcin).
Remove relevant notification from notifications center when receiving rescind…
Mar 15 2023, 7:45 AM
marcin committed rCOMM70905d6a8d4d: Silence rescinds in NSE (authored by marcin).
Silence rescinds in NSE
Mar 15 2023, 7:45 AM
marcin closed D6917: Prepare to conditionally process rescinds in NSE..
Mar 15 2023, 7:45 AM
marcin committed rCOMM4f2022de618b: Prepare to conditionally process rescinds in NSE. (authored by marcin).
Prepare to conditionally process rescinds in NSE.
Mar 15 2023, 7:45 AM
ashoat added inline comments to D7077: [keyserver] Process new messages for search.
Mar 15 2023, 7:41 AM
ashoat requested changes to D7076: [keyserver] Add search table to the db.
Mar 15 2023, 7:40 AM
ashoat accepted D7075: [keyserver] Add natural library for stemming and removing stopwords.
Mar 15 2023, 7:28 AM
ashoat added a comment to D6993: [web-db] initialize SQLite database.
In D6993#209859, @tomek wrote:

Do we know how this diff corresponds to https://linear.app/comm/issue/ENG-3322/fix-stale-cache-error-for-olmwasm#comment-d1aabe3d? Maybe this will somehow improve the experience about the path's configuration?

Mar 15 2023, 7:27 AM
Harbormaster failed remote builds in B17346: Diff 23757 for D6920: Modify TemporaryMessageStorage API, so that we can have two storages: one (created by default init) for messages and the other for rescinds.!
Mar 15 2023, 7:23 AM
marcin added a comment to D7058: Use initial notifications from queue rather than from launch options.

Why hasn't this been landed? It's an urgent issue and the diff was accepted on Monday...

Mar 15 2023, 7:17 AM
marcin added a comment to D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start..

Why hasn't this been landed? As mentioned on Monday, we need to create a release with these changes ASAP so we can test the before the end of the month...

Mar 15 2023, 7:15 AM
marcin updated the diff for D6922: Permanently enable rescind and visible notifications processing via NotificationService.

Rebase before landing. Add check for code version

Mar 15 2023, 7:10 AM
marcin updated the diff for D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start..

Rebase before landing. Extract thread ID key to constant

Mar 15 2023, 7:10 AM
marcin updated the diff for D6920: Modify TemporaryMessageStorage API, so that we can have two storages: one (created by default init) for messages and the other for rescinds..

Rebase before landing

Mar 15 2023, 7:09 AM