Page MenuHomePhabricator
Feed Advanced Search

Sep 13 2023

michal accepted D9165: [terraform] Add Tunnelbroker.

Would it make sense to add apply_immediately (at least for staging)? If I understand the documentation correctly, currently if we make changes to the user (or add broker configuration) we would have to reboot rabbitmq manually?

Sep 13 2023, 7:02 AM
michal accepted D9162: [secrets] Generate RabbitMQ passwords.
Sep 13 2023, 6:30 AM
michal accepted D9160: [tunnelbroker] Use Hyper service instead of tokio_tungstenite.
Sep 13 2023, 6:21 AM
michal accepted D9158: [tunnelbroker] Hyper service for WebSocket connections.
Sep 13 2023, 6:10 AM
michal accepted D7691: [Keyserver] Open websocket connection with tunnelbroker.
Sep 13 2023, 6:03 AM
michal accepted D9156: [tunnelbroker] Make WebSocketSession generic.
Sep 13 2023, 5:44 AM
michal accepted D9153: [tunnelbroker] Allow configuring AMQP credentials.
Sep 13 2023, 5:44 AM
michal added a comment to D9156: [tunnelbroker] Make WebSocketSession generic.

Is generic-ness of this is going to be helpful in the future? Or is it going to be always HyperWebsocket under the hood? Because in that case we should just remove the generics and use HyperWebsocket directly

Sep 13 2023, 1:33 AM
michal accepted D9155: [tunnelbroker] Don't listen on localhost only.
Sep 13 2023, 1:19 AM
michal added inline comments to D9153: [tunnelbroker] Allow configuring AMQP credentials.
Sep 13 2023, 12:54 AM
michal accepted D9139: [feature-flags] Use default HTTP port for deployments.

Should we also update the docker-compose.yml to use the new port?

Sep 13 2023, 12:44 AM
michal accepted D9137: [services] Delete base-image and sandbox mode.

Nice!

Sep 13 2023, 12:35 AM

Sep 12 2023

michal added a comment to D7691: [Keyserver] Open websocket connection with tunnelbroker.

LGTM, mostly just a rename

Sep 12 2023, 6:33 AM
michal requested review of D9148: [web/keyserver] Handle different thread ids in url.
Sep 12 2023, 5:54 AM
michal requested review of D9147: [lib/web/native] Improve conversion utils.
Sep 12 2023, 5:38 AM
michal requested review of D9146: [keyserver] Remove unused params in validation functions.
Sep 12 2023, 5:29 AM
michal requested review of D9145: [web] Remove intial redux state from website responders.
Sep 12 2023, 5:25 AM
michal requested review of D9141: [web] Use new intial redux state.
Sep 12 2023, 3:50 AM
michal requested review of D9140: [web] Add setInitialReduxState action.
Sep 12 2023, 3:39 AM
michal added a comment to D9124: [keyserver] Implement `getInitialReduxStateResponder`.

Probably moving policies logic from the responder itself to a higher place where we just avoid returning anything will make this code simpler - but since this will change in the future anyway (ENG-4137) it's okay the way it is

Sep 12 2023, 2:03 AM
michal updated the diff for D9124: [keyserver] Implement `getInitialReduxStateResponder`.

Merge

Sep 12 2023, 2:02 AM
michal updated the diff for D9122: [keyserver] Introduce getInitialReduxStateResponder.

Small fixes

Sep 12 2023, 2:00 AM
michal added inline comments to D9122: [keyserver] Introduce getInitialReduxStateResponder.
Sep 12 2023, 2:00 AM
michal requested review of D9109: [web] Enable db for all users.
Sep 12 2023, 1:42 AM
michal updated the diff for D9109: [web] Enable db for all users.

Amend test plan, don't set userID if not needed. Also added a log for clearing sensitive data.

Sep 12 2023, 1:41 AM
michal updated the test plan for D9109: [web] Enable db for all users.
Sep 12 2023, 1:39 AM
michal added a comment to D9139: [feature-flags] Use default HTTP port for deployments.

Should we also update the docker-compose.yml to use the new port?

Sep 12 2023, 12:34 AM
michal accepted D9138: [feature-flags] Standardize localstack and http config.
Sep 12 2023, 12:27 AM

Sep 11 2023

michal accepted D9128: [Tunnelbroker] match JS naming convention.
Sep 11 2023, 11:32 PM
michal accepted D9104: [web] Fix nested a tags.
Sep 11 2023, 7:11 AM
michal accepted D9125: [keyserver] fix fetching identity info.
Sep 11 2023, 7:00 AM
michal accepted D9123: [web] Fix warnings on search screen.
Sep 11 2023, 6:36 AM
michal requested review of D9124: [keyserver] Implement `getInitialReduxStateResponder`.
Sep 11 2023, 6:30 AM
michal updated the summary of D9122: [keyserver] Introduce getInitialReduxStateResponder.
Sep 11 2023, 6:19 AM
michal accepted D9104: [web] Fix nested a tags.

Thank you for fixing this!

Sep 11 2023, 5:33 AM
michal accepted D9117: [feature-flags] Update Dockerfile.
Sep 11 2023, 5:29 AM
michal accepted D9116: [blob-service] Update Dockerfile.
Sep 11 2023, 5:28 AM
michal requested review of D9122: [keyserver] Introduce getInitialReduxStateResponder.
Sep 11 2023, 4:21 AM
michal added inline comments to D9109: [web] Enable db for all users.
Sep 11 2023, 1:25 AM
michal updated the diff for D9109: [web] Enable db for all users.

Rename shouldRestart, start db intialization on load, add comment for transform migration

Sep 11 2023, 1:25 AM
michal updated the diff for D9108: [web] Initialize database at startup on safari.

Change initError to notSupported, move safari key init after setting status to initInProgress

Sep 11 2023, 12:32 AM

Sep 8 2023

michal updated the diff for D9110: [web] Migrate drafts to db for everyone.

Instead of removing the previous migration, make it noop.

Sep 8 2023, 7:52 AM
michal requested review of D9111: [keyserver] Remove old current user info.
Sep 8 2023, 7:52 AM
michal requested review of D9110: [web] Migrate drafts to db for everyone.
Sep 8 2023, 7:12 AM
michal requested review of D9109: [web] Enable db for all users.
Sep 8 2023, 6:58 AM
michal requested review of D9108: [web] Initialize database at startup on safari.
Sep 8 2023, 6:07 AM
michal requested review of D9107: [web] Move safari db key init to database module.
Sep 8 2023, 5:54 AM
michal requested review of D9105: [web] Hide databaseModule behind a function.
Sep 8 2023, 4:20 AM

Sep 7 2023

michal updated the diff for D9066: [backup] Setup terraform.

Change temporary docker repo to commapp

Sep 7 2023, 2:30 AM
michal commandeered D9038: [terraform] Set up ECS Service Connect.
Sep 7 2023, 2:07 AM

Sep 5 2023

michal accepted D9078: [keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux top level.

LGTM, could you check that it still works with something like this:

Sep 5 2023, 5:56 AM
michal accepted D9075: [client-backup] set backup-service prod URL.
Sep 5 2023, 5:52 AM
michal accepted D9079: [lib][web][native] Start using lastCommunicatedPlatformDetailsSelector from keyserverStore.
Sep 5 2023, 5:49 AM
michal accepted D9077: [keyserver][lib][native] Add lastCommunicatedPlatformDetails to keyserverStore.
Sep 5 2023, 5:49 AM
michal accepted D9062: [web] Start persisting keyserverStore.
Sep 5 2023, 5:46 AM
michal accepted D9082: [client-backup] exclude non-password users.
Sep 5 2023, 5:29 AM
michal accepted D9080: [client-backup] rename `recentBackupHash` -> `mostRecentlyUploadedBackupHash`.
Sep 5 2023, 5:26 AM
michal accepted D9038: [terraform] Set up ECS Service Connect.
Sep 5 2023, 12:44 AM

Sep 4 2023

michal accepted D9010: [client-backup] add local settings to store.
Sep 4 2023, 8:34 AM
michal accepted D9003: [client-backup] implement backup handler.
Sep 4 2023, 8:31 AM
michal requested changes to D9062: [web] Start persisting keyserverStore.
Sep 4 2023, 4:10 AM

Sep 1 2023

michal requested review of D9066: [backup] Setup terraform.
Sep 1 2023, 7:39 AM
michal requested review of D9065: [backup] Make blob url configurable with env var.
Sep 1 2023, 7:34 AM
michal requested review of D9064: [backup] Add health endpoint.
Sep 1 2023, 7:33 AM
michal requested review of D9063: [backup] Update backup dockerfile.
Sep 1 2023, 7:32 AM
michal accepted D9062: [web] Start persisting keyserverStore.

LGTM

Sep 1 2023, 6:28 AM
michal accepted D9060: [lib] Refactor lastCommunicatedPlatformDetails to be PlatformDetails.
Sep 1 2023, 6:27 AM

Aug 31 2023

michal added inline comments to D9016: [backup] Improve attachment handling.
Aug 31 2023, 7:37 AM
michal updated the diff for D9016: [backup] Improve attachment handling.

More consistent vec creation

Aug 31 2023, 7:37 AM
michal added a comment to D9038: [terraform] Set up ECS Service Connect.

LGTM, would be good for someone working on identity to look over this

Aug 31 2023, 7:26 AM
michal accepted D9040: [terraform] Add reports service.

LGTM (would be nice to have ENG-4548)

Aug 31 2023, 7:26 AM
michal accepted D9037: [reports-service] Add Dockerfile.

Is there a reason for not building dependencies on another layer?

Aug 31 2023, 7:06 AM
michal added a comment to D9036: [dockerignore] Add missing entries.

The whole native, with some exceptions, is already added.

Aug 31 2023, 6:25 AM
michal accepted D9039: [secrets] Add e-mail config for reports.
Aug 31 2023, 2:53 AM
michal accepted D9036: [dockerignore] Add missing entries.

Can we also add native/native_rust_library/target?

Aug 31 2023, 2:25 AM
michal accepted D9035: [reports-service] Encrypt reports.
Aug 31 2023, 1:50 AM
michal accepted D9046: [terraform] Add workspace check.
Aug 31 2023, 1:41 AM
michal added 1 blocking reviewer(s) for D9034: [services-lib] Introduce crypto module: tomek.

Adding tomek as blocking because of new deps. Left some comments regarding the rust code side, but I'm not really familiar with crypto so hoping someone else will also look at it

Aug 31 2023, 1:38 AM

Aug 30 2023

michal added inline comments to D9002: [client-backup] implement initial restore backup protocol.
Aug 30 2023, 7:08 AM
michal accepted D9001: [client-backup] implement initial backup protocol.
Aug 30 2023, 7:04 AM
michal accepted D9023: [keyserver][lib][native][web] Remove connection field from redux.
Aug 30 2023, 6:15 AM
michal accepted D9022: [lib][native][web] Use connection from keyserverStore.
Aug 30 2023, 6:14 AM
michal accepted D9021: [keyserver][lib][native] Add connection to keyserverStore.
Aug 30 2023, 5:58 AM
michal accepted D9020: [lib][native] Stop persisting connection.
Aug 30 2023, 5:53 AM
michal accepted D9018: [kesyerver][lib][native][web] Move actualizedCalendarQuery out of connection.
Aug 30 2023, 5:52 AM
michal requested review of D9019: [backup] Update db constants.
Aug 30 2023, 3:02 AM
michal requested review of D9017: [backup] Cleanup utils.
Aug 30 2023, 2:50 AM
michal requested review of D9016: [backup] Improve attachment handling.
Aug 30 2023, 2:44 AM
michal added 1 blocking reviewer(s) for D8987: [reports-service] Add functions to send e-mails: tomek.
Aug 30 2023, 1:54 AM
michal added 1 blocking reviewer(s) for D8983: [reports-service] Introduce e-mail template: tomek.
Aug 30 2023, 1:53 AM
michal added 1 blocking reviewer(s) for D8975: [reports-service] Implement Blob storage: tomek.
Aug 30 2023, 1:53 AM
michal requested changes to D9014: [Commtest] Remove backup gRPC tests.

Landed D8966 so we can cancel this

Aug 30 2023, 1:28 AM
michal updated the diff for D8969: [Backup] Old backup cleanup.

Rebase, improve how we skip the latest backup when removing old backups (search for the backup with max creation time)

Aug 30 2023, 1:06 AM
michal updated the diff for D8963: [backup] Introduce upload endpoint.

Rebase, fix typos, introduce get_named_text_field function

Aug 30 2023, 12:58 AM
michal added a comment to D8978: [reports-service] Introduce emails config.

Would something like this work?

Aug 30 2023, 12:01 AM

Aug 29 2023

michal accepted D9014: [Commtest] Remove backup gRPC tests.

I'm probably going to land the test improvements this morning, but accepting if it's blocking someone. I will rebase over this diff if required. If I land first we cancel this

Aug 29 2023, 11:10 PM
michal added inline comments to D8962: [backup] Update `BlobItem`.
Aug 29 2023, 10:55 AM
michal updated the diff for D8953: [backup] Split database module.

Fix constant

Aug 29 2023, 10:53 AM
michal added inline comments to D8953: [backup] Split database module.
Aug 29 2023, 10:53 AM
michal added inline comments to D8952: [backup] Introduce backup error.
Aug 29 2023, 10:48 AM