Would it make sense to add apply_immediately (at least for staging)? If I understand the documentation correctly, currently if we make changes to the user (or add broker configuration) we would have to reboot rabbitmq manually?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Sep 13 2023
Is generic-ness of this is going to be helpful in the future? Or is it going to be always HyperWebsocket under the hood? Because in that case we should just remove the generics and use HyperWebsocket directly
Should we also update the docker-compose.yml to use the new port?
Sep 12 2023
LGTM, mostly just a rename
Probably moving policies logic from the responder itself to a higher place where we just avoid returning anything will make this code simpler - but since this will change in the future anyway (ENG-4137) it's okay the way it is
Merge
Small fixes
Amend test plan, don't set userID if not needed. Also added a log for clearing sensitive data.
Should we also update the docker-compose.yml to use the new port?
Sep 11 2023
Rename shouldRestart, start db intialization on load, add comment for transform migration
Change initError to notSupported, move safari key init after setting status to initInProgress
Sep 8 2023
Instead of removing the previous migration, make it noop.
Sep 7 2023
Change temporary docker repo to commapp
Sep 5 2023
LGTM, could you check that it still works with something like this:
Sep 4 2023
Sep 1 2023
Aug 31 2023
More consistent vec creation
LGTM, would be good for someone working on identity to look over this
LGTM (would be nice to have ENG-4548)
Is there a reason for not building dependencies on another layer?
The whole native, with some exceptions, is already added.
Can we also add native/native_rust_library/target?
Adding tomek as blocking because of new deps. Left some comments regarding the rust code side, but I'm not really familiar with crypto so hoping someone else will also look at it
Aug 30 2023
Landed D8966 so we can cancel this
Rebase, improve how we skip the latest backup when removing old backups (search for the backup with max creation time)
Rebase, fix typos, introduce get_named_text_field function
Would something like this work?
Aug 29 2023
I'm probably going to land the test improvements this morning, but accepting if it's blocking someone. I will rebase over this diff if required. If I land first we cancel this