Page MenuHomePhabricator
Feed Advanced Search

Mar 6 2024

tomek accepted D11246: [scripts] Add scrips for setting up a new authoritative keyserver.
Mar 6 2024, 3:47 AM
tomek closed D11244: [keyserver] Transform client IDs when handling socket message.
Mar 6 2024, 2:40 AM
tomek committed rCOMMa0b423e3ccf6: [keyserver] Transform client IDs when handling socket message (authored by tomek).
[keyserver] Transform client IDs when handling socket message
Mar 6 2024, 2:40 AM

Mar 5 2024

tomek accepted D11238: [lib] Set CSAT on identity login / register.
Mar 5 2024, 6:36 AM
tomek accepted D11230: [lib][native] Introduce supportingMultipleKeyservers constant.
Mar 5 2024, 6:32 AM
tomek accepted D11228: [lib] Introduce relyingOnAuthoritativeKeyserver constant.
Mar 5 2024, 6:30 AM
tomek accepted D11227: [native] Use useKeyserverRecoveryLogIn from SQLiteDataHandler.
Mar 5 2024, 6:27 AM
tomek accepted D11226: [lib] Extract useKeyserverRecoveryLogIn.
Mar 5 2024, 6:08 AM
tomek accepted D11225: [lib] Make resolveKeyserverSessionInvalidation generic.
Mar 5 2024, 6:03 AM
tomek added inline comments to D11244: [keyserver] Transform client IDs when handling socket message.
Mar 5 2024, 5:58 AM
tomek requested review of D11244: [keyserver] Transform client IDs when handling socket message.
Mar 5 2024, 5:04 AM
tomek accepted D11224: [lib][native] Deprecate DispatchRecoveryAttempt in favor of DispatchActionPromise.
Mar 5 2024, 1:44 AM
tomek accepted D11223: [lib][native] Make cancellation work for keyserver session recovery.
Mar 5 2024, 12:57 AM
tomek accepted D11222: [lib] Don't cancel an auth that the keyserver completes.
Mar 5 2024, 12:52 AM
tomek added inline comments to D11166: [lib] introduce community reducer.
Mar 5 2024, 12:10 AM

Mar 4 2024

tomek accepted D11221: [lib] Factor out CANCELLED_ERROR into keyserver-conn-types.js.
Mar 4 2024, 7:19 AM
tomek accepted D11220: [lib][native] Initialize notif Olm channel during keyserver session recovery.
Mar 4 2024, 7:10 AM
tomek accepted D11218: [lib] Initiate a keyserver session recovery when keyserver socket sends not_logged_in.
Mar 4 2024, 6:42 AM
tomek accepted D11217: [lib][native] Try session recovery on web too for policy acknowledgment crash loop.
Mar 4 2024, 2:51 AM
tomek accepted D11216: [lib][native] Use unified keyserver session recovery in native/socket.react.js.
Mar 4 2024, 2:49 AM
tomek accepted D11215: [lib][native][web] Use unified keyserver session recovery in lib/socket/socket.react.js.
Mar 4 2024, 2:43 AM
tomek accepted D11214: [lib] Deprecate resetUserStateActionType.
Mar 4 2024, 2:38 AM
tomek accepted D11213: [native] Use unified keyserver session recovery in LoggedOutModal.
Mar 4 2024, 1:58 AM
tomek accepted D11212: [lib] Replace sessionRecoveryInProgress with actionSessionRecovery.

Just to make sure: sessionRecoveryInProgress isn't persisted, right?

Mar 4 2024, 1:47 AM
tomek accepted D11211: [lib] Deprecate recoveryActionSources.sqliteOpFailure.

I think that the practice of keeping commented-out types has a big advantage of reducing confusion when searching for older revisions while it doesn't have significant disadvantages.

Mar 4 2024, 1:29 AM
tomek accepted D11210: [lib][native] Separate out recoveryActionSources.
Mar 4 2024, 1:25 AM
tomek requested changes to D11209: [lib] Update `threadHasAdminRole` to consider `specialField`.

However, if there is no specialRole field encountered, we will assume we're dealing with a Server/"legacy" type and fallback to sketchy string search.

What is the scenario when this can happen?

Mar 4 2024, 1:07 AM
tomek accepted D11208: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is[Editable/Deletable]` directly in `RoleActionsMenu`.

We should reintroduce the util (probably as a simple function) if we would need to decide if we can edit / delete a role in some other places.

Mar 4 2024, 1:05 AM
tomek accepted D11206: [web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu`.
Mar 4 2024, 12:59 AM
tomek requested changes to D11205: [lib][native] Introduce `useRoleNamesToSpecialRole` to remove `"Admins"` string check in `RolePanelEntry`.

I don't understand the reason behind this diff and the task from the summary doesn't have any description. Why can't we simply check RoleInfo and its specialRole field?

Mar 4 2024, 12:57 AM
tomek accepted D11194: [identity] add allow origin list to config struct.
Mar 4 2024, 12:48 AM

Mar 1 2024

tomek closed D11203: [keyserver] Delete ALTER TABLE statement for deleted table.
Mar 1 2024, 8:02 AM
tomek committed rCOMMf6955bb91350: [keyserver] Delete ALTER TABLE statement for deleted table (authored by tomek).
[keyserver] Delete ALTER TABLE statement for deleted table
Mar 1 2024, 8:02 AM
tomek requested review of D11203: [keyserver] Delete ALTER TABLE statement for deleted table.
Mar 1 2024, 7:51 AM

Feb 29 2024

tomek closed D11199: [native] Fix typo in encrypted-image.
Feb 29 2024, 7:45 AM
tomek committed rCOMM014aefa51383: [native] Fix typo in encrypted-image (authored by tomek).
[native] Fix typo in encrypted-image
Feb 29 2024, 7:45 AM
tomek closed D11187: [lib] Render a socket for each keyserver.
Feb 29 2024, 7:42 AM
tomek committed rCOMMe9578fd52cbe: [lib] Render a socket for each keyserver (authored by tomek).
[lib] Render a socket for each keyserver
Feb 29 2024, 7:42 AM
tomek closed D11186: [lib] Move report handler from a socket.
Feb 29 2024, 7:42 AM
tomek closed D11185: [lib] Check keyserver connection in request-response-handler.
Feb 29 2024, 7:42 AM
tomek closed D11184: [lib] Compute hashes only from one keyserver.
Feb 29 2024, 7:42 AM
tomek committed rCOMM1f2a63c77728: [lib] Move report handler from a socket (authored by tomek).
[lib] Move report handler from a socket
Feb 29 2024, 7:42 AM
tomek committed rCOMM8cea21c8a21e: [lib] Check keyserver connection in request-response-handler (authored by tomek).
[lib] Check keyserver connection in request-response-handler
Feb 29 2024, 7:42 AM
tomek committed rCOMMacec0aca765a: [lib] Compute hashes only from one keyserver (authored by tomek).
[lib] Compute hashes only from one keyserver
Feb 29 2024, 7:42 AM
tomek closed D11183: [lib] Compare only entities from one keyserver when checking the inconsistencies.
Feb 29 2024, 7:42 AM
tomek closed D11182: [lib] Add keyserverID to processServerRequestsActionType.
Feb 29 2024, 7:42 AM
tomek committed rCOMMb47820b1a752: [lib] Compare only entities from one keyserver when checking the inconsistencies (authored by tomek).
[lib] Compare only entities from one keyserver when checking the inconsistencies
Feb 29 2024, 7:42 AM
tomek committed rCOMM80c75e317126: [lib] Add keyserverID to processServerRequestsActionType (authored by tomek).
[lib] Add keyserverID to processServerRequestsActionType
Feb 29 2024, 7:42 AM
tomek closed D11181: [lib] Use keyserverID when generating initial message using socket.
Feb 29 2024, 7:42 AM
tomek committed rCOMM6123d12b7b83: [lib] Use keyserverID when generating initial message using socket (authored by tomek).
[lib] Use keyserverID when generating initial message using socket
Feb 29 2024, 7:42 AM
tomek updated the test plan for D11186: [lib] Move report handler from a socket.
Feb 29 2024, 7:38 AM
tomek updated the diff for D11199: [native] Fix typo in encrypted-image.

Fix typo

Feb 29 2024, 7:27 AM
tomek updated the diff for D11184: [lib] Compute hashes only from one keyserver.

Fix prop name

Feb 29 2024, 7:11 AM
tomek added inline comments to D11183: [lib] Compare only entities from one keyserver when checking the inconsistencies.
Feb 29 2024, 7:08 AM
tomek updated the diff for D11183: [lib] Compare only entities from one keyserver when checking the inconsistencies.

Use thread type const.
Update entries test by adding explicit calendar query from the past - the test failed as expected. Updated the dates in entries, which fixed the tests.

Feb 29 2024, 7:08 AM
tomek requested review of D11199: [native] Fix typo in encrypted-image.
Feb 29 2024, 7:04 AM
tomek closed D11197: [native] Use connectivity status for images upload.
Feb 29 2024, 6:59 AM
tomek closed D11196: [native][web] Check connectivity if a keyserver associated with an entry.
Feb 29 2024, 6:59 AM
tomek committed rCOMMe737ed0537e8: [native][web] Check connectivity if a keyserver associated with an entry (authored by tomek).
[native][web] Check connectivity if a keyserver associated with an entry
Feb 29 2024, 6:59 AM
tomek committed rCOMM7aacf18bd2cd: [native] Use connectivity status for images upload (authored by tomek).
[native] Use connectivity status for images upload
Feb 29 2024, 6:59 AM
tomek closed D11195: [native] Use connectivity instead of keyserver connection status in Calendar.
Feb 29 2024, 6:59 AM
tomek committed rCOMM4375848efb55: [native] Use connectivity instead of keyserver connection status in Calendar (authored by tomek).
[native] Use connectivity instead of keyserver connection status in Calendar
Feb 29 2024, 6:59 AM
tomek requested review of D11197: [native] Use connectivity status for images upload.
Feb 29 2024, 5:17 AM
tomek requested review of D11196: [native][web] Check connectivity if a keyserver associated with an entry.
Feb 29 2024, 4:34 AM
tomek requested review of D11195: [native] Use connectivity instead of keyserver connection status in Calendar.
Feb 29 2024, 3:06 AM
tomek accepted D11188: [web] Redux migration to patch in `specialRole` field.
Feb 29 2024, 12:57 AM
tomek requested changes to D11194: [identity] add allow origin list to config struct.
Feb 29 2024, 12:49 AM
tomek accepted D11166: [lib] introduce community reducer.
Feb 29 2024, 12:35 AM

Feb 27 2024

tomek requested review of D11186: [lib] Move report handler from a socket.
Feb 27 2024, 9:08 AM
tomek added a comment to D11166: [lib] introduce community reducer.
In D11166#323019, @atul wrote:

Mostly looks good, but do we need to handle clearing the data on log out/delete account/etc?

Feb 27 2024, 8:18 AM
tomek requested review of D11187: [lib] Render a socket for each keyserver.
Feb 27 2024, 8:11 AM
tomek requested review of D11185: [lib] Check keyserver connection in request-response-handler.
Feb 27 2024, 6:42 AM
tomek requested review of D11184: [lib] Compute hashes only from one keyserver.
Feb 27 2024, 6:27 AM
tomek requested review of D11183: [lib] Compare only entities from one keyserver when checking the inconsistencies.
Feb 27 2024, 5:38 AM
tomek requested review of D11182: [lib] Add keyserverID to processServerRequestsActionType.
Feb 27 2024, 2:27 AM
tomek requested review of D11181: [lib] Use keyserverID when generating initial message using socket.
Feb 27 2024, 1:53 AM
tomek closed D11177: [lib][keyserver] Delete MORE_ONE_TIME_KEYS mechanism.
Feb 27 2024, 1:41 AM
tomek closed D11176: [lib] Add keyserverID param to getClientResponsesSelector.
Feb 27 2024, 1:41 AM
tomek committed rCOMM1d74ee4f6ed5: [lib][keyserver] Delete MORE_ONE_TIME_KEYS mechanism (authored by tomek).
[lib][keyserver] Delete MORE_ONE_TIME_KEYS mechanism
Feb 27 2024, 1:41 AM
tomek committed rCOMMc34612666172: [lib] Add keyserverID param to getClientResponsesSelector (authored by tomek).
[lib] Add keyserverID param to getClientResponsesSelector
Feb 27 2024, 1:41 AM
tomek closed D11144: [lib] Move actualizedCalendarQuery into keyserver store.
Feb 27 2024, 1:41 AM
tomek committed rCOMM62ffb3166fda: [lib] Move actualizedCalendarQuery into keyserver store (authored by tomek).
[lib] Move actualizedCalendarQuery into keyserver store
Feb 27 2024, 1:41 AM
tomek updated the diff for D11144: [lib] Move actualizedCalendarQuery into keyserver store.

Rebase

Feb 27 2024, 1:19 AM
tomek accepted D11149: [lib] Update `roleIsDefaultRole` to consider `roleInfo?.specialRole`.
Feb 27 2024, 12:45 AM
tomek accepted D11148: [lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole`.
Feb 27 2024, 12:44 AM
tomek accepted D11099: [native] Redux migration to patch in `specialRole` field.
Feb 27 2024, 12:43 AM
tomek added a comment to D11177: [lib][keyserver] Delete MORE_ONE_TIME_KEYS mechanism.
In D11177#323033, @atul wrote:

Looks good, just want to make sure that this won't break any older clients? I see the following in Test Plan:

Run an older native client and check if it works with new keyserver.

so I'm assuming this table and functionality was never used?

Feb 27 2024, 12:33 AM

Feb 26 2024

tomek requested review of D11177: [lib][keyserver] Delete MORE_ONE_TIME_KEYS mechanism.
Feb 26 2024, 8:58 AM
tomek requested review of D11176: [lib] Add keyserverID param to getClientResponsesSelector.
Feb 26 2024, 8:21 AM
tomek updated the diff for D11144: [lib] Move actualizedCalendarQuery into keyserver store.

Tested native migration and deleted web migration - we aren't persisting actualizedCalendarQuery on web
and we don't need to migrate it - default state contains a new value.

Feb 26 2024, 5:51 AM
tomek accepted D11155: [web] use default keyserverStore state if there are no entries in SQLite.
Feb 26 2024, 5:01 AM
tomek accepted D11154: [crypto] implement prekey rotation in `OlmAPI`.
Feb 26 2024, 4:59 AM

Feb 23 2024

tomek accepted D11157: [native] Fix hermes throwing on nonexistant files.
Feb 23 2024, 7:17 AM
tomek updated the diff for D11144: [lib] Move actualizedCalendarQuery into keyserver store.

Fix top-level default keyserver info - the app was crashing because config isn't registered when executing
top-level

Feb 23 2024, 6:10 AM
tomek planned changes to D11144: [lib] Move actualizedCalendarQuery into keyserver store.
Feb 23 2024, 5:51 AM
tomek added inline comments to D11144: [lib] Move actualizedCalendarQuery into keyserver store.
Feb 23 2024, 5:49 AM
tomek updated the diff for D11144: [lib] Move actualizedCalendarQuery into keyserver store.

Update native state type
Use defaultCalendarQuery function in the default keyserver store
Handle actualizedCalendarQuery from an initial state in the reducer

Feb 23 2024, 5:49 AM
tomek accepted D11110: [web] implementing publishing prekeys to Identity.
Feb 23 2024, 4:01 AM
tomek accepted D11146: [lib] Update getDefaultAvatar and threadMembersWithoutAddedAshoat.
Feb 23 2024, 3:50 AM
tomek added inline comments to D11140: [lib] reduce currentUserInfo on identity login/register.
Feb 23 2024, 3:17 AM