This diff should have a meaningful test plan
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Jan 26 2024
Jan 26 2024
tomek requested review of D10830: [lib] Create a selector that checks if a user is logged in to a keyserver.
Jan 25 2024
Jan 25 2024
tomek requested changes to D10812: Rename `useDisconnectedBarVisibilityHandler` to `useKeyserverReachabilityHandler`.
Jan 22 2024
Jan 22 2024
tomek requested changes to D10750: [native] implementing getting outbound user keys in `IdentityServiceClient`.
Rebase onto D10752
Jan 19 2024
Jan 19 2024
Simplify the code
tomek updated the diff for D10666: [lib][native][web] Parse keyserver keys payload and validate the result.
Improve validation
Rebase
Rebase
tomek updated the diff for D10663: [native][web] Add a context provider on native that exposes notifications session creator.
Rename
tomek updated the diff for D10662: [web] Introduce deviceID parameter to initial notif message function.
Rename
tomek updated the diff for D10660: [lib][native] Introduce deviceID parameter to initial notif message function.
Rebase
tomek updated the diff for D10660: [lib][native] Introduce deviceID parameter to initial notif message function.
Rename
In D10667#309741, @marcin wrote:I am confused by this differential. I have two questions:
- What is the purpose of deleting and recreating notifications sessions at least every time app starts (session creation is not idempotent - it overwrites previous session)? Session is created on login and via socket if the keyserver happens to be missing session.
- In its current state this differential doesn't guarantee that session on the client is in sync with session on the keyserver - initialEncryptedMessage returned from session creator is not used. If this differential is intentionally breaking the app and you plan to fix it later in the stack then it should be explicitly stated in summary or in a comment.
tomek added inline comments to D10666: [lib][native][web] Parse keyserver keys payload and validate the result.
tomek added a comment to D10662: [web] Introduce deviceID parameter to initial notif message function.
In D10662#309232, @kamil wrote:Using deviceID everywhere makes me sometimes confused which ID it is, so in places like this I would prefer recipientDeviceID or targetDeviceID but curious about what other reviewers think.
I did the same here D10381 so going to update next time touching this code.
tomek added inline comments to D10660: [lib][native] Introduce deviceID parameter to initial notif message function.
Jan 18 2024
Jan 18 2024
tomek added inline comments to D10663: [native][web] Add a context provider on native that exposes notifications session creator.
tomek updated the diff for D10663: [native][web] Add a context provider on native that exposes notifications session creator.
Reverse providers order
Simplify
Jan 17 2024
Jan 17 2024
tomek retitled D10663: [native][web] Add a context provider on native that exposes notifications session creator from [native][web] Add a context provider on web that exposes notifications session creator
tomek published D10666: [lib][native][web] Parse keyserver keys payload and validate the result for review.
tomek published D10662: [web] Introduce deviceID parameter to initial notif message function for review.
tomek published D10660: [lib][native] Introduce deviceID parameter to initial notif message function for review.
tomek added inline comments to D10631: [native] implement prekey rotation handler and call Identity.
Jan 15 2024
Jan 15 2024
Jan 12 2024
Jan 12 2024
tomek added inline comments to D10616: [lib][native][web] add new changeIdentityUserPassword action.
Jan 11 2024
Jan 11 2024
Avoid console logging the keys