Reverse the handleScroll if condition to early return and format code
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Feb 24 2023
Feb 24 2023
bartek added inline comments to D6856: [services][feature-flags] Parse feature flags response from DynamoDB.
atul updated the summary of D6877: [web] Introduce `cryptoStore` to replace `primaryIdentityPublicKey` in Redux.
Feb 23 2023
Feb 23 2023
ginsu requested review of D6875: [lib/native/web] switch reactions data structure from map to plain object.
rohan added inline comments to D6865: [web] Allow media gallery items to click through to a full screen view on web.
atul published D6877: [web] Introduce `cryptoStore` to replace `primaryIdentityPublicKey` in Redux for review.
atul published D6876: [web] Rename `setPrimaryIdentityPublicKey` to `setPrimaryIdentityKeys` for review.
ashoat requested review of D6874: [lib] Make CreateSidebar notifs say when the OP tags the notif recipient.
Update formatting
update RPC description in .proto file
switched to HashSet and fixed code logic, changed API to return <users in keyserver but not in identity> AND <users in identity but not in keyserver>
In D6824#203292, @jon wrote:We also need to do the other half of this on the client side
example intercepter https://github.com/hyperium/tonic/blob/4e578b5046804eb7abb2da80680366769b2a08fd/examples/src/interceptor/client.rs#L57
address feedback
moving back to reviewers' queue since @ashoat provided additional context
ashoat added inline comments to D6865: [web] Allow media gallery items to click through to a full screen view on web.
Just some nits
ashoat requested changes to D6829: [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise.
You need to do more than just add async. I don't think you have a full understanding of async/await here
I tested the types and they're good. Did not test the actual bindings but I assume @max did
ashoat added inline comments to D6822: Sign concatenation of public and notif keypairs using private key of public identity.
Remove canViewThreadMediaGallery
address ashoats comments
ginsu updated the diff for D6829: [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise.
address ashoat's comments
ashoat updated the diff for D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.
Fix Flow types and remove .default
ashoat added inline comments to D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.
tomek requested review of D6856: [services][feature-flags] Parse feature flags response from DynamoDB.
Adding @jon to take a look.
• max edited reviewers for D6690: [keyserver] Unifying API interface and adding Tunnelbroker types, added: • jon; removed: ginsu.
• max updated subscribers of D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.
Okay, just make sure you did this part of the Test Plan so that all constants are included:
Rebasing on master changes.
Add constants to object types.
marcin added inline comments to D6822: Sign concatenation of public and notif keypairs using private key of public identity.
tomek requested review of D6853: [services][feature-flags] Describe feature flags table in terraform.
rohan added inline comments to D6718: [native] Navigate to the image / video modal when a user clicks on a media item.
rohan updated the diff for D6718: [native] Navigate to the image / video modal when a user clicks on a media item.
Syntax and change navigation key to use mediaInfo.id