@michal can you please tell me if this is all I need to do regarding your validation changes, and if this is a correct type?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
May 22 2023
Add to initialReduxStateValidator communityPickerStore
rebase and land
modalSeparator -> panelSeparator
Make sure Flow etc pass before landing please
Remove eslint-disable-next-line
I'm guessing this is the copy from DES-79, in which case I wrote it. RE line lengths, I guess it's fine
Accepting since comments are all addressed, but it looks like we'll have to revise this after we adjust all encryption to occur on a single blob, instead of being field-by-field. Might be a good idea to re-request review after that
(Accepting since comments are all addressed, but it looks like we'll have to revise this after we adjust all encryption to occur on a single blob, instead of being field-by-field. Might be a good idea to re-request review after that)
I think the differential name is not complete and confusing a bit
Passing to your queue
Confused why we're ignoring thumbnailURI for encrypted videos
Can you share a screenshot of how this looks like?
the issue with this solution is that when we resize back to a smaller window width again, then the MobileNav would be immediately displayed again
Can we set a minimum width on the button so it can fit Request Access/Requested!/Invalid Email/etc?
Let's definitely fix the typos and try to color icon via CSS.
Agreed with @ashoat that Android notification payload should be encrypted in one pass. Regarding iOS we have to first test whether we can just omit certain fields.
Assuming @ashoat has signed off on copy + we're fine with having lines extend past 80 characters since this is a "data" file vs. "code" file?
Love a red diff!
apos to rquote
Passing back to your queue, in part for feedback above, but mostly for the changes I requested in D7771
You mentioned in D7774 that I should not call something else from an effect.
I don't really understand how I could change this effect to a callback. If I do it like in ex useEditMessage, and return a return React.useCallback, it will still have to be called inside of an effect in the calling code, because I need to fetch messages whenever query or threadID or cursor change.
- One pass instead of three
- Enforce that all encrypted copies of the same notification share id so that rescinding is transparent to e2e encryption
Remove unecessary if (it was a dead code)
Create new notification instead of copying
Use tcomb to validate request
- Use FUTURE_CODE_VERSION
- Match SQL conventions
create z-index css variables
Rebase