Page MenuHomePhabricator
Feed All Stories

May 22 2023

inka added a comment to D6968: [web] Add to redux state picked community in the Chat tab.

@michal can you please tell me if this is all I need to do regarding your validation changes, and if this is a correct type?

May 22 2023, 12:24 PM
inka updated the diff for D6968: [web] Add to redux state picked community in the Chat tab.

Add to initialReduxStateValidator communityPickerStore

May 22 2023, 12:22 PM
atul closed D7924: [native] Introduce `communityCreationButton` to `CommunityDrawerContent`.
May 22 2023, 12:02 PM
atul committed rCOMM6824f1bb4688: [native] Introduce `communityCreationButton` to `CommunityDrawerContent` (authored by atul).
[native] Introduce `communityCreationButton` to `CommunityDrawerContent`
May 22 2023, 12:02 PM
atul updated the diff for D7924: [native] Introduce `communityCreationButton` to `CommunityDrawerContent`.

rebase and land

May 22 2023, 11:47 AM
atul updated the diff for D7924: [native] Introduce `communityCreationButton` to `CommunityDrawerContent`.

modalSeparator -> panelSeparator

May 22 2023, 11:38 AM
atul added inline comments to D7924: [native] Introduce `communityCreationButton` to `CommunityDrawerContent`.
May 22 2023, 11:36 AM
ashoat accepted D7924: [native] Introduce `communityCreationButton` to `CommunityDrawerContent`.

Make sure Flow etc pass before landing please

May 22 2023, 11:26 AM
ashoat added inline comments to D6976: [web] Use new handlers in communnity drawer.
May 22 2023, 11:25 AM
atul published D7924: [native] Introduce `communityCreationButton` to `CommunityDrawerContent` for review.
May 22 2023, 11:24 AM
inka updated the diff for D6976: [web] Use new handlers in communnity drawer.

Remove eslint-disable-next-line

May 22 2023, 11:20 AM
inka added inline comments to D6976: [web] Use new handlers in communnity drawer.
May 22 2023, 11:20 AM
ashoat added inline comments to D7906: [keyserver] Create an endpoint that allows disabling links.
May 22 2023, 11:10 AM
ashoat added inline comments to D7859: Add method to check for missing olm sessions for notifs and use it to send relevant request.
May 22 2023, 11:03 AM
ashoat added a comment to D7904: [landing] introduce signal competitor data.

I'm guessing this is the copy from DES-79, in which case I wrote it. RE line lengths, I guess it's fine

May 22 2023, 10:57 AM
ashoat added a comment to D7908: [native] Introduce disable link button.

Looks like

disable-button-bright.png (2×1 px, 168 KB)
failed to attach

May 22 2023, 10:55 AM
ashoat closed D7896: [native] Introduce UsernameSelection screen.
May 22 2023, 10:51 AM
ashoat committed rCOMM3cae1466e7bb: [native] Introduce UsernameSelection screen (authored by ashoat).
[native] Introduce UsernameSelection screen
May 22 2023, 10:51 AM
ashoat closed D7895: [native] Factor RegistrationTextInput out of KeyserverSelection.
May 22 2023, 10:51 AM
ashoat committed rCOMM56ce01812c3e: [native] Factor RegistrationTextInput out of KeyserverSelection (authored by ashoat).
[native] Factor RegistrationTextInput out of KeyserverSelection
May 22 2023, 10:51 AM
ashoat accepted D7815: Send encrypted notifications to iOS devices.

Accepting since comments are all addressed, but it looks like we'll have to revise this after we adjust all encryption to occur on a single blob, instead of being field-by-field. Might be a good idea to re-request review after that

May 22 2023, 10:50 AM
ashoat added a comment to D7814: Implement method in NSE to decrypt notification.

(Accepting since comments are all addressed, but it looks like we'll have to revise this after we adjust all encryption to occur on a single blob, instead of being field-by-field. Might be a good idea to re-request review after that)

May 22 2023, 10:47 AM
ashoat accepted D7814: Implement method in NSE to decrypt notification.
May 22 2023, 10:47 AM
kamil accepted D7907: [lib] Allow calling link-disabling endpoint.

I think the differential name is not complete and confusing a bit

May 22 2023, 10:44 AM
ashoat added inline comments to D7813: Implement function to encrypt relevant parts of iOS notification.
May 22 2023, 10:41 AM
ashoat added inline comments to D6976: [web] Use new handlers in communnity drawer.
May 22 2023, 10:37 AM
ashoat requested changes to D7872: Implement function to encrypt android notification.

Passing to your queue

May 22 2023, 10:28 AM
kamil requested changes to D7906: [keyserver] Create an endpoint that allows disabling links.
May 22 2023, 10:24 AM
ashoat requested changes to D7900: [web] Add thumbhash to encrypted media, fix spinner.

Confused why we're ignoring thumbnailURI for encrypted videos

May 22 2023, 10:19 AM
ashoat requested changes to D7902: [web] Display thumbhash in chat.
May 22 2023, 10:12 AM
kamil accepted D7885: [native] Add a link to manage public link screen.

Can you share a screenshot of how this looks like?

May 22 2023, 9:52 AM
atul accepted D7860: Handle client response to initial notifications encrypted message request.
May 22 2023, 9:50 AM
ashoat added inline comments to D7899: [web] Refactor Mutlimedia to function component.
May 22 2023, 9:50 AM
atul accepted D7859: Add method to check for missing olm sessions for notifs and use it to send relevant request.
May 22 2023, 9:47 AM
atul accepted D7858: Add initial notifications encrypted message generator to client responses selector on native.
May 22 2023, 9:46 AM
atul accepted D7856: Add request and response types for the keyserver to request first encrypted message for e2e notifs.
May 22 2023, 9:46 AM
atul accepted D7896: [native] Introduce UsernameSelection screen.
May 22 2023, 9:42 AM
ashoat accepted D7901: [web] Add hook to generate placeholder image.
May 22 2023, 9:42 AM
kamil accepted D7884: [native] Introduce simple error handling.
May 22 2023, 9:42 AM
atul accepted D7895: [native] Factor RegistrationTextInput out of KeyserverSelection.
May 22 2023, 9:41 AM
atul accepted D7871: [landing] fix mobile nav bar peeking into screen when quickly resizing window.
May 22 2023, 9:38 AM
kamil accepted D7883: [native] Call create / update endpoint.
May 22 2023, 9:25 AM
atul retitled D7871: [landing] fix mobile nav bar peeking into screen when quickly resizing window from [landing] fix mobile nav bar peaking into screen when quickly resizing window to [landing] fix mobile nav bar peeking into screen when quickly resizing window.
May 22 2023, 9:19 AM
atul accepted D7870: [landing] fix mobile nav still being shown when window resizes.

the issue with this solution is that when we resize back to a smaller window width again, then the MobileNav would be immediately displayed again

May 22 2023, 9:19 AM
atul accepted D7917: [landing] fix css class names for subscription form component.
May 22 2023, 9:14 AM
atul requested changes to D7915: [landing] redesign the subscription form component.

Can we set a minimum width on the button so it can fit Request Access/Requested!/Invalid Email/etc?

May 22 2023, 9:13 AM
atul accepted D7911: [landing] change text content on HeroContent component.
May 22 2023, 9:10 AM
atul attached a referenced file: F551581: 4b8c68.png.
May 22 2023, 9:03 AM
atul attached a referenced file: F551584: 2ef8ce.png.
May 22 2023, 9:03 AM
atul requested changes to D7905: [landing] introduce competitor feature card component.

Let's definitely fix the typos and try to color icon via CSS.

May 22 2023, 9:03 AM
marcin planned changes to D7873: Implement notification decryption in CommNotificationsHandler.

Agreed with @ashoat that Android notification payload should be encrypted in one pass. Regarding iOS we have to first test whether we can just omit certain fields.

May 22 2023, 8:55 AM
kamil accepted D7881: [native] Show actions conditionally.
May 22 2023, 8:32 AM
atul accepted D7904: [landing] introduce signal competitor data.

Assuming @ashoat has signed off on copy + we're fine with having lines extend past 80 characters since this is a "data" file vs. "code" file?

May 22 2023, 8:29 AM
tomek added inline comments to D7908: [native] Introduce disable link button.
May 22 2023, 8:21 AM
atul accepted D7898: [landing] minor improvements to mobile nav ui.
May 22 2023, 8:21 AM
ashoat accepted D7899: [web] Refactor Mutlimedia to function component.
May 22 2023, 8:13 AM
kamil accepted D7880: [native] Implement the UI of manage invite links screen.
May 22 2023, 8:13 AM
ashoat closed D7897: Update &apos to &rsquo.
May 22 2023, 8:03 AM
ashoat committed rCOMM07a58f582044: Update &apos to &rsquo (authored by ashoat).
Update &apos to &rsquo
May 22 2023, 8:03 AM
ashoat accepted D7914: [landing] remove react-text-loop dependency.

Love a red diff!

May 22 2023, 8:02 AM
kamil accepted D7733: [native] Display a button and navigate to invite links if they are present.
May 22 2023, 7:54 AM
atul closed D7893: [web] Replace `'` with `'` in `announcementStatements`.
May 22 2023, 7:42 AM
atul committed rCOMM40d1dbb3c8b9: [web] Replace `'` with `'` in `announcementStatements` (authored by atul).
[web] Replace `'` with `'` in `announcementStatements`
May 22 2023, 7:42 AM
ginsu requested review of D7917: [landing] fix css class names for subscription form component.
May 22 2023, 7:38 AM
atul updated the diff for D7893: [web] Replace `'` with `'` in `announcementStatements`.

apos to rquote

May 22 2023, 7:29 AM
ginsu requested review of D7915: [landing] redesign the subscription form component.
May 22 2023, 7:25 AM
ashoat requested changes to D7774: [native] Add MessageSearchContent.

Passing back to your queue, in part for feedback above, but mostly for the changes I requested in D7771

May 22 2023, 7:22 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D7855: [web] Send platform details on websocket connection.
May 22 2023, 7:11 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM62a1b350b2ca: [web] Send platform details on websocket connection (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web] Send platform details on websocket connection
May 22 2023, 7:11 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D7854: [keyserver] Handle web version in hasMinCodeVersion.
May 22 2023, 7:11 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM154c9b9d5f4f: [keyserver] Handle web version in hasMinCodeVersion (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[keyserver] Handle web version in hasMinCodeVersion
May 22 2023, 7:11 AM
ginsu requested review of D7914: [landing] remove react-text-loop dependency.
May 22 2023, 7:08 AM
ted added inline comments to D7908: [native] Introduce disable link button.
May 22 2023, 7:05 AM
kosmydel <kukubaczek@gmail.com> closed D7792: [native] Don’t display edit mode when user changes thread.
May 22 2023, 7:05 AM
kosmydel <kukubaczek@gmail.com> committed rCOMM39c9b031b3ed: [native] Don’t display edit mode when user changes thread (authored by kosmydel <kukubaczek@gmail.com>).
[native] Don’t display edit mode when user changes thread
May 22 2023, 7:05 AM
kosmydel <kukubaczek@gmail.com> closed D7790: [native] Added animation to the edit box when entering/leaving edit mode.
May 22 2023, 7:05 AM
kosmydel <kukubaczek@gmail.com> closed D7791: [native] Added animation to the highlight of edited message.
May 22 2023, 7:05 AM
kosmydel <kukubaczek@gmail.com> committed rCOMMee38c51336f4: [native] Added animation to the edit box when entering/leaving edit mode (authored by kosmydel <kukubaczek@gmail.com>).
[native] Added animation to the edit box when entering/leaving edit mode
May 22 2023, 7:05 AM
kosmydel <kukubaczek@gmail.com> committed rCOMM204fc8185ca8: [native] Added animation to the highlight of edited message (authored by kosmydel <kukubaczek@gmail.com>).
[native] Added animation to the highlight of edited message
May 22 2023, 7:05 AM
kosmydel <kukubaczek@gmail.com> closed D7789: [native] Introduced new types for Reanimated.
May 22 2023, 7:05 AM
kosmydel <kukubaczek@gmail.com> committed rCOMMa0f07e7c7b4f: [native] Introduced new types for Reanimated (authored by kosmydel <kukubaczek@gmail.com>).
[native] Introduced new types for Reanimated
May 22 2023, 7:05 AM
ashoat added inline comments to D7774: [native] Add MessageSearchContent.
May 22 2023, 7:01 AM
ashoat added a comment to D7771: [lib] Add useSearchMessages.

You mentioned in D7774 that I should not call something else from an effect.
I don't really understand how I could change this effect to a callback. If I do it like in ex useEditMessage, and return a return React.useCallback, it will still have to be called inside of an effect in the calling code, because I need to fetch messages whenever query or threadID or cursor change.

May 22 2023, 7:00 AM
marcin updated the diff for D7815: Send encrypted notifications to iOS devices.
  1. One pass instead of three
  2. Enforce that all encrypted copies of the same notification share id so that rescinding is transparent to e2e encryption
May 22 2023, 6:59 AM
marcin updated the diff for D7814: Implement method in NSE to decrypt notification.

Remove unecessary if (it was a dead code)

May 22 2023, 6:58 AM
marcin updated the diff for D7813: Implement function to encrypt relevant parts of iOS notification.

Create new notification instead of copying

May 22 2023, 6:57 AM
ginsu requested review of D7911: [landing] change text content on HeroContent component.
May 22 2023, 6:57 AM
marcin updated the diff for D7860: Handle client response to initial notifications encrypted message request.

Use tcomb to validate request

May 22 2023, 6:57 AM
ginsu updated the summary of D7898: [landing] minor improvements to mobile nav ui.
May 22 2023, 6:56 AM
marcin updated the diff for D7859: Add method to check for missing olm sessions for notifs and use it to send relevant request.
  1. Use FUTURE_CODE_VERSION
  2. Match SQL conventions
May 22 2023, 6:55 AM
tomek accepted D7873: Implement notification decryption in CommNotificationsHandler.
May 22 2023, 6:52 AM
tomek requested review of D7908: [native] Introduce disable link button.
May 22 2023, 6:50 AM
tomek requested review of D7907: [lib] Allow calling link-disabling endpoint.
May 22 2023, 6:47 AM
tomek requested review of D7906: [keyserver] Create an endpoint that allows disabling links.
May 22 2023, 6:42 AM
ginsu requested review of D7905: [landing] introduce competitor feature card component.
May 22 2023, 6:37 AM
ginsu updated the diff for D7868: [landing] implement on click functions in header.

create z-index css variables

May 22 2023, 6:17 AM
michal accepted D7849: [web] Prevent user from closing the tab with unsaved edits.
May 22 2023, 6:16 AM
ginsu requested review of D7904: [landing] introduce signal competitor data.
May 22 2023, 6:12 AM
ginsu added inline comments to D7868: [landing] implement on click functions in header.
May 22 2023, 6:06 AM
inka updated the diff for D6979: [web] Add a selector for getting the number of unnreads in the selected community.

Rebase

May 22 2023, 6:03 AM