In D7838#235423, @inka wrote:

Why do we want to do that?

In D7925#235234, @atul wrote:

Should we style the input w/ a red outline when there's invalid input + some sort of error state? (cc @ted)

I would expect something more like the right:

Either way, implementation matches the designs

Avoid putting JSX into React state

Use useNavigateToThread

Address review

Address review comments, use LoadableVideo, move props refactor from D7899

address review

Use React imports, remove comment

Rebase

Reverted the prop refactors. Memoized component

Blob decryption in one pass

Blob encrypt in one pass

Use readonly type

Moved FocusTrap to the ModalOverlay

Moved default background color

Can you remove the color from modal-overlay.css and set the default in ModalOverlay? I feel this will be more readable.

Why do we want to do that?

Use brighter color

Make reducer more efficient

Looks good

In D7907#234718, @kamil wrote:

I think the differential name is not complete and confusing a bit

Specify return type and use mixed as input type

Memoized backgroundColor

In D7885#234677, @kamil wrote:

Can you share a screenshot of how this looks like?

Minor fixes

Looks like @ted suggested using two different opacities for modals here. My first instinct would be to just have a single opacity, but he's on vacation so we can just proceed with this approach for now

In D7837#235331, @ashoat wrote:

In a previous comment, I said:

In D7837#233153, @ashoat wrote:

... then wrapping web/modals/modal.react.js in a <FocusTrap> component would make all of our modals "trap focus". This is probably a good thing to do for all modals, and I think it would solve the problem here.

@kuba, what do you think?

However, in this diff you've only added FocusTrap to your specific modal. Can you provide some detail as to why you took a different approach, and whether you considered the approach I suggested?

Thanks for solving this the "right" way with a red diff that simplifies things!

In a previous comment, I said:

Fix - couldn't close edit modal

Fix updating height after text changes

Rebase

Review

Minor fixes

Update color name

Looks good, but would love to see an opinion from someone more experienced in @react-navigation (cc. @inka)

Delete unnecessary migration

Should we style the input w/ a red outline when there's invalid input + some sort of error state? (cc @ted)