Page MenuHomePhorge
Feed All Stories

Sep 12 2023

marcin attached a referenced file: F754694: Current_coalescing.mov.
Sep 12 2023, 12:41 PM
marcin attached a referenced file: F754700: NSE_coalescing.mov.
Sep 12 2023, 12:41 PM
marcin added a comment to D9144: Enable encrypted notification coalescing in NSE on iOS.

As mentioned in the description coalescing mechanism changes slightly and so does user experience. I recommend that reviewers watch recordings attached below:
Current coalescing:

NSE coalescing:

Sep 12 2023, 12:41 PM
michal requested review of D9147: [lib/web/native] Improve conversion utils.
Sep 12 2023, 12:38 PM
inka accepted D9101: [native] introduce user profile bottomsheet component.
Sep 12 2023, 12:36 PM
michal requested review of D9146: [keyserver] Remove unused params in validation functions.
Sep 12 2023, 12:29 PM
michal requested review of D9145: [web] Remove intial redux state from website responders.
Sep 12 2023, 12:25 PM
marcin updated the summary of D9144: Enable encrypted notification coalescing in NSE on iOS.
Sep 12 2023, 12:18 PM
marcin requested review of D9144: Enable encrypted notification coalescing in NSE on iOS.
Sep 12 2023, 12:15 PM
inka requested review of D9143: [lib] Add memoization to useKeyserverCall.
Sep 12 2023, 11:58 AM
kamil closed D9142: [Tunnelbroker] Fix integration tests.
Sep 12 2023, 11:44 AM
kamil committed rCOMM08a58fec2081: [Tunnelbroker] Fix integration tests.
Sep 12 2023, 11:44 AM
bartek accepted D9142: [Tunnelbroker] Fix integration tests.
Sep 12 2023, 11:19 AM
kamil published D9142: [Tunnelbroker] Fix integration tests for review.
Sep 12 2023, 11:17 AM
kamil added inline comments to D8752: [Keyserver] Upload new onetime keys to identity service when requested.
Sep 12 2023, 11:08 AM
kamil updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

CI

Sep 12 2023, 11:06 AM
michal requested review of D9141: [web] Use new intial redux state.
Sep 12 2023, 10:50 AM
michal requested review of D9140: [web] Add setInitialReduxState action.
Sep 12 2023, 10:39 AM
Harbormaster failed remote builds in B22519: Diff 30956 for D8750: [Keyserver/rust] Implement upload_one_time_keys to identity service!
Sep 12 2023, 10:32 AM
Harbormaster failed remote builds in B22517: Diff 30954 for D7691: [Keyserver] Open websocket connection with tunnelbroker!
Sep 12 2023, 10:21 AM
kamil updated the diff for D8750: [Keyserver/rust] Implement upload_one_time_keys to identity service.

rebase

Sep 12 2023, 10:17 AM
kamil added inline comments to D7691: [Keyserver] Open websocket connection with tunnelbroker.
Sep 12 2023, 10:16 AM
kamil updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.
  • curve25519 -> ed25519
  • deviceID -> userID
  • remove auto-establishing session
Sep 12 2023, 10:05 AM
kamil added a comment to D8993: [client-backup] implement API call to upload backup.

At some point we'll probably want to think about how uploads might work in the background. If the backup is large, I could imagine that the client would need background upload in order to complete the upload. Is there a task to track this?

Sep 12 2023, 9:28 AM
tomek added inline comments to D8875: [web] Make chat mentions clickable.
Sep 12 2023, 9:20 AM
tomek requested changes to D8852: [web] Introduce markdown component for chat mentions.
Sep 12 2023, 9:18 AM
marcin accepted D9129: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object.
Sep 12 2023, 9:17 AM
marcin accepted D8956: [Keyserver] Validate incoming tunnelbroker messages.
Sep 12 2023, 9:17 AM
marcin added inline comments to D8956: [Keyserver] Validate incoming tunnelbroker messages.
Sep 12 2023, 9:16 AM
marcin accepted D9113: [native] get notifications one time keys.
Sep 12 2023, 9:14 AM
tomek added a comment to D8851: [web] Use chat mention candidates in markdown rules.

We probably should memoize the rules

Sep 12 2023, 9:11 AM
michal added a comment to D9124: [keyserver] Implement `getInitialReduxStateResponder`.

Probably moving policies logic from the responder itself to a higher place where we just avoid returning anything will make this code simpler - but since this will change in the future anyway (ENG-4137) it's okay the way it is

Sep 12 2023, 9:03 AM
michal updated the diff for D9124: [keyserver] Implement `getInitialReduxStateResponder`.

Merge

Sep 12 2023, 9:02 AM
michal updated the diff for D9122: [keyserver] Introduce getInitialReduxStateResponder.

Small fixes

Sep 12 2023, 9:00 AM
michal added inline comments to D9122: [keyserver] Introduce getInitialReduxStateResponder.
Sep 12 2023, 9:00 AM
tomek accepted D8874: [native] Memorize ChatContextProvider.
Sep 12 2023, 8:56 AM
tomek requested changes to D8847: [native] Change ChatContextProvider position.

This looks strange. We were rendering ChatContextProvider quite high in the tree, a couple of levels above navigation. Now, in order to make it accessible in other places, we're placing it within navigation. So it seems we're reducing the number of places where it is accessible. Am I missing something?

Sep 12 2023, 8:56 AM
tomek added a comment to D8846: [native] Use chat mention candidates in markdown rules.

It might make sense to introduce a new hook that:

  1. Get the candidates using useThreadChatMentionCandidates
  2. Computes the rules using getDefaultTextMessageRules
  3. Memoizes them using memo
Sep 12 2023, 8:50 AM
kamil planned changes to D9033: [Tunnelbroker] Add readme.
Sep 12 2023, 8:50 AM
kamil commandeered D9033: [Tunnelbroker] Add readme.

@kamil, would you be interested in commandeering this revision?

Sep 12 2023, 8:50 AM
michal requested review of D9109: [web] Enable db for all users.
Sep 12 2023, 8:42 AM
tomek requested changes to D8845: [native] Introduce markdown component for chat mentions.
Sep 12 2023, 8:42 AM
michal updated the diff for D9109: [web] Enable db for all users.

Amend test plan, don't set userID if not needed. Also added a log for clearing sensitive data.

Sep 12 2023, 8:41 AM
michal updated the test plan for D9109: [web] Enable db for all users.
Sep 12 2023, 8:39 AM
kamil added inline comments to D9109: [web] Enable db for all users.
Sep 12 2023, 8:32 AM
kamil accepted D9124: [keyserver] Implement `getInitialReduxStateResponder`.

Looks like a straightforward change

Sep 12 2023, 8:28 AM
kamil accepted D9122: [keyserver] Introduce getInitialReduxStateResponder.
Sep 12 2023, 8:11 AM
kamil accepted D9109: [web] Enable db for all users.

Could you add to the test plan case, when you first apply this diff and then log in? (I remember this was a tricky case when implementing the first version)

Sep 12 2023, 7:53 AM
michal added a comment to D9139: [feature-flags] Use default HTTP port for deployments.

Should we also update the docker-compose.yml to use the new port?

Sep 12 2023, 7:34 AM
kamil accepted D9127: [native] rename fields in JSON serialized string to camelCase from snake_case.
Sep 12 2023, 7:30 AM
michal accepted D9138: [feature-flags] Standardize localstack and http config.
Sep 12 2023, 7:27 AM
bartek published D9139: [feature-flags] Use default HTTP port for deployments for review.
Sep 12 2023, 7:24 AM
bartek published D9138: [feature-flags] Standardize localstack and http config for review.
Sep 12 2023, 7:22 AM
bartek accepted D9093: [lib/web/native] Generate and encode an ephemeral AES-256 key in the QR code.
Sep 12 2023, 7:18 AM
bartek accepted D9127: [native] rename fields in JSON serialized string to camelCase from snake_case.
Sep 12 2023, 7:16 AM
bartek accepted D8820: [Keyserver/rust] Used shared identity client.
Sep 12 2023, 7:14 AM
bartek accepted D9128: [Tunnelbroker] match JS naming convention.
Sep 12 2023, 6:43 AM
bartek closed D9117: [feature-flags] Update Dockerfile.
Sep 12 2023, 6:34 AM
bartek committed rCOMM7ce666defa48: [feature-flags] Update Dockerfile.
Sep 12 2023, 6:34 AM
bartek closed D9116: [blob-service] Update Dockerfile.
Sep 12 2023, 6:34 AM
bartek committed rCOMMeb8518e1d3ed: [blob-service] Update Dockerfile.
Sep 12 2023, 6:34 AM
michal accepted D9128: [Tunnelbroker] match JS naming convention.
Sep 12 2023, 6:32 AM

Sep 11 2023

ginsu requested changes to D9132: [native] Lift `openedSwipeableID`/`numItemsToDisplay` state to `ConnectedChatThreadList`.

Might be overthinking this, so feel free to push back, but I think we can still use prevState with the useState hook

Sep 11 2023, 11:12 PM
ginsu accepted D9131: [native] Lift `[threads/users]SearchResults` state to `ConnectedChatThreadList`.
Sep 11 2023, 11:02 PM
atul published D9136: [native] Replace `scrollPos` instance variable w/ ref for review.
Sep 11 2023, 11:01 PM
ginsu added a comment to D9130: [native] Lift `search[Status/Text]` state to `ConnectedChatThreadList`.

Thanks for breaking down this diff! It is super clear what the changes are!!

Sep 11 2023, 11:00 PM
ginsu accepted D9130: [native] Lift `search[Status/Text]` state to `ConnectedChatThreadList`.
Sep 11 2023, 10:59 PM
atul published D9135: [native] Pull static fns out of `ChatThreadList` to `ChatThreadListUtils` for review.
Sep 11 2023, 10:23 PM
atul requested review of D9134: [native] Lift `searchUsers` and `onChangeSearchText` to `ConnectedChatThreadList`.
Sep 11 2023, 9:36 PM
ashoat added inline comments to D8958: [native] introduce custom bottom sheet handle component.
Sep 11 2023, 8:52 PM
atul published D9133: [native] Lift `searchCancelButton*` `Value`/`Node`s to `ConnectedChatThreadList` for review.
Sep 11 2023, 8:47 PM
ashoat requested changes to D9007: [keyserver] Render chat mention in notification text.

There are so many issues here. I don't think we can proceed with this approach, especially given @patryk's limited time left at Comm.

Sep 11 2023, 8:45 PM
ashoat requested changes to D9006: [keyserver] Introduce function which checks if thread is mentionable.

See comments in D9007. Given @patryk's limited time left on Comm, I think we need to abandon this approach

Sep 11 2023, 8:42 PM
atul requested review of D9132: [native] Lift `openedSwipeableID`/`numItemsToDisplay` state to `ConnectedChatThreadList`.
Sep 11 2023, 8:37 PM
atul requested review of D9131: [native] Lift `[threads/users]SearchResults` state to `ConnectedChatThreadList`.
Sep 11 2023, 8:36 PM
atul requested review of D9130: [native] Lift `search[Status/Text]` state to `ConnectedChatThreadList`.
Sep 11 2023, 8:36 PM
ashoat added inline comments to D8834: [lib] Introduce chat mention match and parse utilities.
Sep 11 2023, 8:12 PM
ashoat added inline comments to D8897: [native] Refactor TypeaheadTooltip component.
Sep 11 2023, 8:08 PM
rohan closed D9112: [lib/native] Remain consistent with url naming pattern.
Sep 11 2023, 7:49 PM
rohan committed rCOMM67bdf1ce42ff: [lib/native] Remain consistent with url naming pattern.
Sep 11 2023, 7:49 PM
ashoat added a comment to D8993: [client-backup] implement API call to upload backup.

At some point we'll probably want to think about how uploads might work in the background. If the backup is large, I could imagine that the client would need background upload in order to complete the upload. Is there a task to track this?

Sep 11 2023, 7:28 PM
varun requested review of D9129: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object.
Sep 11 2023, 5:56 PM
atul closed D9118: [native] Convert `ConnectedSwipeable` to functional component.
Sep 11 2023, 5:52 PM
atul committed rCOMMac54b888a06d: [native] Convert `ConnectedSwipeable` to functional component.
Sep 11 2023, 5:52 PM
atul updated the diff for D9118: [native] Convert `ConnectedSwipeable` to functional component.

rebase and land

Sep 11 2023, 5:51 PM
atul attached a referenced file: F753200: 572e23.png.
Sep 11 2023, 5:50 PM
atul added inline comments to D9118: [native] Convert `ConnectedSwipeable` to functional component.
Sep 11 2023, 5:50 PM
varun added inline comments to D9127: [native] rename fields in JSON serialized string to camelCase from snake_case.
Sep 11 2023, 5:33 PM
varun commandeered D8820: [Keyserver/rust] Used shared identity client.
Sep 11 2023, 3:33 PM
kamil published D9128: [Tunnelbroker] match JS naming convention for review.
Sep 11 2023, 3:30 PM
ashoat added a comment to D9033: [Tunnelbroker] Add readme.

@kamil, would you be interested in commandeering this revision?

Sep 11 2023, 3:30 PM
ashoat added a comment to D8820: [Keyserver/rust] Used shared identity client.

I assume this work is necessary for the keyserver to be able to connect to the identity service. @varun, is that right? If so, I think you'll need to commandeer it.

Sep 11 2023, 3:30 PM
inka closed D9104: [web] Fix nested a tags.
Sep 11 2023, 3:06 PM
inka committed rCOMM439f1371107c: [web] Fix nested a tags.
Sep 11 2023, 3:06 PM
inka added a comment to D9126: [web][native] Fix message search showing toggle pin robotext.

ENG-4920

Sep 11 2023, 3:01 PM
varun requested review of D9127: [native] rename fields in JSON serialized string to camelCase from snake_case.
Sep 11 2023, 3:00 PM
inka added a comment to D9126: [web][native] Fix message search showing toggle pin robotext.

I removed copy paste between search on web and native. I will create a followup task to use this function in pinned messages, because it seems to me that this logic wan be used there as well.

Sep 11 2023, 2:58 PM
inka updated the diff for D9126: [web][native] Fix message search showing toggle pin robotext.

Use isComposableMessageType

Sep 11 2023, 2:32 PM
inka added inline comments to D9126: [web][native] Fix message search showing toggle pin robotext.
Sep 11 2023, 2:28 PM
inka requested review of D9126: [web][native] Fix message search showing toggle pin robotext.

Requesting review, because I ended up extracting a lot of common code to lib. This is code that takes messages returned from messageListData and filters them to just include the messages we initaily fetched from the search endpoint

Sep 11 2023, 2:27 PM