Accepting to unblock but the pattern of copy-paste is concerning
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Mar 27 2023
Mar 27 2023
ginsu added a comment to D7137: [native] render thread avatars for parent/child threads in thread settings.
Thanks for submitting!! I am clueless in Rust and this appears mostly Rust, so I will resign
• jon added inline comments to D7155: [Native] Migrate native_rust_library to use identity client stubs.
• jon added inline comments to D7155: [Native] Migrate native_rust_library to use identity client stubs.
• jon retitled D7197: [Web] Package opaque-ke-wasm files from [Web] Package wasm files to [Web] Package opaque-ke-wasm files.
[native] RustPromiseManager
• kuba added inline comments to D7141: [keyserver] Display edited message in the sidebar if the source message is edited.
ginsu committed rCOMMf55b55b3fef7: [native] render thread avatar in CHANNEL AVATAR thread settings section (authored by ginsu).
[native] render thread avatar in CHANNEL AVATAR thread settings section
ginsu committed rCOMM2eac9ba06075: [native] update message list header to new design (authored by ginsu).
[native] update message list header to new design
Rebase to master
Set id to readonly
ginsu updated the diff for D7135: [native] render thread avatar in CHANNEL AVATAR thread settings section.
rebase before landing
rebase before landing
Rebase
• kuba updated the diff for D7127: [lib][keyserver] Introduce new threadPermissions types for editing messages.
Rebase
marcin updated the diff for D7125: Use new notifications permission API to modify push notifs settings alerts on Android 13.
Rebase before landing
marcin updated the diff for D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
Rebase before landing
marcin updated the diff for D7106: Native Java code to request notifications permissions from JS on Android 13.
Rebase before landing
Rebase before landing
marcin requested review of D7193: Save message instantly to redux for both foregrounded and backgrounded app.
ashoat committed rCOMM26c2d2f52e0b: [keyserver] Fix account deletion performance (authored by ashoat).
[keyserver] Fix account deletion performance
Clarify that it's in the timezone of the keyserver
[lib] Introduce useENSAvatar hook
Requesting changes for inline comment, and for the discussion previously in D7076
marcin updated the diff for D7125: Use new notifications permission API to modify push notifs settings alerts on Android 13.
Rebase before landing
marcin updated the diff for D7106: Native Java code to request notifications permissions from JS on Android 13.
Rebase before landing
Rebase before landing
ashoat accepted D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
Looks great! Please wait for Android build to complete successfully before landing
marcin updated the diff for D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
- Ensure there is only one promise calling Java notifications permission code at a time.
- Use Promise.all
It wasn't initially obvious to me that this is the right approach. But after some time it seems to make sense.
inka updated subscribers of D7117: [keyserver] Add migration - process messages in our db for search.
Changes due to changes in D7076
I will continue the discussion on parsing after I scope my next goal
Address review: rename the table and give a name to the fulltext index. All indexes are named by concatenating the names of the columns they index, so I'm using this convention.
Goinng to continue the discussion on parsing in D7077
Mar 26 2023
Mar 26 2023
[lib] introduce useGetAvatarForThread hook
ginsu committed rCOMM82a9fdc14701: [lib] introduce getUserAvatarForThread function (authored by ginsu).
[lib] introduce getUserAvatarForThread function
ginsu committed rCOMM35699428c66f: [keyserver/lib/native/web] introduce color-utils and move color functions from… (authored by ginsu).
[keyserver/lib/native/web] introduce color-utils and move color functions from…
rebase before landing
address ashoats comment
ginsu updated the diff for D7177: [keyserver/lib/native/web] introduce color-utils and move color functions from thread-utils to color-utils.
rebase before landing
ginsu added a comment to D7177: [keyserver/lib/native/web] introduce color-utils and move color functions from thread-utils to color-utils.
Not familiar with that error myself, wondering what "initialization" means in this context (is it a circular dependency issue?)
atul committed rCOMM83252ba96c76: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s (authored by atul).
[keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s
atul added inline comments to D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.
atul updated the diff for D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.
change avatar !== null check to avatar truthiness check
atul updated the diff for D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.
rebase before addressing all feedback
atul committed rCOMM6d756a2c3195: [keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on… (authored by atul).
[keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on…
atul updated the diff for D7176: [keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on `codeVersion`.
rebase and land