In D7838#235423, @inka wrote:Why do we want to do that?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
May 23 2023
May 23 2023
ashoat committed rCOMM4c772b92e080: [native] Rename FullscreenSIWEPanel onClose prop to goBackToPrompt (authored by ashoat).
[native] Rename FullscreenSIWEPanel onClose prop to goBackToPrompt
ashoat committed rCOMMf0791928faa6: [native] Extract onClose-disabling behavior from SIWEPanel to… (authored by ashoat).
[native] Extract onClose-disabling behavior from SIWEPanel to…
ashoat committed rCOMM8931825daf4d: [native] Use Arial for all body text in registration flow (authored by ashoat).
[native] Use Arial for all body text in registration flow
ashoat committed rCOMMf3e5e91a3801: [native] Use loading button variant in ConnectEthereum during username search (authored by ashoat).
[native] Use loading button variant in ConnectEthereum during username search
ashoat committed rCOMMdf6166aa2bb5: [native] Implement UsernameSelection logic (authored by ashoat).
[native] Implement UsernameSelection logic
In D7925#235234, @atul wrote:Should we style the input w/ a red outline when there's invalid input + some sort of error state? (cc @ted)
I would expect something more like the right:
Either way, implementation matches the designs
Avoid putting JSX into React state
Use useNavigateToThread
Address review
Address review comments, use LoadableVideo, move props refactor from D7899
Use React imports, remove comment
Rebase
Reverted the prop refactors. Memoized component
Blob decryption in one pass
marcin updated the diff for D7813: Implement function to encrypt relevant parts of iOS notification.
Blob encrypt in one pass
Use readonly type
Moved FocusTrap to the ModalOverlay
Moved default background color
Can you remove the color from modal-overlay.css and set the default in ModalOverlay? I feel this will be more readable.
ashoat requested changes to D7874: Encrypt Android notifications on the keyserver before sending them.
Why do we want to do that?
ashoat added inline comments to D7797: Implement olm session updater that has encrypting functionality.
tomek requested review of D7944: [keyserver] Use mixed as an input type in inviteLinkVerificationResponder.
Use brighter color
Make reducer more efficient
Looks good
tomek retitled D7907: [lib] Allow calling link-disabling endpoint from [lib] Add reducer and endpoint calling code to [lib] Allow calling link-disabling endpoint.
In D7907#234718, @kamil wrote:I think the differential name is not complete and confusing a bit
Specify return type and use mixed as input type
Memoized backgroundColor
In D7885#234677, @kamil wrote:Can you share a screenshot of how this looks like?
Minor fixes
In D7837#235331, @ashoat wrote:In a previous comment, I said:
In D7837#233153, @ashoat wrote:... then wrapping web/modals/modal.react.js in a <FocusTrap> component would make all of our modals "trap focus". This is probably a good thing to do for all modals, and I think it would solve the problem here.
@kuba, what do you think?
However, in this diff you've only added FocusTrap to your specific modal. Can you provide some detail as to why you took a different approach, and whether you considered the approach I suggested?
Thanks for solving this the "right" way with a red diff that simplifies things!
In a previous comment, I said:
Fix - couldn't close edit modal
Fix updating height after text changes
tomek updated the diff for D7879: [lib] Add client side boilerplate and reducer for an endpoint that allows creating or updating public links.
Rebase
Review
tomek updated the diff for D7878: [keyserver] Create an endpoint that can be used to create or update a public link.
Minor fixes
tomek added inline comments to D7878: [keyserver] Create an endpoint that can be used to create or update a public link.
tomek added inline comments to D7878: [keyserver] Create an endpoint that can be used to create or update a public link.
ashoat added inline comments to D6973: [web] Extract from drawer item code that can be reused in community items.
tomek added inline comments to D7733: [native] Display a button and navigate to invite links if they are present.
Update color name
Looks good, but would love to see an opinion from someone more experienced in @react-navigation (cc. @inka)
Delete unnecessary migration
Should we style the input w/ a red outline when there's invalid input + some sort of error state? (cc @ted)