whoa this looks smooth, first rotation animation?
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jun 7 2023
Jun 7 2023
Jun 6 2023
Jun 6 2023
varun requested review of D8134: [identity] implement addReservedUsername and removeReservedUsername RPCs.
• ted added a comment to D8068: [native] Refactor the members list to support any variety of role labels.
CC @ted for design (current design doesn't looks great imo. Text seems busy + don't think it looks great left-aligned with avatar on next line. Could we consider alternative approaches? I've seen other messaging apps indicate admin vs. "member" with a crown icon for example. Maybe roles could have icons?)
Harbormaster failed remote builds in B20074: Diff 27505 for D8066: [identity] update login_password_user_start and register_password_user_start!
ginsu published D8132: [landing] add faq section and request access section to keyserver page for review.
varun added inline comments to D8066: [identity] update login_password_user_start and register_password_user_start.
varun updated the diff for D8066: [identity] update login_password_user_start and register_password_user_start.
address feedback
Harbormaster failed remote builds in B20071: Diff 27502 for D8131: Flip the switch to enable community creation!
atul updated the diff for D8115: [native] Display "Skip"/"Done" button to exit community creation flow.
rebase and alnd
atul published D8130: [native] Navigate to newly created community after successful creation for review.
• jon added 1 blocking reviewer(s) for D8094: [Identity] Refactor access token verification to be more usable: varun.
rohan updated the diff for D8067: [web] Refactor the members modal to support any variety of role labels.
Address feedback
simply animation using grid
atul requested review of D8115: [native] Display "Skip"/"Done" button to exit community creation flow.
ginsu added inline comments to D8098: [native] Block TimeStamp from rendering in the pinned messages screen.
marcin requested review of D8114: Provided detailed error messages on olm functions failures in CryptoModule.
rebase with updated comm logo
remove gradient from comm logo
ashoat added inline comments to D8098: [native] Block TimeStamp from rendering in the pinned messages screen.
ashoat added a comment to D8068: [native] Refactor the members list to support any variety of role labels.
(should we "singularize" "Members" and "Admins" so it appears as "Member" and "Admin"?)
ashoat added a comment to D8070: Implement CommConstants HostObject with `NATIVE_MESSAGE_TYPES` property in C++.
This is cool – our first HostObject!
ashoat accepted D8072: [lib] Remove parent admin from members list if they are not part of the thread.
Okay, cool. I'm a bit worried that in the future we might introduce an "admin" role for a channel in a community, and in that scenario this code would break ThreadSettingsLeaveThread's usage of otherUsersButNoOtherAdmins. But I guess we can address that when we get there...
ashoat added inline comments to D7943: [landing] introduce logo svg assets for competitor comparison.
ashoat requested review of D8110: [native] Dispatch SET_DATA_LOADED action after registration completes.
inka requested review of D8105: [native] Add functions to filter thread descendants in community drawer.
ginsu requested changes to D8098: [native] Block TimeStamp from rendering in the pinned messages screen.
questions regarding use of IIFE
Code change looks fine
atul requested changes to D8067: [web] Refactor the members modal to support any variety of role labels.
I could alternatively define roleName outside the scope of this memo and then put it in the dependency array
Looks good, think we can skip classNames altogether for headingClassName though.
avoid scientific notation
Ping on this review
marcin updated the diff for D8070: Implement CommConstants HostObject with `NATIVE_MESSAGE_TYPES` property in C++.
Implement constants caching