Page MenuHomePhabricator
Differential D7907

[lib] Allow calling link-disabling endpoint
ClosedPublic
Actions

Authored by tomek on May 22 2023, 6:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 11:49 AM
Unknown Object (File)
Wed, Mar 26, 11:49 AM
Unknown Object (File)
Wed, Mar 26, 11:49 AM
Unknown Object (File)
Wed, Mar 26, 11:49 AM
Unknown Object (File)
Mon, Mar 24, 1:09 PM
Unknown Object (File)
Feb 25 2025, 10:48 PM
Unknown Object (File)
Feb 13 2025, 5:46 PM
Unknown Object (File)
Feb 13 2025, 5:46 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
bartek
kamil
inka
Commits
rCOMMa9c78258205c: [lib] Allow calling link-disabling endpoint
Summary

The reducer deletes an entry in the store. In the future we will have to do more here, as not only public links can be disabled.

Depends on D7906

Test Plan

Confirm disabling a link and check if it was deleted, e.g. by verifying that disable link button disappears.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.May 22 2023, 6:29 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 22 2023, 6:29 AM
tomek added a child revision: D7908: [native] Introduce disable link button.May 22 2023, 6:32 AM
Harbormaster completed remote builds in B19589: Diff 26774.May 22 2023, 6:47 AM
tomek requested review of this revision.May 22 2023, 6:47 AM
kamil accepted this revision.May 22 2023, 10:44 AM

I think the differential name is not complete and confusing a bit

lib/reducers/invite-links-reducer.js
44 ↗(On Diff #26774)

I would move currentPrimaryLink?.name === action.payload.name condition to if upper, and avoid modifying the state if it's falsy

This revision is now accepted and ready to land.May 22 2023, 10:44 AM
tomek edited parent revisions, added: D7944: [keyserver] Use mixed as an input type in inviteLinkVerificationResponder; removed: D7906: [keyserver] Create an endpoint that allows disabling links.May 23 2023, 6:49 AM
In D7907#234718, @kamil wrote:

I think the differential name is not complete and confusing a bit

It seems so... not sure what happened

tomek retitled this revision from [lib] Add reducer and endpoint calling code to [lib] Allow calling link-disabling endpoint.May 23 2023, 6:52 AM
tomek added a parent revision: D7906: [keyserver] Create an endpoint that allows disabling links.
tomek updated this revision to Diff 26885.May 23 2023, 6:59 AM

Make reducer more efficient

Harbormaster completed remote builds in B19677: Diff 26885.May 23 2023, 7:18 AM
Closed by commit rCOMMa9c78258205c: [lib] Allow calling link-disabling endpoint (authored by tomek). · Explain WhyMay 24 2023, 4:23 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMa9c78258205c: [lib] Allow calling link-disabling endpoint.

Revision Contents
Changeset List

PathSize
lib/
actions/
24 lines
reducers/
19 lines
types/
5 lines
17 lines

Diff 26885

View Options

lib/actions/link-actions.js

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Linesconst bindCallKeyserverEndpointSelector = createSelector(
( (
dispatch: Dispatch, dispatch: Dispatch,
currentUserInfo: ?CurrentUserInfo, currentUserInfo: ?CurrentUserInfo,
keyserverInfos: { +[keyserverID: string]: KeyserverInfo }, keyserverInfos: { +[keyserverID: string]: KeyserverInfo },
) => { ) => {
return _memoize( return _memoize(
<Args: $ReadOnlyArray<mixed>, Return>( <Args: $ReadOnlyArray<mixed>, Return>(
keyserverCall: KeyserverCall<Args, Return>, keyserverCall: KeyserverCall<Args, Return>,
): ((...Args) => Promise<Return>) => { ): ((...Args) => Promise<Return>) => {
michalUnsubmitted
Not Done
Inline Actions

I meant that this Return is wrong, because in case of fanout it returns [Return]

michal: I meant that this `Return` is wrong, because in case of `fanout` it returns `[Return]`
const callKeyserverEndpoint = ( const callKeyserverEndpoint = (
endpoint: Endpoint, endpoint: Endpoint,
data: Object, data: Object,
args: Args, args: Args,
options?: ?CallServerEndpointOptions, options?: ?CallServerEndpointOptions,
) => { ) => {
// TODO const bindCallKeyserverEndpoint = (keyserverID: string) => {
if (keyserverCall.config.keyserverSelection === 'fanout') {
return Promise.resolve(undefined);
}
const keyserverID = keyserverCall.config.keyserverIDExtractor(
...args,
);
const { const {
cookie, cookie,
urlPrefix, urlPrefix,
sessionID, sessionID,
connection, connection,
lastCommunicatedPlatformDetails, lastCommunicatedPlatformDetails,
} = keyserverInfos[keyserverID]; } = keyserverInfos[keyserverID];
const boundCallServerEndpoint = createBoundServerCallsSelector( const boundCallServerEndpoint = createBoundServerCallsSelector(
keyserverID, keyserverID,
)({ )({
dispatch, dispatch,
currentUserInfo, currentUserInfo,
cookie, cookie,
urlPrefix, urlPrefix,
sessionID, sessionID,
connectionStatus: connection.status, connectionStatus: connection.status,
lastCommunicatedPlatformDetails, lastCommunicatedPlatformDetails,
}); });
return boundCallServerEndpoint(endpoint, data, options); return boundCallServerEndpoint(endpoint, data, options);
}; };
if (keyserverCall.config.keyserverSelection === 'fanout') {
const promises = [];
for (const keyserverID in keyserverInfos) {
promises.push(bindCallKeyserverEndpoint(keyserverID));
}
return Promise.all(promises);
}
const keyserverID = keyserverCall.config.keyserverIDExtractor(
...args,
);
return bindCallKeyserverEndpoint(keyserverID);
};
return keyserverCall.actionFunc(callKeyserverEndpoint); return keyserverCall.actionFunc(callKeyserverEndpoint);
}, },
); );
}, },
); );
function useKeyserverCall<Args: $ReadOnlyArray<mixed>, Return>( function useKeyserverCall<Args: $ReadOnlyArray<mixed>, Return>(
Show All 21 Lines
View Options

lib/reducers/invite-links-reducer.js

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Linesconst bindCallKeyserverEndpointSelector = createSelector(
( (
dispatch: Dispatch, dispatch: Dispatch,
currentUserInfo: ?CurrentUserInfo, currentUserInfo: ?CurrentUserInfo,
keyserverInfos: { +[keyserverID: string]: KeyserverInfo }, keyserverInfos: { +[keyserverID: string]: KeyserverInfo },
) => { ) => {
return _memoize( return _memoize(
<Args: $ReadOnlyArray<mixed>, Return>( <Args: $ReadOnlyArray<mixed>, Return>(
keyserverCall: KeyserverCall<Args, Return>, keyserverCall: KeyserverCall<Args, Return>,
): ((...Args) => Promise<Return>) => { ): ((...Args) => Promise<Return>) => {
michalUnsubmitted
Not Done
Inline Actions

I meant that this Return is wrong, because in case of fanout it returns [Return]

michal: I meant that this `Return` is wrong, because in case of `fanout` it returns `[Return]`
const callKeyserverEndpoint = ( const callKeyserverEndpoint = (
endpoint: Endpoint, endpoint: Endpoint,
data: Object, data: Object,
args: Args, args: Args,
options?: ?CallServerEndpointOptions, options?: ?CallServerEndpointOptions,
) => { ) => {
// TODO const bindCallKeyserverEndpoint = (keyserverID: string) => {
if (keyserverCall.config.keyserverSelection === 'fanout') {
return Promise.resolve(undefined);
}
const keyserverID = keyserverCall.config.keyserverIDExtractor(
...args,
);
const { const {
cookie, cookie,
urlPrefix, urlPrefix,
sessionID, sessionID,
connection, connection,
lastCommunicatedPlatformDetails, lastCommunicatedPlatformDetails,
} = keyserverInfos[keyserverID]; } = keyserverInfos[keyserverID];
const boundCallServerEndpoint = createBoundServerCallsSelector( const boundCallServerEndpoint = createBoundServerCallsSelector(
keyserverID, keyserverID,
)({ )({
dispatch, dispatch,
currentUserInfo, currentUserInfo,
cookie, cookie,
urlPrefix, urlPrefix,
sessionID, sessionID,
connectionStatus: connection.status, connectionStatus: connection.status,
lastCommunicatedPlatformDetails, lastCommunicatedPlatformDetails,
}); });
return boundCallServerEndpoint(endpoint, data, options); return boundCallServerEndpoint(endpoint, data, options);
}; };
if (keyserverCall.config.keyserverSelection === 'fanout') {
const promises = [];
for (const keyserverID in keyserverInfos) {
promises.push(bindCallKeyserverEndpoint(keyserverID));
}
return Promise.all(promises);
}
const keyserverID = keyserverCall.config.keyserverIDExtractor(
...args,
);
return bindCallKeyserverEndpoint(keyserverID);
};
return keyserverCall.actionFunc(callKeyserverEndpoint); return keyserverCall.actionFunc(callKeyserverEndpoint);
}, },
); );
}, },
); );
function useKeyserverCall<Args: $ReadOnlyArray<mixed>, Return>( function useKeyserverCall<Args: $ReadOnlyArray<mixed>, Return>(
Show All 21 Lines
View Options

lib/types/link-types.js

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Linesconst bindCallKeyserverEndpointSelector = createSelector(
( (
dispatch: Dispatch, dispatch: Dispatch,
currentUserInfo: ?CurrentUserInfo, currentUserInfo: ?CurrentUserInfo,
keyserverInfos: { +[keyserverID: string]: KeyserverInfo }, keyserverInfos: { +[keyserverID: string]: KeyserverInfo },
) => { ) => {
return _memoize( return _memoize(
<Args: $ReadOnlyArray<mixed>, Return>( <Args: $ReadOnlyArray<mixed>, Return>(
keyserverCall: KeyserverCall<Args, Return>, keyserverCall: KeyserverCall<Args, Return>,
): ((...Args) => Promise<Return>) => { ): ((...Args) => Promise<Return>) => {
michalUnsubmitted
Not Done
Inline Actions

I meant that this Return is wrong, because in case of fanout it returns [Return]

michal: I meant that this `Return` is wrong, because in case of `fanout` it returns `[Return]`
const callKeyserverEndpoint = ( const callKeyserverEndpoint = (
endpoint: Endpoint, endpoint: Endpoint,
data: Object, data: Object,
args: Args, args: Args,
options?: ?CallServerEndpointOptions, options?: ?CallServerEndpointOptions,
) => { ) => {
// TODO const bindCallKeyserverEndpoint = (keyserverID: string) => {
if (keyserverCall.config.keyserverSelection === 'fanout') {
return Promise.resolve(undefined);
}
const keyserverID = keyserverCall.config.keyserverIDExtractor(
...args,
);
const { const {
cookie, cookie,
urlPrefix, urlPrefix,
sessionID, sessionID,
connection, connection,
lastCommunicatedPlatformDetails, lastCommunicatedPlatformDetails,
} = keyserverInfos[keyserverID]; } = keyserverInfos[keyserverID];
const boundCallServerEndpoint = createBoundServerCallsSelector( const boundCallServerEndpoint = createBoundServerCallsSelector(
keyserverID, keyserverID,
)({ )({
dispatch, dispatch,
currentUserInfo, currentUserInfo,
cookie, cookie,
urlPrefix, urlPrefix,
sessionID, sessionID,
connectionStatus: connection.status, connectionStatus: connection.status,
lastCommunicatedPlatformDetails, lastCommunicatedPlatformDetails,
}); });
return boundCallServerEndpoint(endpoint, data, options); return boundCallServerEndpoint(endpoint, data, options);
}; };
if (keyserverCall.config.keyserverSelection === 'fanout') {
const promises = [];
for (const keyserverID in keyserverInfos) {
promises.push(bindCallKeyserverEndpoint(keyserverID));
}
return Promise.all(promises);
}
const keyserverID = keyserverCall.config.keyserverIDExtractor(
...args,
);
return bindCallKeyserverEndpoint(keyserverID);
};
return keyserverCall.actionFunc(callKeyserverEndpoint); return keyserverCall.actionFunc(callKeyserverEndpoint);
}, },
); );
}, },
); );
function useKeyserverCall<Args: $ReadOnlyArray<mixed>, Return>( function useKeyserverCall<Args: $ReadOnlyArray<mixed>, Return>(
Show All 21 Lines
View Options

lib/types/redux-types.js

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Linesconst bindCallKeyserverEndpointSelector = createSelector(
( (
dispatch: Dispatch, dispatch: Dispatch,
currentUserInfo: ?CurrentUserInfo, currentUserInfo: ?CurrentUserInfo,
keyserverInfos: { +[keyserverID: string]: KeyserverInfo }, keyserverInfos: { +[keyserverID: string]: KeyserverInfo },
) => { ) => {
return _memoize( return _memoize(
<Args: $ReadOnlyArray<mixed>, Return>( <Args: $ReadOnlyArray<mixed>, Return>(
keyserverCall: KeyserverCall<Args, Return>, keyserverCall: KeyserverCall<Args, Return>,
): ((...Args) => Promise<Return>) => { ): ((...Args) => Promise<Return>) => {
michalUnsubmitted
Not Done
Inline Actions

I meant that this Return is wrong, because in case of fanout it returns [Return]

michal: I meant that this `Return` is wrong, because in case of `fanout` it returns `[Return]`
const callKeyserverEndpoint = ( const callKeyserverEndpoint = (
endpoint: Endpoint, endpoint: Endpoint,
data: Object, data: Object,
args: Args, args: Args,
options?: ?CallServerEndpointOptions, options?: ?CallServerEndpointOptions,
) => { ) => {
// TODO const bindCallKeyserverEndpoint = (keyserverID: string) => {
if (keyserverCall.config.keyserverSelection === 'fanout') {
return Promise.resolve(undefined);
}
const keyserverID = keyserverCall.config.keyserverIDExtractor(
...args,
);
const { const {
cookie, cookie,
urlPrefix, urlPrefix,
sessionID, sessionID,
connection, connection,
lastCommunicatedPlatformDetails, lastCommunicatedPlatformDetails,
} = keyserverInfos[keyserverID]; } = keyserverInfos[keyserverID];
const boundCallServerEndpoint = createBoundServerCallsSelector( const boundCallServerEndpoint = createBoundServerCallsSelector(
keyserverID, keyserverID,
)({ )({
dispatch, dispatch,
currentUserInfo, currentUserInfo,
cookie, cookie,
urlPrefix, urlPrefix,
sessionID, sessionID,
connectionStatus: connection.status, connectionStatus: connection.status,
lastCommunicatedPlatformDetails, lastCommunicatedPlatformDetails,
}); });
return boundCallServerEndpoint(endpoint, data, options); return boundCallServerEndpoint(endpoint, data, options);
}; };
if (keyserverCall.config.keyserverSelection === 'fanout') {
const promises = [];
for (const keyserverID in keyserverInfos) {
promises.push(bindCallKeyserverEndpoint(keyserverID));
}
return Promise.all(promises);
}
const keyserverID = keyserverCall.config.keyserverIDExtractor(
...args,
);
return bindCallKeyserverEndpoint(keyserverID);
};
return keyserverCall.actionFunc(callKeyserverEndpoint); return keyserverCall.actionFunc(callKeyserverEndpoint);
}, },
); );
}, },
); );
function useKeyserverCall<Args: $ReadOnlyArray<mixed>, Return>( function useKeyserverCall<Args: $ReadOnlyArray<mixed>, Return>(
Show All 21 Lines