Page MenuHomePhorge
Feed Search

Sep 14 2022

jon requested review of D5137: [Ignore] Test if harbormaster triggers.
Sep 14 2022, 5:43 PM
jon updated the summary of D5135: [CI] Add identity pre-commit hook.
Sep 14 2022, 5:42 PM
jon requested review of D5135: [CI] Add identity pre-commit hook.
Sep 14 2022, 5:30 PM
jon closed D5126: [CI] Add identity tests to buildkite.
Sep 14 2022, 4:44 PM
jon committed rCOMM3932977f36f8: [CI] Add identity tests to buildkite.
Sep 14 2022, 4:44 PM
jon added a comment to D5133: [GH Actions] Include `brew install protobuf` step in iOS build workflow.

This will likely install protobuf 3.21; in which case, you will get compilation errors unless you regenerate all of the protobuf files.

Sep 14 2022, 3:56 PM
jon closed D5129: [CI] Add tunnelbroker unittests.
Sep 14 2022, 6:47 AM
jon committed rCOMMfe9f76b6bd14: [CI] Add tunnelbroker unittests.
Sep 14 2022, 6:47 AM
jon closed D5128: [Nix] Provide c-ares cmake config.
Sep 14 2022, 6:47 AM
jon committed rCOMM264a7f504ba1: [Nix] Provide c-ares cmake config.
Sep 14 2022, 6:47 AM
jon accepted D5084: [native] add CXX header files to Xcode project.

this will likely need to be updated with https://linear.app/comm/issue/ENG-1804 anyway. I guess I'm fine

Sep 14 2022, 6:44 AM
jon added a comment to D5128: [Nix] Provide c-ares cmake config.

However, no idea what nativeBuildInputs = (o.nativeBuildInputs or []) ++ [ prev.cmake ];

Sep 14 2022, 6:22 AM
jon updated the diff for D5128: [Nix] Provide c-ares cmake config.

Actually, just use cmake to build c-ares

Sep 14 2022, 12:36 AM

Sep 13 2022

jon requested review of D5129: [CI] Add tunnelbroker unittests.
Sep 13 2022, 11:40 PM
jon requested review of D5128: [Nix] Provide c-ares cmake config.
Sep 13 2022, 11:37 PM
jon planned changes to D4970: [Docs] Provide nixified version of tableplus.
Sep 13 2022, 10:30 PM
jon planned changes to D4969: [Docs] Fix nix store typo.
Sep 13 2022, 10:25 PM
jon planned changes to D4978: [Docs] Update nix_dev_env.md to reference relevant docs.

I think for now, I'll just cave in and have a section for installing homebrew + stuff that's not available on nixpkgs. Not sure how much I want to take on unbounded work :/

Sep 13 2022, 10:21 PM
jon added inline comments to D5035: [services] Rust Integration - Backup - Rust - Multiple put clients.
Sep 13 2022, 7:16 PM
jon closed D5114: [Services] Remove Arc usage.
Sep 13 2022, 7:16 PM
jon committed rCOMM70ed8a7b9d35: [Services] Remove Arc usage.
Sep 13 2022, 7:16 PM
jon accepted D5099: [services] Backup - Blob Get Client - Pass rust string instead of const char*.

improvement

Sep 13 2022, 7:12 PM
jon requested review of D5126: [CI] Add identity tests to buildkite.
Sep 13 2022, 6:48 PM
jon closed D5120: [Chore] Cleanup blob CMakeLists.txt.
Sep 13 2022, 6:45 PM
jon closed D5119: [Chore] Cleanup tunnelbroker CMakeLists.txt.
Sep 13 2022, 6:45 PM
jon committed rCOMMdcc1dc7431e6: [Chore] Cleanup blob CMakeLists.txt.
Sep 13 2022, 6:45 PM
jon committed rCOMM237416184fb3: [Chore] Cleanup tunnelbroker CMakeLists.txt.
Sep 13 2022, 6:45 PM
jon closed D5118: [Services] Use BUILD_TESTING for tunnelbroker build.
Sep 13 2022, 6:45 PM
jon committed rCOMM54348ade8842: [Services] Use BUILD_TESTING for tunnelbroker build.
Sep 13 2022, 6:45 PM
jon closed D5117: [Services] Fix backup test suite build.
Sep 13 2022, 6:45 PM
jon closed D5116: [Services] Fix blob test build.
Sep 13 2022, 6:45 PM
jon committed rCOMM07375b672901: [Services] Fix blob test build.
Sep 13 2022, 6:45 PM
jon committed rCOMMf3f886ab6d54: [Services] Fix backup test suite build.
Sep 13 2022, 6:45 PM
jon closed D5121: [Services] Avoid using GTest in docker.
Sep 13 2022, 6:45 PM
jon committed rCOMM2e355ef44e35: [Services] Avoid using GTest in docker.
Sep 13 2022, 6:45 PM
jon closed D5125: [Identity] Reference new proto location.
Sep 13 2022, 6:13 PM
jon committed rCOMM9d0d1c31e451: [Identity] Reference new proto location.
Sep 13 2022, 6:13 PM
jon requested review of D5125: [Identity] Reference new proto location.
Sep 13 2022, 5:41 PM
jon added a comment to D5123: [Backup] Add logging to blob_client.

In addition to that:

Sep 13 2022, 4:54 PM
jon added a comment to D5118: [Services] Use BUILD_TESTING for tunnelbroker build.

the tests aren't running (and failing).

Sep 13 2022, 4:41 PM
jon updated the diff for D5118: [Services] Use BUILD_TESTING for tunnelbroker build.

Default BUILD_TESTING to ON

Sep 13 2022, 4:41 PM

Sep 12 2022

jon added a comment to D5122: [Services] Allow for tunnelbroker to receive command-line args.

https://linear.app/comm/issue/ENG-1799/dont-immediate-fail-if-tunnelbrokerini-is-missing is the spiritual successor to this

Sep 12 2022, 11:11 PM
jon abandoned D5122: [Services] Allow for tunnelbroker to receive command-line args.

Agreed, the current paradigm should be extended.

Sep 12 2022, 11:10 PM
jon requested review of D5124: [Backup] Initialize logger with tokio runtime.
Sep 12 2022, 10:59 PM
jon requested review of D5123: [Backup] Add logging to blob_client.
Sep 12 2022, 10:56 PM
jon requested review of D5122: [Services] Allow for tunnelbroker to receive command-line args.
Sep 12 2022, 10:36 PM
jon requested review of D5119: [Chore] Cleanup tunnelbroker CMakeLists.txt.
Sep 12 2022, 9:19 PM
jon requested review of D5117: [Services] Fix backup test suite build.
Sep 12 2022, 9:19 PM
jon requested review of D5120: [Chore] Cleanup blob CMakeLists.txt.
Sep 12 2022, 9:17 PM
jon requested review of D5118: [Services] Use BUILD_TESTING for tunnelbroker build.
Sep 12 2022, 9:16 PM
jon requested review of D5116: [Services] Fix blob test build.
Sep 12 2022, 9:13 PM
jon requested review of D5121: [Services] Avoid using GTest in docker.
Sep 12 2022, 9:09 PM
jon closed D5103: [Services] Update protobuf location for blob_client.
Sep 12 2022, 5:50 PM
jon committed rCOMM63aea3159b6a: [Services] Update protobuf location for blob_client.
Sep 12 2022, 5:50 PM
jon closed D5102: [Services] Update commtest protobuf location.
Sep 12 2022, 5:50 PM
jon committed rCOMM0fe62495322b: [Services] Update commtest protobuf location.
Sep 12 2022, 5:50 PM
jon closed D5106: [CMake] Use correct protobuf capitalization.
Sep 12 2022, 5:50 PM
jon closed D5101: [Chore] Unbreak rust_pre_commit for UNIX.
Sep 12 2022, 5:50 PM
jon committed rCOMMa2524b1cce6a: [Chore] Unbreak rust_pre_commit for UNIX.
Sep 12 2022, 5:50 PM
jon committed rCOMMbb49bb232c94: [CMake] Use correct protobuf capitalization.
Sep 12 2022, 5:50 PM
jon closed D5105: [Chore] Add new protos build dir to gitignore.
Sep 12 2022, 5:50 PM
jon committed rCOMM0721bc662099: [Chore] Add new protos build dir to gitignore.
Sep 12 2022, 5:50 PM
atul empowered jon as an administrator.
Sep 12 2022, 5:00 PM
jon accepted D5092: [services] Backup - Blob Get Client - Refactor get initialize.

better

Sep 12 2022, 4:42 PM
jon accepted D5091: [services] Backup - Blob Get Client - Refactor get read.

better

Sep 12 2022, 4:42 PM
jon accepted D5090: [services] Backup - Blob Get Client - Refactor get terminate.

better

Sep 12 2022, 4:42 PM
jon resigned from D5068: [services] Rust Integration - c++ - Add worker.
Sep 12 2022, 4:33 PM
jon accepted D5064: [services] Tunnelbroker - Fix an OpenSSL crate collision.

This isn't necessary on the nix develop side, but this probably fixes the docker build as it has an older version of openssl available.

Sep 12 2022, 4:28 PM
jon requested changes to D5051: rust project for native blob gRPC client.
Sep 12 2022, 4:19 PM
jon added inline comments to D5035: [services] Rust Integration - Backup - Rust - Multiple put clients.
Sep 12 2022, 4:18 PM
jon requested changes to D5099: [services] Backup - Blob Get Client - Pass rust string instead of const char*.
Sep 12 2022, 4:11 PM
jon accepted D5112: [services] Rust Integration - c++ - Add getNumberOfCores.
Sep 12 2022, 4:09 PM
jon accepted D5096: [services] Backup - Blob Get Client - Refactor put initialize.
Sep 12 2022, 4:07 PM
jon accepted D5093: [services] Backup - Blob Get Client - Refactor put terminate.
Sep 12 2022, 4:05 PM
jon requested review of D5114: [Services] Remove Arc usage.
Sep 12 2022, 3:22 PM

Sep 10 2022

jon requested review of D5106: [CMake] Use correct protobuf capitalization.
Sep 10 2022, 12:43 AM

Sep 9 2022

jon requested review of D5105: [Chore] Add new protos build dir to gitignore.
Sep 9 2022, 11:56 PM
jon requested changes to D5084: [native] add CXX header files to Xcode project.

i think this makes sense as a separate change because i'll be moving a bunch of files and it'll clutter this diff. what do you think?

Sep 9 2022, 10:34 PM
jon accepted D4953: [native] add Rust gRPC client to XCode project.

We should probably use a build rule so that it doesn't need to blindly call this each time. But blindly calling it isn't too terrible as cargo builds should be relatively quick after initial build

Sep 9 2022, 9:02 PM
jon requested changes to D5084: [native] add CXX header files to Xcode project.

https://phab.comm.dev/D5084#148472 is still applicable

Sep 9 2022, 9:01 PM
jon requested review of D5103: [Services] Update protobuf location for blob_client.
Sep 9 2022, 7:23 PM
jon requested review of D5102: [Services] Update commtest protobuf location.
Sep 9 2022, 7:21 PM
jon requested review of D5101: [Chore] Unbreak rust_pre_commit for UNIX.
Sep 9 2022, 7:15 PM
jon added inline comments to D5064: [services] Tunnelbroker - Fix an OpenSSL crate collision.
Sep 9 2022, 6:25 PM
jon accepted D5081: [services] Tunnelbroker - Add `topic` to APNs.
Sep 9 2022, 6:12 PM
jon accepted D5066: [services] Tunnelbroker - Changes to handle HTTP code inside the Rust `send_notif_to_apns` function.
Sep 9 2022, 6:10 PM
jon accepted D5083: [services] Tunnelbroker - Add payload to APNs message to make it `content-available`.

Send the apns message using the following library call from C++:

Sep 9 2022, 6:07 PM
jon added a comment to D5089: [services] Backup - Blob Get Client - Prepare for error handling.

feel like the linting stuff should have been applied to the respective revisions. Also feel like the "create more revisions to apply feedback" is creating more churn for everyone, instead of applying the feedback in the original revision, then doing a rebase after applying the feedback.

Sep 9 2022, 5:59 PM
jon requested changes to D5093: [services] Backup - Blob Get Client - Refactor put terminate.
Sep 9 2022, 5:52 PM
jon accepted D5094: [services] Backup - Blob Get Client - Refactor put write.
Sep 9 2022, 5:49 PM
jon accepted D5095: [services] Backup - Blob Get Client - Refactor put read.
Sep 9 2022, 5:49 PM
jon requested changes to D5096: [services] Backup - Blob Get Client - Refactor put initialize.
Sep 9 2022, 5:47 PM
jon accepted D5097: [services] Backup - Blob Get Client - Cleanup.

better than panic'ing

Sep 9 2022, 5:38 PM
jon requested changes to D5098: [services] Rust Integration - Backup - Rust - Fix backup utils.

This fixes the incorrect code from D5072.

Sep 9 2022, 5:35 PM

Sep 8 2022

jon added a comment to D4953: [native] add Rust gRPC client to XCode project.

protoc should be found if it's on the PATH. Otherwise some library messed up because the POSIX way to find something is through PATH.

Sep 8 2022, 5:32 PM
jon closed D5046: [Native] Remove old protos and related files.
Sep 8 2022, 5:30 PM
jon committed rCOMM83e7e359cad8: [Native] Remove old protos and related files.
Sep 8 2022, 5:30 PM
jon closed D5045: [Native] Prune protobuf logic from CMakeLists.txt.
Sep 8 2022, 5:30 PM
jon closed D5044: [Services] Update docker references to protobuf.
Sep 8 2022, 5:30 PM
jon closed D5043: [Services] Update backup to reference new proto location.
Sep 8 2022, 5:30 PM