Page MenuHomePhabricator
Feed Advanced Search

Mar 3 2023

ashoat accepted D6943: [keyserver] add loginUserWallet function.
Mar 3 2023, 12:55 PM
ashoat added a comment to D6943: [keyserver] add loginUserWallet function.

Why is socialProof separate from siweMessage + siweSignature? Is it for the same reason that we pull signingPublicKey from sessionInitializationInfo (convenience)?

Mar 3 2023, 12:45 PM
ashoat added inline comments to D6946: [keyserver] double-write to identity service from siweAuthResponder callpoint.
Mar 3 2023, 12:38 PM
ashoat added inline comments to D6941: [keyserver] call Identity service RegisterUser RPC from createAccount.
Mar 3 2023, 12:38 PM
ashoat accepted D6944: [Keyserver/identity] Call identity service update_user.

JS looks good, but identity build seems to have failed CI. Adding @varun as blocking for the Rust side of things

Mar 3 2023, 12:34 PM
ashoat accepted D6951: [lib] Introduce `SignedIdentityKeysBlob[ServerRequest/ClientResponse]` types.

Please wait on relevant parts of CI

Mar 3 2023, 12:16 PM
ashoat closed D6938: [lib] Include fact that you were tagged in sidebar creation message.
Mar 3 2023, 12:11 PM
ashoat closed D6937: [lib] Extract notifTextsForSidebarCreation.
Mar 3 2023, 12:11 PM
ashoat committed rCOMMe861dc492aaa: [lib] Include fact that you were tagged in sidebar creation message (authored by ashoat).
[lib] Include fact that you were tagged in sidebar creation message
Mar 3 2023, 12:11 PM
ashoat committed rCOMM0e3776a47f81: [lib] Extract notifTextsForSidebarCreation (authored by ashoat).
[lib] Extract notifTextsForSidebarCreation
Mar 3 2023, 12:11 PM
ashoat closed D6935: [keyserver] Dedup notifTextsForMessageInfo calls in sendPushNotifs.
Mar 3 2023, 12:11 PM
ashoat closed D6936: [keyserver][lib] Allow notificationTexts to return null.
Mar 3 2023, 12:11 PM
ashoat committed rCOMMf54f9346616e: [keyserver] Dedup notifTextsForMessageInfo calls in sendPushNotifs (authored by ashoat).
[keyserver] Dedup notifTextsForMessageInfo calls in sendPushNotifs
Mar 3 2023, 12:11 PM
ashoat committed rCOMMcd53fa783f4a: [keyserver][lib] Allow notificationTexts to return null (authored by ashoat).
[keyserver][lib] Allow notificationTexts to return null
Mar 3 2023, 12:11 PM
ashoat closed D6934: [keyserver] Drill MessageDatas into notificationCollapseKey.
Mar 3 2023, 12:11 PM
ashoat closed D6933: [keyserver] Drill MessageDatas into sendPushNotifs.
Mar 3 2023, 12:11 PM
ashoat committed rCOMM1b36e66869c7: [keyserver] Drill MessageDatas into notificationCollapseKey (authored by ashoat).
[keyserver] Drill MessageDatas into notificationCollapseKey
Mar 3 2023, 12:11 PM
ashoat committed rCOMM7e9c849bb41e: [keyserver] Drill MessageDatas into sendPushNotifs (authored by ashoat).
[keyserver] Drill MessageDatas into sendPushNotifs
Mar 3 2023, 12:11 PM
ashoat closed D6932: [keyserver] Only set sidebarCreation flag for the first message in the sidebar.
Mar 3 2023, 12:11 PM
ashoat committed rCOMM6c3bc221b254: [keyserver] Only set sidebarCreation flag for the first message in the sidebar (authored by ashoat).
[keyserver] Only set sidebarCreation flag for the first message in the sidebar
Mar 3 2023, 12:11 PM
ashoat accepted D6950: [lib] Introduce `identityKeysBlobValidator` and use in `login`/`register`/`siwe_auth` responders.
Mar 3 2023, 12:07 PM
ashoat added inline comments to D6944: [Keyserver/identity] Call identity service update_user.
Mar 3 2023, 10:54 AM
ashoat requested changes to D6944: [Keyserver/identity] Call identity service update_user.
Mar 3 2023, 10:34 AM
ashoat added a reviewer for D6946: [keyserver] double-write to identity service from siweAuthResponder callpoint: atul.
Mar 3 2023, 9:01 AM
ashoat added a reviewer for D6941: [keyserver] call Identity service RegisterUser RPC from createAccount: atul.
Mar 3 2023, 9:00 AM
ashoat added a reviewer for D6914: [keyserver] add loginUserPake function to rust-node-addon, call it from loginResponder in js: atul.
Mar 3 2023, 9:00 AM
ashoat accepted D6946: [keyserver] double-write to identity service from siweAuthResponder callpoint.
Mar 3 2023, 9:00 AM
ashoat accepted D6941: [keyserver] call Identity service RegisterUser RPC from createAccount.
Mar 3 2023, 8:59 AM
ashoat accepted D6914: [keyserver] add loginUserPake function to rust-node-addon, call it from loginResponder in js.

Just one nit. Realizing my comment from last time probably doesn't make sense to Flow, and passing in the primary ed25519 twice (in signingPublicKey and sessionInitializationInfo) lets Rust avoid having to re-parse the JSON

Mar 3 2023, 8:51 AM
ashoat resigned from D6912: [Protos] Add UpdateUser definitions.

Defer to you guys, I don't know enough about PAKE to comment on the .proto, and I don't know Rust so can't comment on the rest

Mar 3 2023, 8:47 AM

Mar 2 2023

ashoat requested review of D6937: [lib] Extract notifTextsForSidebarCreation.
Mar 2 2023, 3:52 PM
ashoat requested review of D6938: [lib] Include fact that you were tagged in sidebar creation message.
Mar 2 2023, 3:52 PM
ashoat requested review of D6936: [keyserver][lib] Allow notificationTexts to return null.
Mar 2 2023, 3:51 PM
ashoat requested review of D6935: [keyserver] Dedup notifTextsForMessageInfo calls in sendPushNotifs.
Mar 2 2023, 3:51 PM
ashoat requested review of D6934: [keyserver] Drill MessageDatas into notificationCollapseKey.
Mar 2 2023, 2:18 PM
ashoat requested review of D6933: [keyserver] Drill MessageDatas into sendPushNotifs.
Mar 2 2023, 2:18 PM
ashoat requested review of D6932: [keyserver] Only set sidebarCreation flag for the first message in the sidebar.
Mar 2 2023, 2:17 PM
ashoat accepted D6931: [lib] Sanitize Redux `CryptoStore`.
Mar 2 2023, 1:46 PM
ashoat removed a reviewer for D6634: [web] implement emoji keyboard position into message tooltip: tomek.

Taking it off of @tomek's plate

Mar 2 2023, 11:41 AM
ashoat accepted D6634: [web] implement emoji keyboard position into message tooltip.
Mar 2 2023, 11:40 AM
ashoat updated the diff for D6634: [web] implement emoji keyboard position into message tooltip.

Minor

Mar 2 2023, 11:38 AM
ashoat updated the diff for D6634: [web] implement emoji keyboard position into message tooltip.

Avoid "coupling" in favor of a linear data flow

Mar 2 2023, 11:36 AM
ashoat added inline comments to D6917: Prepare to conditionally process rescinds in NSE..
Mar 2 2023, 8:23 AM
ashoat added inline comments to D6917: Prepare to conditionally process rescinds in NSE..
Mar 2 2023, 8:22 AM
ashoat added a comment to D6919: Remove relevant notification from notifications center when receiving rescind in NSE.

Got it, thanks for explaining!

Mar 2 2023, 8:09 AM
ashoat added inline comments to D6917: Prepare to conditionally process rescinds in NSE..
Mar 2 2023, 8:08 AM
ashoat accepted D6927: [desktop CI] Inherit secrets in github release workflow.

Seems reasonable

Mar 2 2023, 8:05 AM
ashoat added inline comments to D6634: [web] implement emoji keyboard position into message tooltip.
Mar 2 2023, 8:02 AM
ashoat added a comment to D6923: [keyserver] Tunnelbroker integration - Adding Tunnelbroker publisher and connector.

Thought about this a bit more. We need to make sure that we don't accidentally initialize two tbClientBinding, but TunnelbrokerPublisher.connect is an async function, which makes this difficult to guarantee.

Mar 2 2023, 7:53 AM
ashoat added inline comments to D6919: Remove relevant notification from notifications center when receiving rescind in NSE.
Mar 2 2023, 7:28 AM
ashoat added inline comments to D6922: Permanently enable rescind and visible notifications processing via NotificationService.
Mar 2 2023, 7:24 AM
ashoat added inline comments to D6917: Prepare to conditionally process rescinds in NSE..
Mar 2 2023, 7:24 AM

Mar 1 2023

ashoat requested changes to D6923: [keyserver] Tunnelbroker integration - Adding Tunnelbroker publisher and connector.
Mar 1 2023, 8:29 PM
ashoat resigned from D6925: [Identity] Refactor opaque_ke usage to dedicated file.

I don't know Rust :(

Mar 1 2023, 8:27 PM
ashoat accepted D6912: [Protos] Add UpdateUser definitions.

API looks good as far as I can tell, but I don't really understand the OPAQUE protocol definition so mostly deferring to you

Mar 1 2023, 8:26 PM
ashoat requested changes to D6634: [web] implement emoji keyboard position into message tooltip.

Okay, never mind... let's pause on this work until you have time to pair with me

Mar 1 2023, 8:24 PM

Feb 28 2023

ashoat added a comment to D6634: [web] implement emoji keyboard position into message tooltip.

Oh actually, it sounds like you can just try this:

Feb 28 2023, 3:00 PM
ashoat added a comment to D6865: [web] Allow media gallery items to click through to a full screen view on web.

Hey @rohan, you seem to have partially landed your stack. Just wanted to get some clarification – what is the current state of master after your partial land? I want to make sure we aren't in a bad state where we are blocked from deploys. (If so, we should revert)

Feb 28 2023, 2:10 PM
ashoat requested changes to D6634: [web] implement emoji keyboard position into message tooltip.
  1. The rename would've been best in a separate diff
  2. Does D6632 need to be updated so that getEmojiKeyboardPosition no longer looks at emojiKeyboard.getBoundingClientRect()?
  3. It's not clear to me which change is causing the issue here. I think you should investigate:
    • If getting rid of the useEffect is what caused the issue, then you could potentially bring back the useEffect. You would be able to address my "coupling" concern, but not my "set state in effect" concern. Still, that's better than nothing.
    • It's possible that immediately calling getEmojiKeyboardPosition from the ref function is causing the problem, and you could potentially undo that by moving back to storing the node itself as state, and computing getEmojiKeyboardPosition in a useMemo that takes the node as input
Feb 28 2023, 2:08 PM
ashoat added a comment to D6913: [keyserver] reorganize rust-node-addon.

I think it would've been good to separate this into two diffs: one that moves the code around, and the other than changes things (eg. the interceptor that you added). More details here

Feb 28 2023, 1:56 PM
ashoat updated subscribers of D6172: [CommCoreModule] Remove `userID` argument from `initializeCryptoAccount(...)`.

It looks like this is handled by D6780 now, and @marcin confirmed that it does not break XCode tests (which I assume includes CryptoTests?)

Feb 28 2023, 1:53 PM
ashoat added inline comments to D6893: [keyserver] Send macos notifications.
Feb 28 2023, 1:00 PM
ashoat added inline comments to D6889: [keyserver/web/desktop] Add macos and windows as platforms.
Feb 28 2023, 12:59 PM
ashoat added inline comments to D6817: [keyserver] Send web push notification.
Feb 28 2023, 12:58 PM
ashoat added inline comments to D6894: [desktop] Handle macos notifications.
Feb 28 2023, 6:12 AM
ashoat added a comment to D6172: [CommCoreModule] Remove `userID` argument from `initializeCryptoAccount(...)`.

We still need to do this, don't we?

Feb 28 2023, 6:09 AM
ashoat added a comment to D6904: [identity] GetSessionInitializationInfo RPC.

Yeah but it makes it much harder whenever we want to change it. Protobufs / gRPC don't handle versioning of schemas very well. @jon, do you have a good story on how we'll handle it if we need to add a new entry?

Feb 28 2023, 6:08 AM
ashoat added a comment to D6908: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login`.

Missed this previously

Feb 28 2023, 6:06 AM

Feb 27 2023

ashoat added a comment to D6909: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth`.

Never mind that's D6911

Feb 27 2023, 7:43 PM
ashoat accepted D6911: [keyserver] Check `primaryIdentityPublicKeys.ed25519` against SIWE statement `primaryIdentityPublicKey`.
Feb 27 2023, 7:43 PM
ashoat accepted D6909: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth`.
Feb 27 2023, 7:43 PM
ashoat added inline comments to D6904: [identity] GetSessionInitializationInfo RPC.
Feb 27 2023, 7:10 PM
ashoat accepted D6904: [identity] GetSessionInitializationInfo RPC.
Feb 27 2023, 7:10 PM
ashoat accepted D6908: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login`.
Feb 27 2023, 7:09 PM
ashoat accepted D6907: [keyserver] Replace `public_key` column with `signed_identity_keys` in `cookies` table.

So is the format basically { +payload: string, +signature: string }, where payload is the previously agreed upon JSON format?

Feb 27 2023, 4:20 PM
ashoat accepted D6906: [keyserver] Ignore `primaryIdentityPublicKey` at `login`/`register`/`siwe_auth` endpoints.
Feb 27 2023, 4:18 PM
ashoat requested changes to D6904: [identity] GetSessionInitializationInfo RPC.
Feb 27 2023, 4:16 PM
ashoat closed D6874: [lib] Make CreateSidebar notifs say when the OP tags the notif recipient.
Feb 27 2023, 3:56 PM
ashoat committed rCOMMb965736d93dd: [lib] Make CreateSidebar notifs say when the OP tags the notif recipient (authored by ashoat).
[lib] Make CreateSidebar notifs say when the OP tags the notif recipient
Feb 27 2023, 3:56 PM
ashoat closed D6873: [keyserver][lib] Pass notifTargetUserInfo to notificationTexts.
Feb 27 2023, 3:56 PM
ashoat closed D6872: [keyserver] Update notif prepare functions to take bag of params.
Feb 27 2023, 3:56 PM
ashoat committed rCOMMb78c6f05fcb3: [keyserver][lib] Pass notifTargetUserInfo to notificationTexts (authored by ashoat).
[keyserver][lib] Pass notifTargetUserInfo to notificationTexts
Feb 27 2023, 3:56 PM
ashoat closed D6871: [keyserver] Make sure we fetch username of all notif recipients.
Feb 27 2023, 3:56 PM
ashoat committed rCOMM9a53f51d3c24: [keyserver] Update notif prepare functions to take bag of params (authored by ashoat).
[keyserver] Update notif prepare functions to take bag of params
Feb 27 2023, 3:56 PM
ashoat committed rCOMMfea1dddf0ca5: [keyserver] Make sure we fetch username of all notif recipients (authored by ashoat).
[keyserver] Make sure we fetch username of all notif recipients
Feb 27 2023, 3:56 PM
ashoat closed D6869: [lib] Collapse CreateSidebar and SidebarSource notifs together.
Feb 27 2023, 3:56 PM
ashoat closed D6870: [lib] Add invariant to SidebarSource notificationTexts.
Feb 27 2023, 3:56 PM
ashoat committed rCOMM26af81a8b67b: [lib] Add invariant to SidebarSource notificationTexts (authored by ashoat).
[lib] Add invariant to SidebarSource notificationTexts
Feb 27 2023, 3:56 PM
ashoat committed rCOMM73d7ff10b795: [lib] Collapse CreateSidebar and SidebarSource notifs together (authored by ashoat).
[lib] Collapse CreateSidebar and SidebarSource notifs together
Feb 27 2023, 3:56 PM
ashoat closed D6867: [keyserver] Check SIDEBAR_SOURCE's source message for @-mention notif override.
Feb 27 2023, 3:56 PM
ashoat closed D6868: [lib] Allow multiple messages in CreateSidebar notificationTexts.
Feb 27 2023, 3:56 PM
ashoat committed rCOMM26a5b892c206: [lib] Allow multiple messages in CreateSidebar notificationTexts (authored by ashoat).
[lib] Allow multiple messages in CreateSidebar notificationTexts
Feb 27 2023, 3:56 PM
ashoat committed rCOMMa0927c1d5c85: [keyserver] Check SIDEBAR_SOURCE's source message for @-mention notif override (authored by ashoat).
[keyserver] Check SIDEBAR_SOURCE's source message for @-mention notif override
Feb 27 2023, 3:56 PM
ashoat closed D6866: [keyserver] Check all new messages for @-mention notif override.
Feb 27 2023, 3:56 PM
ashoat committed rCOMMa8e7d97f2be9: [keyserver] Check all new messages for @-mention notif override (authored by ashoat).
[keyserver] Check all new messages for @-mention notif override
Feb 27 2023, 3:56 PM
ashoat accepted D6902: [keyserver] Stop persisting `primaryIdentityPublicKey` from `login` request.
Feb 27 2023, 2:36 PM
ashoat accepted D6901: [keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver` start.
Feb 27 2023, 2:35 PM
ashoat accepted D6900: [keyserver] Introduce `OLMUtility` type.
Feb 27 2023, 1:45 PM
ashoat accepted D6897: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder`.
Feb 27 2023, 1:41 PM
ashoat added a comment to D6897: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder`.

this can be landed without issue

Feb 27 2023, 1:28 PM