land

Personal preference is memoization "inside" the component w/ useMemo hook so everything is self-contained and memoization is consistent and whatnot, but this is valid

Sending back to your queue to address feedback from @inka/@ashoat

address @ginsu's feedback

rebase and land

What's the command to run tests? Can they be run without any additional configuration?

rebase and land

rebase and land

rebase and land

In D9103#268200, @tomek wrote:

While introducing a lot of memoization, we should also check how it affects memory usage

rebase and land

Just to verify my understanding, here's a before/after:

To revisit this after recently re-reading https://blog.isquaredsoftware.com/2020/05/blogged-answers-a-mostly-complete-guide-to-react-rendering-behavior/#component-render-optimization-techniques and going through the performance optimization work, I do think this would have been marginally beneficial. Header and Footer are fairly simple so probably doesn't make a noticeable difference though

land

Disregard, pasted flame graph for incorrect render

Would be good for @marcin or @bartek to take a closer look here

Seems reasonable, defer to @marcin since he has more context

Seems reasonable

Personally would prefer if in this same diff we opted for some sort of outline or shadow or anything to preserve the "depth" effect that the glow was supposed to provide

Seems fine at a glance

rebase and alnd

rebase and land

rebase and land

rebase and land

fix

CI

rebase and land

address @tomek's feedback

address @tomek's feedback

address tomek's feedback

In D9050#266876, @tomek wrote:

You can consider using React.memo instead - might be a lot simpler.