Page MenuHomePhabricator
Feed Advanced Search

Nov 29 2023

tomek accepted D10091: [lib] Fix keyserver not present in keyserver store error.
Nov 29 2023, 5:22 AM
tomek accepted D10069: [web] use default `updatesCurrentAsOf` in transform if value is missing.

on the first rehydration this value could be undefined

Is it also true for other values from the keyserverInfo? Should we also handle them somehow?

Nov 29 2023, 12:43 AM

Nov 27 2023

tomek accepted D9961: [keyserver/lib] Introduce a specialRoles enum and special_role column in MariaDB.
Nov 27 2023, 8:25 AM
tomek accepted D10046: [Flow202][native] [62/x] Fill in types for all Platform.select invocations.
Nov 27 2023, 7:27 AM
tomek accepted D10045: [Flow202][native][skip-ci] [61/x] Get rid of Platform.select in ratchetAlongWithKeyboardHeight.
Nov 27 2023, 7:25 AM
tomek accepted D10042: [Flow202][native][skip-ci] [58/x] Destructure this.lastMessageSent before checking its value.
Nov 27 2023, 7:24 AM
tomek accepted D10041: [Flow202][native][skip-ci] [57/x] Avoid looking up nullable type in non-nullable Set in ChatRouter.
Nov 27 2023, 7:23 AM
tomek accepted D10040: [Flow202][native][skip-ci] [56/x] Use Flow's comment syntax in Reanimated worklets.
Nov 27 2023, 7:22 AM
tomek accepted D10039: [Flow202][native][skip-ci] [55/x] Fix Flow issues by adding Promise types.
Nov 27 2023, 7:21 AM
tomek accepted D10030: [Flow202][native][skip-ci] [46/x] Type itemToDummy using React.MixedElement.
Nov 27 2023, 7:20 AM
tomek accepted D10022: [Flow202][native][skip-ci] [38/x] Fix exponential-spread issue in RootRouter.
Nov 27 2023, 7:18 AM
tomek accepted D10021: [Flow202][native][skip-ci] [37/x] Allow removeEditMode to take a TabAction.
Nov 27 2023, 7:13 AM
tomek accepted D10016: [Flow202][native][skip-ci] [32/x] Fix type errors in OverlayNavigator.
Nov 27 2023, 7:12 AM
tomek accepted D10015: [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors.
Nov 27 2023, 6:57 AM
tomek accepted D10007: [Flow202][native][skip-ci] [23/x] Import AnimatedInterpolation type from react-native.
Nov 27 2023, 6:49 AM
tomek accepted D10004: [Flow202][native][skip-ci] [20/x] Update Reanimated libdef to match GestureHandler.
Nov 27 2023, 6:47 AM
tomek accepted D10000: [Flow202][native][skip-ci] [16/x] Type React.forwardRef input functions.
Nov 27 2023, 6:42 AM
tomek accepted D9954: [web] processing ThreadStore ops on worker.
Nov 27 2023, 6:25 AM
tomek accepted D9956: [web] refactor validateState to operations.
Nov 27 2023, 6:20 AM
tomek accepted D9999: [Flow202][native][skip-ci] [15/x] Move unboundStyles to the top.
Nov 27 2023, 3:58 AM
tomek accepted D9997: [Flow202][native][skip-ci] [13/x] Enable NavigationHelpersContext to parameterize on invocation.
Nov 27 2023, 3:55 AM
tomek accepted D9996: [Flow202][native][skip-ci] [12/x] Enable StackView to parameterize on invocation.
Nov 27 2023, 3:52 AM
tomek accepted D9995: [Flow202][native][skip-ci] [11/x] Add type params to ReactNav createMaterialTopTabNavigator call.
Nov 27 2023, 3:45 AM
tomek accepted D9994: [Flow202][native][skip-ci] [10/x] Add type params to ReactNav useNavigationBuilder calls.
Nov 27 2023, 3:42 AM
tomek accepted D9993: [Flow202][native][skip-ci] [9/x] Type navigation prop on all ReactNav screens.
Nov 27 2023, 3:41 AM
tomek accepted D9992: [Flow202][native][skip-ci] [8/x] Fix incorrect ReactNav types in navigators & screens.
Nov 27 2023, 3:37 AM
tomek accepted D9990: [Flow202][native][skip-ci] [6/x] Remove Scene type from ReactNav libdefs.
Nov 27 2023, 3:36 AM
tomek accepted D9989: [Flow202][native][skip-ci] [5/x] Fix parameterization of ReactNav getParent.
Nov 27 2023, 3:35 AM
tomek accepted D9988: [Flow202][native][skip-ci] [4/x] Stop copy-pasting between ReactNav libdefs.
Nov 27 2023, 3:33 AM
tomek accepted D9987: [Flow202][native][skip-ci] [3/x] Introduce @react-navigation/core libdef.
Nov 27 2023, 3:29 AM
tomek accepted D9982: [keyserver] Drop the default_role column from threads.
Nov 27 2023, 3:19 AM
tomek accepted D9981: [keyserver] Update usage of threads.default_role in thread-creator.js.

Is the default_role column nullable at this point?

Nov 27 2023, 3:19 AM
tomek accepted D9980: [keyserver] Update usage of threads.default_role in thread-fetchers.js.
Nov 27 2023, 3:12 AM
tomek accepted D9978: [keyserver] Update usage of threads.default_role in validate-role-permissions.js.
Nov 27 2023, 3:12 AM
tomek accepted D9979: [keyserver] Update usage of threads.default_role in thread-permission-updaters.js.
Nov 27 2023, 3:09 AM
tomek requested changes to D9978: [keyserver] Update usage of threads.default_role in validate-role-permissions.js.
Nov 27 2023, 3:06 AM
tomek accepted D9977: [keyserver] Update usage of threads.default_role in thread-updaters.js.
Nov 27 2023, 1:53 AM
tomek accepted D9975: [keyserver] Update usage of threads.default_role in role-deleters.js.
Nov 27 2023, 12:56 AM
tomek accepted D9974: [keyserver/lib] Populate special_role field when initial roles are created.
Nov 27 2023, 12:51 AM
tomek accepted D9961: [keyserver/lib] Introduce a specialRoles enum and special_role column in MariaDB.
Nov 27 2023, 12:44 AM
tomek added inline comments to D9956: [web] refactor validateState to operations.
Nov 27 2023, 12:10 AM

Nov 24 2023

tomek requested review of D9972: [keyserver] Delete a holder after deleting a blob.
Nov 24 2023, 9:35 AM
tomek requested review of D9968: [keyserver] Fetch invite link blob holder.
Nov 24 2023, 8:43 AM
tomek requested review of D9966: [keyserver] Add a function that deletes a blob.
Nov 24 2023, 7:08 AM
tomek closed D9960: [keyserver] Add a column to invite_links table with a blob holder.
Nov 24 2023, 6:16 AM
tomek committed rCOMM8f30d381b83b: [keyserver] Add a column to invite_links table with a blob holder (authored by tomek).
[keyserver] Add a column to invite_links table with a blob holder
Nov 24 2023, 6:16 AM
tomek updated the diff for D9944: [keyserver] Block creating invite links for which an entry in Blob service already exists.

Use better error code

Nov 24 2023, 6:14 AM
tomek closed D9943: [keyserver] Check if a blob exists.
Nov 24 2023, 4:51 AM
tomek closed D9942: [keyserver] Create a function that downloads blobs.
Nov 24 2023, 4:51 AM
tomek committed rCOMM834594e5184c: [keyserver] Check if a blob exists (authored by tomek).
[keyserver] Check if a blob exists
Nov 24 2023, 4:51 AM
tomek committed rCOMM174754d3184f: [keyserver] Create a function that downloads blobs (authored by tomek).
[keyserver] Create a function that downloads blobs
Nov 24 2023, 4:51 AM
tomek closed D9941: [keyserver] Split uploading blob and assigning holders.
Nov 24 2023, 4:51 AM
tomek closed D9940: [keyserver] Split blob encryption and upload into separate functions.
Nov 24 2023, 4:51 AM
tomek committed rCOMM19bc53760b95: [keyserver] Split uploading blob and assigning holders (authored by tomek).
[keyserver] Split uploading blob and assigning holders
Nov 24 2023, 4:51 AM
tomek committed rCOMM9213ad529af3: [keyserver] Split blob encryption and upload into separate functions (authored by tomek).
[keyserver] Split blob encryption and upload into separate functions
Nov 24 2023, 4:51 AM
tomek closed D9937: [keyserver] Move blob upload code to a new place.
Nov 24 2023, 4:51 AM
tomek committed rCOMMb8ffdb80b834: [keyserver] Move blob upload code to a new place (authored by tomek).
[keyserver] Move blob upload code to a new place
Nov 24 2023, 4:51 AM
tomek updated the diff for D9960: [keyserver] Add a column to invite_links table with a blob holder.

Rebase

Nov 24 2023, 4:09 AM
tomek updated the diff for D9940: [keyserver] Split blob encryption and upload into separate functions.

Rebase

Nov 24 2023, 4:09 AM
tomek accepted D9965: [native] update baseNoDataAfterPolicyAcknowledgmentSelector check.
Nov 24 2023, 3:59 AM
tomek accepted D9959: [web] start using threads from database.
Nov 24 2023, 3:55 AM
tomek requested changes to D9956: [web] refactor validateState to operations.
Nov 24 2023, 1:40 AM
tomek accepted D9955: [web] refactor processing store ops to separate function.
Nov 24 2023, 1:18 AM
tomek accepted D9954: [web] processing ThreadStore ops on worker.
Nov 24 2023, 1:17 AM
tomek accepted D9952: [SQLite] add ThreadStore Emscripten bindings and converters.
Nov 24 2023, 1:10 AM

Nov 23 2023

tomek requested review of D9960: [keyserver] Add a column to invite_links table with a blob holder.
Nov 23 2023, 7:47 AM
tomek added inline comments to D9943: [keyserver] Check if a blob exists.
Nov 23 2023, 3:55 AM
tomek updated the diff for D9940: [keyserver] Split blob encryption and upload into separate functions.

Move encrypting inside try-catch block

Nov 23 2023, 3:23 AM
tomek added inline comments to D9940: [keyserver] Split blob encryption and upload into separate functions.
Nov 23 2023, 3:18 AM
tomek added inline comments to D9952: [SQLite] add ThreadStore Emscripten bindings and converters.
Nov 23 2023, 2:49 AM
tomek accepted D9951: [web/lib] move reading and populating data to state gate.
Nov 23 2023, 2:21 AM
tomek accepted D9949: [web/keyserver] make InitialReduxStateResponder configurable.
Nov 23 2023, 1:15 AM
tomek accepted D9948: [web] start persisting `updatesCurrentAsOf`.
Nov 23 2023, 12:54 AM

Nov 21 2023

tomek requested review of D9944: [keyserver] Block creating invite links for which an entry in Blob service already exists.
Nov 21 2023, 8:45 AM
tomek requested review of D9943: [keyserver] Check if a blob exists.
Nov 21 2023, 8:25 AM
tomek requested review of D9942: [keyserver] Create a function that downloads blobs.
Nov 21 2023, 8:08 AM
tomek requested review of D9941: [keyserver] Split uploading blob and assigning holders.
Nov 21 2023, 7:16 AM
tomek requested review of D9940: [keyserver] Split blob encryption and upload into separate functions.
Nov 21 2023, 6:15 AM
tomek requested review of D9937: [keyserver] Move blob upload code to a new place.
Nov 21 2023, 4:01 AM

Nov 17 2023

tomek accepted D9914: [native] read users from SQLite on app start.
Nov 17 2023, 7:58 AM
tomek accepted D9913: [native] start processing user store ops on SQLite.
Nov 17 2023, 7:53 AM
tomek accepted D9911: [SQLite] implement C++ code to get users.
Nov 17 2023, 7:48 AM
tomek accepted D9910: [SQLite] implement C++ user store ops.
Nov 17 2023, 7:46 AM
tomek accepted D9909: [SQLite] add functions to convert user data and tests to user store methods.
Nov 17 2023, 7:27 AM
tomek accepted D9908: [lib] update `reduceUserInfos` to return ops.

Do we use a similar approach in other reducers? Should we use the same approach there?

Nov 17 2023, 7:22 AM
tomek accepted D9904: [SQLite] add methods to operate on users table.
Nov 17 2023, 7:12 AM
tomek accepted D9903: [SQLite] add table for users.
Nov 17 2023, 7:08 AM

Nov 16 2023

tomek closed D8693: Revert "[keyserver] Use old intermediate invite link page url".
Nov 16 2023, 3:51 AM
tomek added a reverting change for D8691: [keyserver] Use old intermediate invite link page url: rCOMM47d43c530a86: Revert "[keyserver] Use old intermediate invite link page url".
Nov 16 2023, 3:51 AM
tomek added a reverting change for rCOMM42ef356dcf82: [keyserver] Use old intermediate invite link page url: rCOMM47d43c530a86: Revert "[keyserver] Use old intermediate invite link page url".
Nov 16 2023, 3:51 AM
tomek committed rCOMM47d43c530a86: Revert "[keyserver] Use old intermediate invite link page url" (authored by tomek).
Revert "[keyserver] Use old intermediate invite link page url"
Nov 16 2023, 3:51 AM
tomek accepted D9801: [lib] refactor processing updates in `UserStore` to ops.
Nov 16 2023, 3:14 AM

Nov 15 2023

tomek updated the diff for D8693: Revert "[keyserver] Use old intermediate invite link page url".

Rebase

Nov 15 2023, 7:26 AM
tomek updated the diff for D8693: Revert "[keyserver] Use old intermediate invite link page url".

Rebase

Nov 15 2023, 7:20 AM
tomek added a comment to D9890: [lib] Update misc parts of `lib` to support `MinimallyEncodedThreadInfo`.

Are there some places where we're expecting only ThreadInfo and not MinimallyEncodedThreadInfo (or the other way around)? Is it possible to modify ThreadInfo type to be what it already is or MinimallyEncodedThreadInfo (type ThreadInfo = { ... } | MinimallyEncodedThreadInfo)? That might be a more maintainable and much simpler approach.

Nov 15 2023, 1:18 AM

Nov 14 2023

tomek accepted D9873: [Flow202][keyserver][skip-ci] [24/x] Address missing-local-annot type errors.
Nov 14 2023, 8:54 AM
tomek accepted D9870: [Flow202][keyserver][skip-ci] [21/x] Make Date subtraction explicit.
Nov 14 2023, 8:48 AM
tomek accepted D9868: [Flow202][keyserver][skip-ci] [19/x] Fix Flow issues with collection lookup that doesn't match type.
Nov 14 2023, 8:47 AM
tomek accepted D9862: [Flow202][keyserver][skip-ci] [13/x] Address type errors with cookie-parser libdef.
Nov 14 2023, 8:45 AM
tomek accepted D9859: [Flow202][keyserver][skip-ci] [10/x] Address type errors with promiseAll / Promise.all.
Nov 14 2023, 8:34 AM