Page MenuHomePhabricator
Feed Advanced Search

Jun 6 2024

bartek committed rCOMM813c964b002a: [terraform] Update Blob image on prod (authored by bartek).
[terraform] Update Blob image on prod
Jun 6 2024, 12:27 AM
bartek added a comment to D12323: [terraform] remove usage of s3 bucket for terraform config.

This also solves the issue I had that pre-commit hooks wouldn't work without terraform init in self-hosted dir. And terraform init couldn't work without AWS login

Jun 6 2024, 12:24 AM
bartek accepted D12323: [terraform] remove usage of s3 bucket for terraform config.
Jun 6 2024, 12:24 AM
bartek added inline comments to D12282: [identity][grpc_clients] Move PlatformMetadata to grpc_clients crate.
Jun 6 2024, 12:09 AM
bartek added inline comments to D12279: [grpc_clients] Add platform details metadata.
Jun 6 2024, 12:08 AM

Jun 4 2024

bartek added inline comments to D12283: [grpc_clients] Accept PlatformMetadata when creating client.
Jun 4 2024, 9:39 AM
bartek published D12305: [identity][terraform] Add error type for HTTP logs for review.
Jun 4 2024, 8:14 AM
bartek published D12304: [identity] Add /inbound_keys HTTP handler for review.
Jun 4 2024, 8:14 AM
bartek published D12303: [identity] Add HTTP function to verify CSAT for review.
Jun 4 2024, 8:13 AM
bartek published D12302: [identity] Add HTTP error utilities for review.
Jun 4 2024, 8:13 AM
bartek published D12301: [identity] Create module for HTTP handler for review.
Jun 4 2024, 8:12 AM
bartek published D12300: [identity] Add Serialize trait for inbound keys types for review.
Jun 4 2024, 8:12 AM
bartek updated subscribers of D12312: Synchronize platform details with identity on app start.
Jun 4 2024, 8:11 AM
bartek requested changes to D12312: Synchronize platform details with identity on app start.

I think we should make sure that this is being run only once, e.g. by introducing a hasRun ref, like in native/components/version-supported.react.js

Jun 4 2024, 8:07 AM
bartek accepted D12311: Expose syncing platform details to identity client context.
Jun 4 2024, 8:01 AM
bartek accepted D12310: Implement native wrapper for syncPlatformDetails RPC.
Jun 4 2024, 8:00 AM
bartek added a comment to D12308: Enable the client to fetch users platform details from identity RPC.

Related comment from @ashoat: https://phab.comm.dev/D12272#inline-72196

Jun 4 2024, 1:51 AM
bartek updated the diff for D12275: [native_rust_library] Write state version as build-time constant.

Good idea. Added comment to persist.js

Jun 4 2024, 1:21 AM
bartek updated the diff for D12273: [identity] Fetch platform details along with device lists.

Add missing uncommitted change

Jun 4 2024, 1:05 AM
bartek updated the diff for D12270: [identity] Add metadata parser for PlatformDetails.

Add new metadata to CORS headers

Jun 4 2024, 1:05 AM
bartek requested review of D12299: [terraform] Update Blob image on prod.
Jun 4 2024, 12:02 AM

Jun 3 2024

bartek updated subscribers of D12272: [protos] Add PlatformDetails to PeersDeviceListsResponse.
Jun 3 2024, 10:56 PM
bartek accepted D12298: [terraform] mariadb on aws.
Jun 3 2024, 10:54 PM
bartek accepted D12297: [terraform] configure intial sops setup.

Not sure if using SOPS isn't an overkill for self-hosted keyservers (sops main advantages are for secrets stored in git repos), but let's keep it for now, we can simplify it later by e.g. using gitignored plaintext env files or terraform variable files.

Jun 3 2024, 10:53 PM
bartek added inline comments to D12273: [identity] Fetch platform details along with device lists.
Jun 3 2024, 8:53 AM
bartek accepted D12277: [terraform] set up self-host terraform with vpc.
Jun 3 2024, 8:09 AM
bartek closed D12221: [lib] Add hook for secondary device logout.
Jun 3 2024, 7:49 AM
bartek closed D12238: [lib][native] Move device list ops to lib.
Jun 3 2024, 7:49 AM
bartek committed rCOMMdcbb63430b3d: [lib][native] Move device list ops to lib (authored by bartek).
[lib][native] Move device list ops to lib
Jun 3 2024, 7:49 AM
bartek committed rCOMM82ac1b808854: [lib] Add hook for secondary device logout (authored by bartek).
[lib] Add hook for secondary device logout
Jun 3 2024, 7:49 AM
bartek closed D12268: [identity] Reword warns about device list out of sync.
Jun 3 2024, 7:49 AM
bartek committed rCOMM46e8f44193d8: [identity] Reword warns about device list out of sync (authored by bartek).
[identity] Reword warns about device list out of sync
Jun 3 2024, 7:49 AM
bartek updated the diff for D12238: [lib][native] Move device list ops to lib.

Newline. Rebase before landing

Jun 3 2024, 7:16 AM
bartek published D12283: [grpc_clients] Accept PlatformMetadata when creating client for review.
Jun 3 2024, 6:47 AM
bartek accepted D12281: [blob] Don't check if the invite link is reserved.
Jun 3 2024, 6:39 AM
bartek published D12282: [identity][grpc_clients] Move PlatformMetadata to grpc_clients crate for review.
Jun 3 2024, 6:02 AM
bartek published D12280: [web] Add platform details metadata for review.
Jun 3 2024, 6:02 AM
bartek published D12279: [grpc_clients] Add platform details metadata for review.
Jun 3 2024, 6:01 AM
bartek published D12274: [identity][protos] Add RPC to update PlatformDetails for review.

CI seems unrelated

Jun 3 2024, 5:47 AM
bartek published D12273: [identity] Fetch platform details along with device lists for review.
Jun 3 2024, 5:46 AM
bartek published D12272: [protos] Add PlatformDetails to PeersDeviceListsResponse for review.

CI failure unrelated

Jun 3 2024, 5:45 AM
bartek published D12271: [identity] Get device PlatformDetails from metadata for review.
Jun 3 2024, 5:44 AM
bartek published D12270: [identity] Add metadata parser for PlatformDetails for review.

CI failure unrelated

Jun 3 2024, 5:44 AM
bartek published D12269: [identity] Introduce PlatformDetails DDB attribute for review.

Unrelated CI failure

Jun 3 2024, 5:43 AM
bartek published D12275: [native_rust_library] Write state version as build-time constant for review.
Jun 3 2024, 5:43 AM
bartek added reviewers for D12238: [lib][native] Move device list ops to lib: marcin, varun.
Jun 3 2024, 3:51 AM
bartek added reviewers for D12223: [web] Add dev-only button to log out secondary device: marcin, varun.
Jun 3 2024, 3:51 AM
bartek added reviewers for D12222: [native] Add dev-only button to log out secondary device: marcin, varun.
Jun 3 2024, 3:50 AM
bartek requested review of D12268: [identity] Reword warns about device list out of sync.
Jun 3 2024, 1:25 AM
bartek published D12267: [identity] Remove device data on device list update for review.
Jun 3 2024, 12:48 AM

May 29 2024

bartek published D12225: [lib][p2p] Update device list upon receiving logout message for review.
May 29 2024, 10:16 AM
bartek published D12224: [lib] Send logout message to primary device in useSecondaryDeviceLogOut for review.
May 29 2024, 10:14 AM
bartek published D12240: [lib] Add unit tests for functions modifying device list for review.
May 29 2024, 10:13 AM
bartek published D12239: [lib] Add function to remove device from device list for review.
May 29 2024, 10:12 AM
bartek published D12238: [lib][native] Move device list ops to lib for review.
May 29 2024, 10:12 AM
bartek updated the diff for D12221: [lib] Add hook for secondary device logout.
  • Renamed identity logout type to legacy
  • Got rid of useMemo
  • Made object declaration top-level
May 29 2024, 12:39 AM

May 28 2024

bartek requested review of D12231: Update native_rust_library Cargo.lock.
May 28 2024, 8:32 AM
bartek closed D12178: [rust] Fix Clippy warnings about DateTime.
May 28 2024, 8:12 AM
bartek closed D12179: [rust] Fix Clippy warnings.
May 28 2024, 8:12 AM
bartek closed D12176: [blob] Fix Clippy warnings in Blob service.
May 28 2024, 8:12 AM
bartek committed rCOMMd6d4e0d7379b: [rust] Fix Clippy warnings (authored by bartek).
[rust] Fix Clippy warnings
May 28 2024, 8:12 AM
bartek committed rCOMM4d5d38fa8f1b: [rust] Fix Clippy warnings about DateTime (authored by bartek).
[rust] Fix Clippy warnings about DateTime
May 28 2024, 8:12 AM
bartek committed rCOMM617ea3f3a825: [blob] Fix Clippy warnings in Blob service (authored by bartek).
[blob] Fix Clippy warnings in Blob service
May 28 2024, 8:12 AM
bartek closed D12175: [shared] Fix Clippy warnings in comm-opaque2.
May 28 2024, 8:12 AM
bartek committed rCOMMd64451b4e03b: [shared] Fix Clippy warnings in comm-opaque2 (authored by bartek).
[shared] Fix Clippy warnings in comm-opaque2
May 28 2024, 8:12 AM
bartek closed D12174: [feature-flags] Remove aws_types dependency.
May 28 2024, 8:12 AM
bartek closed D12173: [backup] Remove unnecessary aws_types dependency.
May 28 2024, 8:12 AM
bartek committed rCOMM85a24ea994c0: [feature-flags] Remove aws_types dependency (authored by bartek).
[feature-flags] Remove aws_types dependency
May 28 2024, 8:12 AM
bartek committed rCOMMfc55af31d1fa: [backup] Remove unnecessary aws_types dependency (authored by bartek).
[backup] Remove unnecessary aws_types dependency
May 28 2024, 8:12 AM
bartek closed D12172: Inherit crate dependencies from workspace root.
May 28 2024, 8:12 AM
bartek committed rCOMM95d8724f9dd2: Inherit crate dependencies from workspace root (authored by bartek).
Inherit crate dependencies from workspace root
May 28 2024, 8:12 AM
bartek closed D12171: Inherit package metadata from workspace.
May 28 2024, 8:12 AM
bartek closed D12168: Delete unused cargo.lock files.
May 28 2024, 8:12 AM
bartek committed rCOMM0cc8fd3b81bb: Inherit package metadata from workspace (authored by bartek).
Inherit package metadata from workspace
May 28 2024, 8:12 AM
bartek committed rCOMMa43a6af10dce: Delete unused cargo.lock files (authored by bartek).
Delete unused cargo.lock files
May 28 2024, 8:12 AM
bartek closed D12140: Introduce Cargo workspace and update Dockerfiles.
May 28 2024, 8:12 AM
bartek committed rCOMM2c0a48ffe7a8: Introduce Cargo workspace and update Dockerfiles (authored by bartek).
Introduce Cargo workspace and update Dockerfiles
May 28 2024, 8:12 AM
bartek added a comment to D12172: Inherit crate dependencies from workspace root.

should we create backlog tasks for the crates that aren't being inherited from the workspace root? in particular, it would be great to get all our crates on the same version of tonic

May 28 2024, 7:55 AM
bartek updated the diff for D12179: [rust] Fix Clippy warnings.

Rebase before landing

May 28 2024, 7:50 AM
bartek closed D12122: [lib][native][web] Add LogOutSecondaryDevice RPC to identity client.
May 28 2024, 5:42 AM
bartek closed D12121: [native] Expose LogOutSecondaryDevice RPC via JSI.
May 28 2024, 5:42 AM
bartek committed rCOMMfa756c93c57b: [lib][native][web] Add LogOutSecondaryDevice RPC to identity client (authored by bartek).
[lib][native][web] Add LogOutSecondaryDevice RPC to identity client
May 28 2024, 5:42 AM
bartek closed D12120: [identity] Implement RPC to log out secondary device.
May 28 2024, 5:42 AM
bartek committed rCOMMfa8a90e2267f: [native] Expose LogOutSecondaryDevice RPC via JSI (authored by bartek).
[native] Expose LogOutSecondaryDevice RPC via JSI
May 28 2024, 5:42 AM
bartek committed rCOMM99964df8a094: [identity] Implement RPC to log out secondary device (authored by bartek).
[identity] Implement RPC to log out secondary device
May 28 2024, 5:42 AM
bartek closed D12119: [protos] Add RPC for secondary device logout.
May 28 2024, 5:42 AM
bartek committed rCOMMd97f0a2457d3: [protos] Add RPC for secondary device logout (authored by bartek).
[protos] Add RPC for secondary device logout
May 28 2024, 5:42 AM
bartek published D12223: [web] Add dev-only button to log out secondary device for review.
May 28 2024, 5:19 AM
bartek published D12222: [native] Add dev-only button to log out secondary device for review.
May 28 2024, 5:19 AM
bartek published D12221: [lib] Add hook for secondary device logout for review.
May 28 2024, 5:18 AM
bartek accepted D12132: [lib] introduce context to process Outbound P2P Messages.
May 28 2024, 5:15 AM
bartek updated the diff for D12122: [lib][native][web] Add LogOutSecondaryDevice RPC to identity client.

Rebase before landing

May 28 2024, 4:47 AM
bartek updated the diff for D12120: [identity] Implement RPC to log out secondary device.

Address feedback

May 28 2024, 4:47 AM
bartek added inline comments to D12121: [native] Expose LogOutSecondaryDevice RPC via JSI.
May 28 2024, 4:39 AM
bartek added inline comments to D12120: [identity] Implement RPC to log out secondary device.
May 28 2024, 4:37 AM

May 26 2024

bartek accepted D12212: [native_rust_library] fix serialization of BackupKeysResult.

The only changes here after the rebase are code comments – did you accidentally commit the actual code changes separately?

May 26 2024, 1:39 AM

May 24 2024

bartek accepted D12111: [lib] implement removing OutboundP2P messages after confirmation.
May 24 2024, 3:06 AM

May 23 2024

bartek closed D12206: [terraform] Bump staging identity to 0.19.
May 23 2024, 11:36 PM
bartek committed rCOMM7064b47c433f: [terraform] Bump staging identity to 0.19 (authored by bartek).
[terraform] Bump staging identity to 0.19
May 23 2024, 11:36 PM
bartek closed D12135: [web] Retrieve username on secondary device login.
May 23 2024, 11:28 PM