Besides that LGTM
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 13 2024
Jun 13 2024
Jun 12 2024
Jun 12 2024
bartek added a comment to D12377: [Identity] implement sending `IdentityDeviceListUpdated` using Tunnelbroker client.
Might be worth refactoring this function to take array of device IDs &[&str] and send messages in a for loop, to avoid creating tunnelbroker_client for each device when called this in a loop
bartek committed rCOMM769cb5b2e568: [commtest] Restructure code into olm_account module (authored by bartek).
[commtest] Restructure code into olm_account module
bartek committed rCOMM86f7b35e8c1b: [commtest] Rename SigningCapableAccount to MockOlmAccount (authored by bartek).
[commtest] Rename SigningCapableAccount to MockOlmAccount
bartek committed rCOMMca2f17d8813d: [commtest] Make ClientPublicKeys::device_id() return str slice (authored by bartek).
[commtest] Make ClientPublicKeys::device_id() return str slice
bartek committed rCOMM1869f7cedecc: [commtest] Get rid of hardcoded ClientPublicKeys values (authored by bartek).
[commtest] Get rid of hardcoded ClientPublicKeys values
bartek committed rCOMM8d7e41dd83d6: [commtest] Generate random client keys by default (authored by bartek).
[commtest] Generate random client keys by default
bartek committed rCOMM522d00e1ed6c: [commtest] Fix flaky identity-tunnelbroker test (authored by bartek).
[commtest] Fix flaky identity-tunnelbroker test
bartek committed rCOMM8d2fc8dfbb85: [commtest] Add default impl for ClientPublicKeys (authored by bartek).
[commtest] Add default impl for ClientPublicKeys
Rebase before landing
Jun 9 2024
Jun 9 2024
bartek published D12350: [identity] Forbid registering multiple devices with the same ID for review.
Jun 7 2024
Jun 7 2024
CI unrelated
Keyserver CI unrelated
Keyserver CI unrelated
Keyserver CI unrelated
Adapt to the new response format
Update handler to the new format
Keyserver CI unrelated
Keyserver CI unrelated
Jun 6 2024
Jun 6 2024
I'll update this endpoint to return only single device
bartek committed rCOMMf521baa6078a: [grpc_clients] Accept PlatformMetadata when creating client (authored by bartek).
[grpc_clients] Accept PlatformMetadata when creating client
bartek committed rCOMM2e4d4738598b: [identity][grpc_clients] Move PlatformMetadata to grpc_clients crate (authored by bartek).
[identity][grpc_clients] Move PlatformMetadata to grpc_clients crate
[web] Add platform details metadata
bartek committed rCOMMcbb97e73fa3d: [grpc_clients] Add platform details metadata (authored by bartek).
[grpc_clients] Add platform details metadata
bartek committed rCOMMd9300c1b7ff8: [native_rust_library] Write state version as build-time constant (authored by bartek).
[native_rust_library] Write state version as build-time constant
bartek committed rCOMM42f7d6270394: [identity][protos] Add RPC to update PlatformDetails (authored by bartek).
[identity][protos] Add RPC to update PlatformDetails
bartek committed rCOMMe11f39eb3fd0: [identity] Fetch platform details along with device lists (authored by bartek).
[identity] Fetch platform details along with device lists
bartek committed rCOMMc1a7a6082c38: [protos] Add PlatformDetails to PeersDeviceListsResponse (authored by bartek).
[protos] Add PlatformDetails to PeersDeviceListsResponse
bartek committed rCOMM38db612af867: [identity] Add metadata parser for PlatformDetails (authored by bartek).
[identity] Add metadata parser for PlatformDetails
bartek committed rCOMM43fc9702422d: [identity] Get device PlatformDetails from metadata (authored by bartek).
[identity] Get device PlatformDetails from metadata
bartek committed rCOMM033a5fa69f20: [identity] Introduce PlatformDetails DDB attribute (authored by bartek).
[identity] Introduce PlatformDetails DDB attribute
bartek committed rCOMMe6709b53bf7e: [identity] Remove device data on device list update (authored by bartek).
[identity] Remove device data on device list update
bartek committed rCOMMdb8a21dfe270: [lib][p2p] Update device list upon receiving logout message (authored by bartek).
[lib][p2p] Update device list upon receiving logout message
bartek committed rCOMMa98182e55a85: [lib] Send logout message to primary device in useSecondaryDeviceLogOut (authored by bartek).
[lib] Send logout message to primary device in useSecondaryDeviceLogOut
bartek committed rCOMM5946d727ba67: [lib] Add unit tests for functions modifying device list (authored by bartek).
[lib] Add unit tests for functions modifying device list
bartek committed rCOMMbf8cc52f2979: [web] Add dev-only button to log out secondary device (authored by bartek).
[web] Add dev-only button to log out secondary device
bartek committed rCOMMa22a27c78679: [lib] Add function to remove device from device list (authored by bartek).
[lib] Add function to remove device from device list
bartek committed rCOMMfac160b30724: [native] Add dev-only button to log out secondary device (authored by bartek).
[native] Add dev-only button to log out secondary device
bartek updated the diff for D12224: [lib] Send logout message to primary device in useSecondaryDeviceLogOut.
Review feedback, add try-catch before creating a new Olm session
bartek added inline comments to D12224: [lib] Send logout message to primary device in useSecondaryDeviceLogOut.
Narrow down matcher type
Use isDev
Thanks
I haven't dug deep into what these params mean but they match docker configuration so it should be okay
bartek added a comment to D12324: [terraform] Replace all config options with terraform variables and remove sops.
Two comments here:
- When using one of "default" filenames (I recall terraform.tfvars), you don't have to use the -var-file="secrets.tfvars" arg
- It's a good practice to commit terraform.tfvars.example (while gitignoring actual terraform.tfvars) with example variables (usually required ones, that don't have defaults in variables.tf). This file can be copied and renamed by individual users.