Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Nov 29 2024

tomek requested review of D14066: [native] Extract the buttons from the logged out modal.
Nov 29 2024, 3:10 AM
bartek updated the diff for D14036: [native][web] Show version unsupported modal when received use_new_flow on logout.

Apply hooks suggestion

Nov 29 2024, 3:10 AM
bartek added inline comments to D14036: [native][web] Show version unsupported modal when received use_new_flow on logout.
Nov 29 2024, 3:03 AM
bartek updated the diff for D14034: [lib] Handle use_new_flow for Identity V1 logout.

Add debug log to print error

Nov 29 2024, 3:02 AM
bartek accepted D14060: [native] add handler for staff to attempt backup restore.
Nov 29 2024, 2:59 AM
bartek accepted D14059: [native] upload User Keys backup when user is staff.
Nov 29 2024, 2:56 AM
bartek accepted D14056: [native] enable backup handler for staff.
Nov 29 2024, 2:55 AM
bartek updated the diff for D14031: [lib] Handle invalid CSAT in Identity Search context.

Rebase before landing

Nov 29 2024, 2:50 AM
bartek accepted D14047: [native] make it possible to test signing using Olm Account from User Keys.
Nov 29 2024, 2:20 AM

Nov 28 2024

angelika closed D14020: [native] Migrate ChatInputBar component to Reanimated v2 API.
Nov 28 2024, 5:13 PM
angelika closed D14019: [native] Use destructuring syntax in ChatInputBar component.
Nov 28 2024, 5:13 PM
angelika committed rCOMM5b611906f78c: [native] Migrate ChatInputBar component to Reanimated v2 API (authored by angelika).
[native] Migrate ChatInputBar component to Reanimated v2 API
Nov 28 2024, 5:13 PM
angelika committed rCOMM23509d20c70b: [native] Use destructuring syntax in ChatInputBar component (authored by angelika).
[native] Use destructuring syntax in ChatInputBar component
Nov 28 2024, 5:13 PM
angelika closed D14018: [native] Move render functions in ChatInputBar to function component.
Nov 28 2024, 5:13 PM
angelika closed D14017: [native] Migrate componentDidUpdate() in ChatInputBar to function component.
Nov 28 2024, 5:13 PM
angelika closed D14016: [native] Move keyboard handling in ChatInputBar to function component.
Nov 28 2024, 5:13 PM
angelika committed rCOMM1c062da482b6: [native] Move keyboard handling in ChatInputBar to function component (authored by angelika).
[native] Move keyboard handling in ChatInputBar to function component
Nov 28 2024, 5:13 PM
angelika committed rCOMM55d53200394a: [native] Move render functions in ChatInputBar to function component (authored by angelika).
[native] Move render functions in ChatInputBar to function component
Nov 28 2024, 5:13 PM
angelika committed rCOMMe1ddf7f20d6e: [native] Migrate componentDidUpdate() in ChatInputBar to function component (authored by angelika).
[native] Migrate componentDidUpdate() in ChatInputBar to function component
Nov 28 2024, 5:13 PM
angelika closed D14014: [native] Move edit message listeners set up in ChatInputBar to function component.
Nov 28 2024, 5:12 PM
angelika closed D14013: [native] Move navigation related callbacks in ChatInputBar to function component.
Nov 28 2024, 5:12 PM
angelika closed D14015: [native] Move join thread functions in ChatInputBar to function component.
Nov 28 2024, 5:12 PM
angelika committed rCOMM90213f49046c: [native] Move edit message listeners set up in ChatInputBar to function… (authored by angelika).
[native] Move edit message listeners set up in ChatInputBar to function…
Nov 28 2024, 5:12 PM
angelika committed rCOMM390453dc5912: [native] Move navigation related callbacks in ChatInputBar to function component (authored by angelika).
[native] Move navigation related callbacks in ChatInputBar to function component
Nov 28 2024, 5:12 PM
angelika committed rCOMMcba7ba6620d3: [native] Move join thread functions in ChatInputBar to function component (authored by angelika).
[native] Move join thread functions in ChatInputBar to function component
Nov 28 2024, 5:12 PM
angelika closed D14012: [native] Move text update and editing logic in ChatInputBar to function component.
Nov 28 2024, 5:12 PM
angelika closed D14011: [native] Move text input refs in ChatInputBar to function component.
Nov 28 2024, 5:12 PM
angelika committed rCOMM1d992bd69d6b: [native] Move text update and editing logic in ChatInputBar to function… (authored by angelika).
[native] Move text update and editing logic in ChatInputBar to function…
Nov 28 2024, 5:12 PM
angelika committed rCOMM3c5be31f62b3: [native] Move text input refs in ChatInputBar to function component (authored by angelika).
[native] Move text input refs in ChatInputBar to function component
Nov 28 2024, 5:12 PM
angelika closed D14010: [native] Move button expansion logic in ChatInputBar to function component.
Nov 28 2024, 5:12 PM
angelika closed D14009: [native] Move Reanimated definitions in ChatInputBar to function component.
Nov 28 2024, 5:12 PM
angelika committed rCOMM4af634331c67: [native] Move button expansion logic in ChatInputBar to function component (authored by angelika).
[native] Move button expansion logic in ChatInputBar to function component
Nov 28 2024, 5:12 PM
angelika committed rCOMM5931501647f8: [native] Move Reanimated definitions in ChatInputBar to function component (authored by angelika).
[native] Move Reanimated definitions in ChatInputBar to function component
Nov 28 2024, 5:12 PM
angelika closed D14008: [native] Move isExitingDuringEditMode in ChatInputBar to a ref in function component.
Nov 28 2024, 5:12 PM
angelika committed rCOMM1704349e4f67: [native] Move isExitingDuringEditMode in ChatInputBar to a ref in function… (authored by angelika).
[native] Move isExitingDuringEditMode in ChatInputBar to a ref in function…
Nov 28 2024, 5:12 PM
angelika closed D14007: [native] Move buttonsExpanded in ChatInputBar to function component.
Nov 28 2024, 5:12 PM
angelika committed rCOMMafbdd826c734: [native] Move buttonsExpanded in ChatInputBar to function component (authored by angelika).
[native] Move buttonsExpanded in ChatInputBar to function component
Nov 28 2024, 5:12 PM
angelika closed D14006: [native] Move text state in ChatInputBar to function component.
Nov 28 2024, 5:12 PM
angelika committed rCOMMc89b46e94e74: [native] Move text state in ChatInputBar to function component (authored by angelika).
[native] Move text state in ChatInputBar to function component
Nov 28 2024, 5:12 PM
bartek accepted D14061: [native] handle invalid CSAT in Backup authenticated API.

Nice, thanks!

Nov 28 2024, 10:34 AM
kamil published D14065: [native] regenerate backup on every password change for review.
Nov 28 2024, 9:10 AM
kamil published D14063: [native] allow password change only on primary device for review.
Nov 28 2024, 6:24 AM
kamil published D14062: [web] remove password change feature for review.
Nov 28 2024, 6:24 AM
kamil added inline comments to D14060: [native] add handler for staff to attempt backup restore.
Nov 28 2024, 6:19 AM
tomek added a comment to D14038: [native] Navigate from the QR screen to the restore screen.

Can we restyle the restore screen to look something like the registration navigator screens?

I'm not sure about this. A user enters the restore flow by going through the QR screen, which is a bit inconsistent with the registration flow (e.g. font size, alignment). I think that it would be better to follow the QR screen design so that the user doesn't experience inconsistency. We can also update the QR screen design to be consistent with the registration flow - I think this is the best solution.

Nov 28 2024, 6:15 AM
tomek requested review of D14064: [native] Make QR screen style consistent with the registration flow.
Nov 28 2024, 5:50 AM
kamil published D14061: [native] handle invalid CSAT in Backup authenticated API for review.
Nov 28 2024, 5:09 AM
bartek closed D13955: [lib] Add hook to log out on invalid CSAT.
Nov 28 2024, 3:31 AM
bartek committed rCOMM17ccb83971a5: [lib] Add hook to log out on invalid CSAT (authored by bartek).
[lib] Add hook to log out on invalid CSAT
Nov 28 2024, 3:31 AM
tomek added a comment to D14038: [native] Navigate from the QR screen to the restore screen.
  1. Can we avoid using the LoggedOutModal style for any of the screens in the navigator? It feels stylistically inconsistent to push a new screen that looks like what appears below the stack navigator.

Yeah, we can do that. In that case, I'd need to introduce new components instead of wrapping the old one.

Nov 28 2024, 3:15 AM
kamil accepted D14037: [native] Show version unsupported when opened QR screen.
Nov 28 2024, 1:34 AM
kamil added inline comments to D14056: [native] enable backup handler for staff.
Nov 28 2024, 1:19 AM

Nov 27 2024

ashoat accepted D14020: [native] Migrate ChatInputBar component to Reanimated v2 API.

Great work on this! The conversion from Reanimated 1 to Reanimated 2/3 appears perfect, and the changes between them are pretty unavoidable without introducing a bunch of unnecessary complexity

Nov 27 2024, 3:54 PM
ashoat added inline comments to D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.
Nov 27 2024, 3:12 PM
ashoat added inline comments to D14059: [native] upload User Keys backup when user is staff.
Nov 27 2024, 3:09 PM
ashoat added inline comments to D14056: [native] enable backup handler for staff.
Nov 27 2024, 3:06 PM
varun added inline comments to D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.
Nov 27 2024, 11:10 AM
kamil published D14060: [native] add handler for staff to attempt backup restore for review.
Nov 27 2024, 10:26 AM
kamil published D14059: [native] upload User Keys backup when user is staff for review.
Nov 27 2024, 10:22 AM
kamil published D14056: [native] enable backup handler for staff for review.
Nov 27 2024, 10:20 AM
kamil published D14058: [lib] create a hook to check if device is primary for review.
Nov 27 2024, 10:18 AM
ashoat added a comment to D14049: [lib][web][native] Redux store to persist latest backup info.
In D14049#391602, @tomek wrote:
In D14049#391563, @ashoat wrote:

Do we really need the migration? Won't it get merged with defaultState anyways?

In the past, we had some bugs caused by relying on the default state instead of the migration. They can happen in the following scenario:

  1. A new store is added without a migration
  2. A new migration is added that uses this store
  3. A user updates the app from before the 1st step

Then migration 2 fails.

Nov 27 2024, 9:23 AM
ashoat requested changes to D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.

Code looks good, but passing back for a screen recording... I'm not sure about the copy, and a recording would will help me iterate on it

Nov 27 2024, 9:21 AM
ashoat added a comment to D14038: [native] Navigate from the QR screen to the restore screen.

Thanks for the updated video!

Nov 27 2024, 9:16 AM
tomek accepted D14055: [web][native] add white frame around QR code.
Nov 27 2024, 7:28 AM
tomek accepted D14050: [lib][native] create action to set latest `backupID` on User Keys upload.
Nov 27 2024, 7:26 AM
tomek accepted D14048: [CommCoreModule] deprecate `computeBackupKey`.
Nov 27 2024, 7:22 AM
tomek accepted D14049: [lib][web][native] Redux store to persist latest backup info.
Nov 27 2024, 7:12 AM
bartek updated the diff for D14037: [native] Show version unsupported when opened QR screen.

Move check to deep link context. Use the usingRestoreFlow constant

Nov 27 2024, 5:29 AM
kamil published D14055: [web][native] add white frame around QR code for review.
Nov 27 2024, 3:52 AM
tomek accepted D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.
Nov 27 2024, 2:23 AM
tomek updated the summary of D14038: [native] Navigate from the QR screen to the restore screen.
Nov 27 2024, 2:12 AM
tomek added a comment to D14049: [lib][web][native] Redux store to persist latest backup info.
In D14049#391563, @ashoat wrote:

Do we really need the migration? Won't it get merged with defaultState anyways?

Nov 27 2024, 1:31 AM
bartek accepted D14046: [CommCoreModule] sign message with custom Olm Account.
Nov 27 2024, 1:31 AM

Nov 26 2024

varun requested review of D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.
Nov 26 2024, 10:36 PM
angelika requested review of D14020: [native] Migrate ChatInputBar component to Reanimated v2 API.
Nov 26 2024, 4:31 PM
tomek requested review of D14051: [native] Rename the QR sign-in navigator.
Nov 26 2024, 10:32 AM
ashoat added a comment to D14049: [lib][web][native] Redux store to persist latest backup info.

Do we really need the migration? Won't it get merged with defaultState anyways?

Nov 26 2024, 10:29 AM
ashoat added inline comments to D13986: [native] bottom sheet for exploring communities.
Nov 26 2024, 10:23 AM
varun added inline comments to D13986: [native] bottom sheet for exploring communities.
Nov 26 2024, 9:55 AM
tomek requested review of D14052: [native] Move QR and sign-in files around.
Nov 26 2024, 9:35 AM
tomek updated the diff for D14038: [native] Navigate from the QR screen to the restore screen.

Rebase

Nov 26 2024, 8:35 AM
tomek updated the diff for D14038: [native] Navigate from the QR screen to the restore screen.

Revert setting the flag

Nov 26 2024, 8:30 AM
tomek updated the summary of D14038: [native] Navigate from the QR screen to the restore screen.
Nov 26 2024, 8:28 AM
tomek updated the summary of D14038: [native] Navigate from the QR screen to the restore screen.
Nov 26 2024, 8:28 AM
tomek updated the diff for D14038: [native] Navigate from the QR screen to the restore screen.

Create a new screen with the restore flow

Nov 26 2024, 8:25 AM
tomek updated the diff for D13907: [native] Introduce a restore screen.

Rebase

Nov 26 2024, 8:23 AM
tomek updated the diff for D13906: [native] Update the logged out modal.

Rebase

Nov 26 2024, 8:22 AM
tomek updated the summary of D13906: [native] Update the logged out modal.
Nov 26 2024, 8:21 AM
tomek updated the summary of D13946: [native] Update the QR login screen to mention the primary device.
Nov 26 2024, 8:19 AM
tomek updated the diff for D13946: [native] Update the QR login screen to mention the primary device.

Rebase

Nov 26 2024, 8:17 AM
kamil published D14050: [lib][native] create action to set latest `backupID` on User Keys upload for review.
Nov 26 2024, 8:08 AM
bartek added inline comments to D14049: [lib][web][native] Redux store to persist latest backup info.
Nov 26 2024, 7:53 AM
kamil published D14049: [lib][web][native] Redux store to persist latest backup info for review.
Nov 26 2024, 7:53 AM
bartek accepted D14045: [CryptoModule] remove `CryptoAccountID`.
Nov 26 2024, 7:13 AM
bartek accepted D14044: [CryptoModule] store only pickled Olm Account in User Keys Backup.

Nit: Names are now a bit divergent: pickleAccountToString for account-only, and storeAsB64 for account+sessions but return types differ too. IMO storeAsB64 is misleading because Persist type isn't base64.

Nov 26 2024, 7:11 AM
kamil published D14048: [CommCoreModule] deprecate `computeBackupKey` for review.
Nov 26 2024, 6:45 AM
kamil published D14047: [native] make it possible to test signing using Olm Account from User Keys for review.
Nov 26 2024, 6:45 AM
kamil published D14046: [CommCoreModule] sign message with custom Olm Account for review.
Nov 26 2024, 6:45 AM
ashoat added a comment to D13992: [native][web] Handle invalid CSAT in input-state-containers.

Thanks for explaining your process!! That sounds very thorough :)

Nov 26 2024, 6:26 AM
First
Prev
Next