Split a function into two
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Dec 4 2023
Dec 4 2023
tomek retitled D10150: [keyserver] Introduce a function that allows fetching all the primary links from [keyserver] Fetch all the links when a viewer is a script viewer
tomek updated the summary of D10150: [keyserver] Introduce a function that allows fetching all the primary links.
tomek updated the diff for D10150: [keyserver] Introduce a function that allows fetching all the primary links.
tomek planned changes to D10150: [keyserver] Introduce a function that allows fetching all the primary links.
In D10150#295223, @ashoat wrote:This feels pretty messy. I'm not sure what the callstack looks like, but is it possible to introduce a second function for this (with shared code factored out) instead of overloading fetchPrimaryInviteLinks to handle two different scenarios?
tomek requested review of D10150: [keyserver] Introduce a function that allows fetching all the primary links.
Dec 1 2023
Dec 1 2023
tomek requested review of D10131: [keyserver] Change blob upload functions to return more usable results.
Nov 30 2023
Nov 30 2023
tomek requested review of D10099: [keyserver] Introduce a util function that generates invite link blob hash.
Rebase
Rebase
Use a param object instead of two args for hash and holder to avoid the confusion between them
Accepting without review. What procedure did you use to rename all the types?
Nov 29 2023
Nov 29 2023
on the first rehydration this value could be undefined
Is it also true for other values from the keyserverInfo? Should we also handle them somehow?
Nov 27 2023
Nov 27 2023
Is the default_role column nullable at this point?
tomek requested changes to D9978: [keyserver] Update usage of threads.default_role in validate-role-permissions.js.
Nov 24 2023
Nov 24 2023
tomek updated the diff for D9944: [keyserver] Block creating invite links for which an entry in Blob service already exists.
Use better error code
tomek updated the diff for D9960: [keyserver] Add a column to invite_links table with a blob holder.
Rebase
tomek updated the diff for D9940: [keyserver] Split blob encryption and upload into separate functions.
Rebase
Nov 23 2023
Nov 23 2023
tomek updated the diff for D9940: [keyserver] Split blob encryption and upload into separate functions.
Move encrypting inside try-catch block
tomek added inline comments to D9940: [keyserver] Split blob encryption and upload into separate functions.
Nov 21 2023
Nov 21 2023