Page MenuHomePhabricator
Feed Advanced Search

Mar 28 2024

kamil accepted D11419: [sqlite] implement C++ code to get synced metadata.
Mar 28 2024, 4:52 AM
kamil accepted D11418: [sqlite] implement C++ synced metadata store ops.
Mar 28 2024, 4:51 AM
kamil accepted D11417: [sqlite] add methods to operate on synced metadata table.
Mar 28 2024, 4:44 AM
kamil accepted D11416: [sqlite] add sync metadata table to sqlite.
Mar 28 2024, 4:14 AM
kamil requested changes to D11415: [lib] introduce SyncedMetadata store spec.
Mar 28 2024, 4:11 AM
kamil accepted D11414: [lib] introduce synced metadata types.
Mar 28 2024, 4:02 AM
kamil accepted D11369: [lib] Create a wrapper over dispatch.
Mar 28 2024, 3:54 AM
kamil accepted D11368: [native][web] Remove processing the ops from reducers.
Mar 28 2024, 3:52 AM
kamil accepted D11367: [lib] Handle processing of the ops.
Mar 28 2024, 3:49 AM

Mar 27 2024

kamil accepted D11392: [keyserver] Construct a new TunnelbrokerSocket when one closes.
Mar 27 2024, 12:35 AM
kamil accepted D11391: [keyserver] Track closed state in TunnelbrokerSocket.
Mar 27 2024, 12:28 AM
kamil accepted D11386: [web/native] Add signMessage to olmAPI.
Mar 27 2024, 12:27 AM
kamil accepted D11373: [web] Use shared worker crypto store in identity client provider.
Mar 27 2024, 12:26 AM
kamil accepted D11372: [web/native] Create tunnelbroker init message on connection.
Mar 27 2024, 12:26 AM

Mar 26 2024

kamil accepted D11385: [web] Pass platform details to worker.
Mar 26 2024, 9:08 AM

Mar 22 2024

kamil resigned from D9069: Schedule blob deletion on Android when large notifications arrives.
Mar 22 2024, 3:35 AM
kamil accepted D11355: [backup] Revoke holders of replaced log items.
Mar 22 2024, 3:32 AM
kamil accepted D11366: [lib] Introduce a handler that processes the ops.
Mar 22 2024, 3:30 AM
kamil accepted D11358: [native][web] Read integrity thread hashes from SQLite on app start.
Mar 22 2024, 3:28 AM
kamil accepted D11354: [web] Introduce a migration that adds an actualizedCalendarQuery.
Mar 22 2024, 3:26 AM

Mar 19 2024

kamil accepted D11339: [web/native] Add content outbound session to olmAPI.
Mar 19 2024, 8:59 AM
kamil accepted D11352: [web] Deprecate non-worker opaque wasm.
Mar 19 2024, 8:57 AM
kamil accepted D11351: [web] Migrate crypto store to shared worker.
Mar 19 2024, 8:55 AM
kamil accepted D11348: [web] Use crypto store and olm from shared worker.
Mar 19 2024, 8:35 AM
kamil accepted D11331: [web] Add QR auth handler logic.
Mar 19 2024, 6:33 AM
kamil accepted D11347: [web/native] Use olmAPI instead of `OlmSessionCreatorContext`.
Mar 19 2024, 6:11 AM
kamil accepted D11346: [lib][native] Call backup restore protocol after QR auth.
Mar 19 2024, 6:08 AM
kamil accepted D11344: [native][rust] Split download_backup to separate ct1 and ct2.
Mar 19 2024, 5:59 AM
kamil accepted D11332: [web][native] Encrypt QR auth messages with AES.
Mar 19 2024, 5:57 AM
kamil accepted D11281: [lib] Add an optional ID field to all the actions.
Mar 19 2024, 4:56 AM
kamil added inline comments to D11338: [web] olmAPI on shared worker.
Mar 19 2024, 4:35 AM

Mar 18 2024

kamil accepted D11330: [lib][native] Extract QR code to a spearate component.
Mar 18 2024, 8:11 AM
kamil accepted D11301: [native] Broadcast device list update and send backup key stub.
Mar 18 2024, 6:42 AM
kamil accepted D11343: [sqlite] [lib] refactor integrity reducer full state sync action type to use sqlite ops.

Can you add this diff to the stack?

Mar 18 2024, 6:25 AM
kamil accepted D11323: [lib] return ops from integrity store reducer.
Mar 18 2024, 6:24 AM
kamil accepted D11322: refactor integrity reducer starting state to use processStoreOps.
Mar 18 2024, 6:19 AM
kamil accepted D11247: [lib] Add integrity store ops.
Mar 18 2024, 6:16 AM
kamil accepted D11342: [web/native] Move notificationsSessionCreator to olmAPI.
Mar 18 2024, 6:11 AM
kamil accepted D11341: [web] Olm session creation between own devices.
Mar 18 2024, 6:09 AM
kamil accepted D11340: [web/native] Add getUserPublicKey to olmAPI.
Mar 18 2024, 5:58 AM
kamil accepted D11339: [web/native] Add content outbound session to olmAPI.
Mar 18 2024, 5:57 AM
kamil accepted D11338: [web] olmAPI on shared worker.
Mar 18 2024, 5:53 AM
kamil accepted D11326: [web] Persist web sessions.
Mar 18 2024, 5:26 AM
kamil accepted D11299: [web] Handle shared worker message sequentially.
Mar 18 2024, 5:15 AM
kamil accepted D11275: [web] Add identity client shared worker proxy.
Mar 18 2024, 3:54 AM
kamil closed D11314: [olm] implement tests to new error messages & message order.
Mar 18 2024, 1:50 AM
kamil committed rCOMM48e292e554bb: [olm] implement tests to new error messages & message order (authored by kamil).
[olm] implement tests to new error messages & message order
Mar 18 2024, 1:50 AM
kamil closed D11337: [olm] bump `@commapp/olm` version.
Mar 18 2024, 1:50 AM
kamil committed rCOMMa97986dad7f1: [olm] bump `@commapp/olm` version (authored by kamil).
[olm] bump `@commapp/olm` version
Mar 18 2024, 1:50 AM
kamil added inline comments to D11314: [olm] implement tests to new error messages & message order.
Mar 18 2024, 1:46 AM

Mar 15 2024

kamil accepted D11274: [web] Create identity client on shared worker.

Could you create a task, to after fully migrating Identitiy client to the worker to deprecate opaque on the main thread?

Mar 15 2024, 10:24 AM
kamil accepted D11273: [web] Make identity service client runnable on shared worker.
Mar 15 2024, 10:15 AM
kamil accepted D11272: [web] Add cryptoStore to shared worker.
Mar 15 2024, 10:10 AM
kamil accepted D11324: [web] Move worker database globals to worker-database.js.
Mar 15 2024, 10:01 AM
kamil published D11314: [olm] implement tests to new error messages & message order for review.
Mar 15 2024, 7:21 AM
kamil published D11337: [olm] bump `@commapp/olm` version for review.
Mar 15 2024, 5:54 AM
kamil planned changes to D11243: [CI] Clean on failure for Emscripten pipeline.
Mar 15 2024, 5:39 AM

Mar 14 2024

kamil accepted D11290: [native][web] Expose Device List RPCs to JS.
Mar 14 2024, 6:37 AM
kamil added a comment to D11312: [native] use short form for prekeys.

Can you link the diff where you update parsing prekeys when creating a session and land those two together? Now it's not possible to create a session between two native devices.

Mar 14 2024, 2:57 AM
kamil accepted D11312: [native] use short form for prekeys.

Can you link the diff where you update parsing prekeys when creating a session and land those two together? Now it's not possible to create a session between two native devices.

Mar 14 2024, 2:48 AM

Mar 13 2024

kamil requested changes to D11301: [native] Broadcast device list update and send backup key stub.
Mar 13 2024, 6:03 AM
kamil accepted D11296: [native] Notify primary device on registration finish.

Do we have some alternatives to detect that secondary device auth succeded other than isAuthorized from Tunnelbroker? Wondering if this is the best approach

Mar 13 2024, 5:58 AM
kamil accepted D11295: [native] Upload secondary device keys when added to list.
Mar 13 2024, 5:52 AM
kamil accepted D11294: [native] Update device list on QR code scaned.
Mar 13 2024, 5:36 AM
kamil accepted D11293: [lib] Add Tunnelbroker message types for QR code auth.
Mar 13 2024, 5:35 AM

Mar 12 2024

kamil requested changes to D11247: [lib] Add integrity store ops.

Putting back to your queue to address threadHash type

Mar 12 2024, 10:21 AM
kamil accepted D11309: [sqlite] implement processing integrity store ops on worker.
Mar 12 2024, 10:20 AM
kamil accepted D11307: [sqlite] Implement C++ code to get integrity store thread hashes.

Please fix Android build before landing

Mar 12 2024, 10:19 AM
kamil accepted D11306: [sqlite] implement C++ integrity store ops.

Make sure Android build passes before landing

Mar 12 2024, 10:18 AM
kamil accepted D11300: [sqlite] add methods to operate on integrity store table.

Looks good, there is one problem with thread_hash type - but let's discuss this in D11247 and then you can just update the type here

Mar 12 2024, 10:07 AM
kamil accepted D11298: [lib] Refactor integrity reducer to process threadStore ops with sqlite ops.

flow check. Not sure how to best test this right now. Might need to test later in diff stack

Mar 12 2024, 9:52 AM
kamil added a comment to D11287: [lib] refactor integrity reducer add new thread hashes to use sqlite ops.
In D11287#326127, @will wrote:

The reduceIntegrityStore function starts with:

if (
  action.type === logInActionTypes.success ||
  action.type === siweAuthActionTypes.success ||
  action.type === keyserverRegisterActionTypes.success ||
  action.type === fullStateSyncActionType ||
  (action.type === setClientDBStoreActionType &&
    !!action.payload.threadStore &&
    state.threadHashingStatus !== 'completed')
) {
  return { threadHashes: {}, threadHashingStatus: 'starting' };
} else if (action.type === keyserverAuthActionTypes.success) {
  return { ...state, threadHashingStatus: 'starting' };
}

These currently just return either the current state or an empty threadHashes object. Do we have to refactor this in anyway with sqlite ops or is it fine as is?

Mar 12 2024, 9:45 AM
kamil accepted D11287: [lib] refactor integrity reducer add new thread hashes to use sqlite ops.
Mar 12 2024, 9:42 AM
kamil accepted D11292: [lib] Expose isAuthorized property in Tunnelbroker context.
Mar 12 2024, 9:16 AM
kamil accepted D11291: [native][web] Expose Secondary device registration RPC to JS.

Looks good but when landing you could comment in ENG-7198 to use olmAPI here - or if the olmAPI is ready at the time of landing, use it here.

Mar 12 2024, 9:16 AM
kamil added 1 blocking reviewer(s) for D11290: [native][web] Expose Device List RPCs to JS: michal.

@michal is moving the Identity client to worker now so should review this code as well

Mar 12 2024, 9:02 AM
kamil requested changes to D11290: [native][web] Expose Device List RPCs to JS.

Looks good, just requesting changes to address my and @ashoat's comments

Mar 12 2024, 8:53 AM
kamil accepted D11284: [native][web] Queue new ops.
Mar 12 2024, 8:42 AM
kamil requested changes to D11281: [lib] Add an optional ID field to all the actions.

@tomek is off - going to request changes to clear our queues until he's back and able to respond to the question

Mar 12 2024, 8:15 AM
kamil added a comment to D11275: [web] Add identity client shared worker proxy.

Thanks for explaining that it would require weaker types and some any-casts. I'm curious what the other reviewers think about the two proposed approaches, and I'm also curious how expensive it might be to change the approach at this time.

Mar 12 2024, 8:14 AM

Mar 11 2024

kamil added a reviewer for D11274: [web] Create identity client on shared worker: marcin.

The reason the differences exist in this revision of this diff is that I wanted to use the same opaqueURL for both tab-JS-context and webworker-JS-context. But the corresponding JS files for these context are hosted in different places and so have different default origins for network calls.

Mar 11 2024, 5:32 AM
kamil requested changes to D11272: [web] Add cryptoStore to shared worker.
Mar 11 2024, 4:39 AM
kamil accepted D11280: [lib] Add a reducer that handles successful ops processing.
Mar 11 2024, 4:14 AM
kamil accepted D11279: [lib] Add an action representing a successful processing.
Mar 11 2024, 4:03 AM
kamil accepted D11259: [lib] Create a redux store where ops will be stored.
Mar 11 2024, 4:01 AM
kamil added a reviewer for D11247: [lib] Add integrity store ops: atul.
Mar 11 2024, 3:59 AM

Mar 7 2024

kamil closed D11266: [services] update `Cargo.lock` files.
Mar 7 2024, 4:52 AM
kamil committed rCOMM2d0910daee90: [services] update `Cargo.lock` files (authored by kamil).
[services] update `Cargo.lock` files
Mar 7 2024, 4:52 AM
kamil added a comment to D11259: [lib] Create a redux store where ops will be stored.
In D11259#325290, @inka wrote:

Can you explain why we don't want to persist ops? Wouldn't it be a problem if redux store got updated, but the app was closed before ops had the time to update the db?

Mar 7 2024, 4:30 AM
kamil requested changes to D11247: [lib] Add integrity store ops.
Mar 7 2024, 4:04 AM
kamil accepted D11249: [sqlite] Adds integrity store table.

Could you please form the stack with your diffs?

Mar 7 2024, 2:25 AM
kamil published D11266: [services] update `Cargo.lock` files for review.
Mar 7 2024, 2:16 AM
kamil closed D11241: [web] improve error handling in queries tests.
Mar 7 2024, 2:02 AM
kamil committed rCOMMe96e3fea7e85: [web] improve error handling in queries tests (authored by kamil).
[web] improve error handling in queries tests
Mar 7 2024, 2:02 AM
kamil closed D11242: [web] fix param names in `SQLiteQueryExecutor` types.
Mar 7 2024, 2:00 AM
kamil committed rCOMM4650f47a5651: [web] fix param names in `SQLiteQueryExecutor` types (authored by kamil).
[web] fix param names in `SQLiteQueryExecutor` types
Mar 7 2024, 2:00 AM

Mar 5 2024

kamil accepted D11233: Introduce changes to Session.cpp that allow to decrypt with session object alone.
Mar 5 2024, 7:24 AM
kamil accepted D11232: Introduce notifications crypto module to CommCoreModule.
Mar 5 2024, 7:16 AM
kamil published D11243: [CI] Clean on failure for Emscripten pipeline for review.
Mar 5 2024, 5:34 AM
kamil published D11242: [web] fix param names in `SQLiteQueryExecutor` types for review.
Mar 5 2024, 4:18 AM