Move some type changes from parent diff to this diff
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Mar 8 2023
Mar 8 2023
Lol, I've added dump.rdb to .git/info/exclude to workaround this. Glad that you fixed this
Hmm are we using usernames as an identifier? Ideally we use user IDs for that
atul updated the summary of D7009: [nix] Ensure that fd 3 is closed before we fork `redis-server` and `mariadbd`.
atul updated the diff for D7009: [nix] Ensure that fd 3 is closed before we fork `redis-server` and `mariadbd`.
reposition comment in mariadb-up-mac for symmetry
atul added inline comments to D7009: [nix] Ensure that fd 3 is closed before we fork `redis-server` and `mariadbd`.
atul updated the diff for D7009: [nix] Ensure that fd 3 is closed before we fork `redis-server` and `mariadbd`.
address feedback
atul added a comment to D7009: [nix] Ensure that fd 3 is closed before we fork `redis-server` and `mariadbd`.
Thanks for the explanation, make sense. I'll add a comment (and restart macOS build).
• jon requested changes to D7009: [nix] Ensure that fd 3 is closed before we fork `redis-server` and `mariadbd`.
• jon added a comment to D7009: [nix] Ensure that fd 3 is closed before we fork `redis-server` and `mariadbd`.
and we're doing some custom stuff instead of launchd
Harbormaster failed remote builds in B17194: Diff 23546 for D7009: [nix] Ensure that fd 3 is closed before we fork `redis-server` and `mariadbd`!
atul published D7009: [nix] Ensure that fd 3 is closed before we fork `redis-server` and `mariadbd` for review.
Fix compile errors
Can RobotextChatMessageInfoItem be edited?
In D6966#207758, @ashoat wrote:Can we avoid putting this in TextMessageInfo? I don't think it belongs there... and you're doing something pretty inconsistent with how we approached reactions.
Why didn't you put this in ChatMessageInfoItem? (In the future, when you are doing something different like this, please expect that your reviewers will call you out on it, and explain it ahead of time.)
Moved 'hasBeenEdited' property to 'ChatMessageInfoItem' type
ashoat added a comment to D7001: [Identity] Rename IdentityService service to IdentityKeyserverService.
This honestly feels like bike-shedding… I’d love if we could start out the work on this project with a focus on derisking the big risks, rather than renaming things
• jon added a comment to D7001: [Identity] Rename IdentityService service to IdentityKeyserverService.
identity.proto should probably be renamed as identity_keyserver.proto. As I would like to add the client <-> identity protobuf file as identity_client.proto, which is confusing as we refer to the keyserver protos as "identity_client" in some parts of the code base. In other words, align the naming with the "comm" defintion of terms and move away with the more general gRPC definition of terms.
• jon updated the summary of D7001: [Identity] Rename IdentityService service to IdentityKeyserverService.
• jon requested review of D7001: [Identity] Rename IdentityService service to IdentityKeyserverService.
Can we avoid putting this in TextMessageInfo? I don't think it belongs there... and you're doing something pretty inconsistent with how we approached reactions.
ashoat added inline comments to D6969: [web] Add to reducer logic handling community id picked in chat.
tomek added inline comments to D6975: [web] Add expanded and toggleExpanded to CommunityDrawerItemHandler type.
tomek added inline comments to D6929: [keyserver] Add a function to toggle the pin status of a message.
michal added inline comments to D6992: [web-db] implement proxy for promise-based connection with worker.
tomek added inline comments to D6970: [web] Add a selector for fetching picked community in Chat tab.
Change overflow: scroll to hidden. It has been decided that we want to "bias" towards the last item, hence the "flex-shrink: 0.5" for the last item
kamil added inline comments to D6970: [web] Add a selector for fetching picked community in Chat tab.
Responded to comments, made hasBeenEdited property read-only
Responded to comments, made read-only 'text' property
kamil added inline comments to D6969: [web] Add to reducer logic handling community id picked in chat.
marcin added 1 blocking reviewer(s) for D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start.: tomek.
marcin updated the diff for D6959: Run everuthing regarding NotificationsCryptoModule with native Android Accessible.
Rebase before landing
marcin updated the diff for D6980: Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash".
Rebase before landing
bartek accepted D6919: Remove relevant notification from notifications center when receiving rescind in NSE.
The semaphore dispatch trick looks good.
The title is somewhat misleading, but mostly the fault of Webpack docs. Before this diff, the polyfills were not included. After this diff, each of these is set to the empty object (I think)
Mar 7 2023
Mar 7 2023
ashoat added reviewers for D6989: [web-db] copy `sql-wasm.wasm` from node modules to `dist`: atul, ashoat.
varun added a comment to D6982: [lib] Add deviceTypes constant for enumerating all valid mobile device types.
oh nvm, i’ll delete my comment