Address code review feedback
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Mar 13 2023
Mar 13 2023
Address code review feedback
marcin added inline comments to D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start..
Regarding all naming issues (applies to the whole stack), I've created a Notion doc that clarifies the names
Rebase
Remove unnnecessary div
marcin requested review of D7058: Use initial notifications from queue rather than from launch options.
In D6963#208218, @ginsu wrote:I think we should consider if we also need shimUnsupportedMessageInfo and unshimMessageInfo. These functions will help us support older native clients that haven't been updated yet.
Responded to comments
Replaced by D6994
LGTM, Works with my changes. Thank you for taking care of this!
ginsu requested review of D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
• jon added inline comments to D7052: [direnv] Redirect `use flake` to `/dev/null` if `COMM_NIX_LOGGING_LEVEL` is "none".
atul added inline comments to D7051: [keyserver] Send `SIGNED_IDENTITY_KEYS_BLOB` request to client if data missing in DB.
Mar 12 2023
Mar 12 2023
fix..
If we're fully deprecating non-Nix workflow we can probably add cmake-lint to Nix and bring back this diff?
atul updated the test plan for D7048: [web] Use `signedIdentityKeysBlobSelector` in `SIWELoginForm`.
atul updated the test plan for D7047: [web] Use `signedIdentityKeysBlobSelector` in `TraditionalLoginForm`.
update after fix + rebase
atul updated the diff for D7047: [web] Use `signedIdentityKeysBlobSelector` in `TraditionalLoginForm`.
fix signedIdentityKeysBlobSelector after testing
atul updated the test plan for D7047: [web] Use `signedIdentityKeysBlobSelector` in `TraditionalLoginForm`.
atul published D7047: [web] Use `signedIdentityKeysBlobSelector` in `TraditionalLoginForm` for review.
ashoat added inline comments to D7046: [lib] Add test of ENS avatar set to NFT which is an SVG data URI.
with the data URI I don't think it really matters
Thanks for including unit tests
Some questions inline
ashoat requested review of D7039: [lib] Rename getCachedEntryForAddress to getCachedNameEntryForAddress.
Mar 11 2023
Mar 11 2023
atul updated the diff for D7036: [web] Introduce `getSignedIdentityKeysBlobSelector(...)` to generate `getSignedIdentityKeysBlob(...)`.
rebase and land
atul updated the test plan for D7036: [web] Introduce `getSignedIdentityKeysBlobSelector(...)` to generate `getSignedIdentityKeysBlob(...)`.
atul added a comment to D7036: [web] Introduce `getSignedIdentityKeysBlobSelector(...)` to generate `getSignedIdentityKeysBlob(...)`.
See if ClientClientResponse for serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB is correctly constructed and received by keyserver.
land
See if ClientClientResponse for serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB is properly constructed and received by keyserver.
atul added inline comments to D7035: [native] Implement `getSignedIdentityKeysBlob(...)` for `native`.
include call to commCoreModule.initializeCryptoAccount(...)
rebase and land
Haven't done this yet, will test before landing.