Page MenuHomePhabricator
Feed All Stories

Mar 16 2023

ashoat closed D7084: [native] Remove length check when unpickling.
Mar 16 2023, 2:01 PM
ashoat committed rCOMMdbb75162174c: [native] Remove length check when unpickling (authored by ashoat).
[native] Remove length check when unpickling
Mar 16 2023, 2:01 PM
ginsu attached a referenced file: F429919: Screenshot 2023-03-16 at 4.51.18 PM.png.
Mar 16 2023, 2:01 PM
ginsu attached a referenced file: F429918: Screenshot 2023-03-16 at 4.50.55 PM.png.
Mar 16 2023, 2:01 PM
ginsu attached a referenced file: F429916: Screenshot 2023-03-16 at 4.50.46 PM.png.
Mar 16 2023, 2:01 PM
ginsu updated the summary of D7067: [native] render user avatars in chat screen.
Mar 16 2023, 2:01 PM
atul accepted D7086: [lib] Add message type to "content must be defined" errors.
Mar 16 2023, 2:00 PM
ashoat published D7086: [lib] Add message type to "content must be defined" errors for review.
Mar 16 2023, 2:00 PM
atul accepted D7085: [native] Add a C++ MessageSpec for SidebarSource.
Mar 16 2023, 2:00 PM
ashoat requested review of D7085: [native] Add a C++ MessageSpec for SidebarSource.
Mar 16 2023, 1:59 PM
ginsu updated the diff for D7067: [native] render user avatars in chat screen.

only reduce the width of non viewer-composed messages as well as all multimedia messages

Mar 16 2023, 1:55 PM
ashoat added inline comments to D6963: [lib] Added new MessageSpec for editing messages.
Mar 16 2023, 1:47 PM
varun added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 16 2023, 1:42 PM
atul added a reviewer for D7061: [lib] Introduce combined padding interface: tomek.

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

Mar 16 2023, 1:37 PM
atul added a reviewer for D7060: [lib] Introduce superblock padding: tomek.

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

Mar 16 2023, 1:37 PM
atul added a comment to D7059: [lib] Introduce PKCS#7 padding.

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

Mar 16 2023, 1:36 PM
atul added a reviewer for D7059: [lib] Introduce PKCS#7 padding: tomek.
Mar 16 2023, 1:36 PM
atul accepted D7080: [lib] Don't mention GENESIS in chat creation notifs.
Mar 16 2023, 12:56 PM
atul accepted D7079: [lib] Don't refer to children of GENESIS as channels.
Mar 16 2023, 12:56 PM
atul accepted D7084: [native] Remove length check when unpickling.
Mar 16 2023, 12:55 PM
atul published D7084: [native] Remove length check when unpickling for review.
Mar 16 2023, 12:55 PM
varun requested changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 16 2023, 12:41 PM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 16 2023, 11:34 AM
ashoat added a comment to D7083: Amended Account & Session types..

@anunay also talked about adding some JS tests, but we can sequence that later

Mar 16 2023, 11:11 AM
ashoat requested changes to D7083: Amended Account & Session types..

We'll also need to update:

Mar 16 2023, 11:11 AM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Prune stale dependencies

Mar 16 2023, 10:30 AM
Harbormaster failed remote builds in B17363: Diff 23789 for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm!
Mar 16 2023, 9:44 AM
jon retitled D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm from [comm-opaque] Create opaque facade for usage in Comm to [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 16 2023, 9:41 AM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Also assert that session_key was set in test

Mar 16 2023, 9:37 AM
anunay requested review of D7083: Amended Account & Session types..
Mar 16 2023, 9:32 AM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 16 2023, 9:31 AM
jon requested review of D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 16 2023, 9:22 AM
jon planned changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 16 2023, 9:16 AM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Remove sever_setup from constructors

Mar 16 2023, 9:15 AM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Use opaque 2.0, remove server setup

Mar 16 2023, 9:12 AM
ginsu added a comment to D7067: [native] render user avatars in chat screen.

Open to decreasing media width

Mar 16 2023, 8:42 AM
atul accepted D7078: [lib] Pass threadType and parentThreadID to alwaysDisplayShortName ThreadEntity.
Mar 16 2023, 8:23 AM
atul accepted D7071: [keyserver] Fix update-geoip call in Docker environment.
Mar 16 2023, 8:22 AM
atul committed rCOMMccb5daf8d543: Bump activesupport from 6.1.7.1 to 6.1.7.3 in /native (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump activesupport from 6.1.7.1 to 6.1.7.3 in /native
Mar 16 2023, 8:14 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D7032: [desktop] Handle autoUpdate errors.
Mar 16 2023, 7:47 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMe37c0d6f5d79: [desktop] Handle autoUpdate errors (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[desktop] Handle autoUpdate errors
Mar 16 2023, 7:47 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D7030: [web] Use notifPermissionAlertInfo.
Mar 16 2023, 7:45 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMabde466ef6fe: [web] Use notifPermissionAlertInfo (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web] Use notifPermissionAlertInfo
Mar 16 2023, 7:45 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D7029: [native] Move NotifPermissionAlertInfo to lib.
Mar 16 2023, 7:45 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM350edf6e7f6d: [native] Move NotifPermissionAlertInfo to lib (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[native] Move NotifPermissionAlertInfo to lib
Mar 16 2023, 7:45 AM
michal updated the test plan for D7029: [native] Move NotifPermissionAlertInfo to lib.
Mar 16 2023, 5:23 AM
michal updated the diff for D7030: [web] Use notifPermissionAlertInfo.

Rebase

Mar 16 2023, 5:21 AM
ashoat closed D7072: [landing][web] Migrate from assets-webpack-plugin to webpack-manifest-plugin.
Mar 16 2023, 3:59 AM
ashoat committed rCOMM731fe43071a3: [landing][web] Migrate from assets-webpack-plugin to webpack-manifest-plugin (authored by ashoat).
[landing][web] Migrate from assets-webpack-plugin to webpack-manifest-plugin
Mar 16 2023, 3:59 AM
ashoat closed D7074: [lib][keyserver] Update reaction permission checks to check REACT_TO_MESSAGE.
Mar 16 2023, 3:59 AM
ashoat committed rCOMMc65b067cd70a: [lib][keyserver] Update reaction permission checks to check REACT_TO_MESSAGE (authored by ashoat).
[lib][keyserver] Update reaction permission checks to check REACT_TO_MESSAGE
Mar 16 2023, 3:59 AM
ashoat closed D7073: [lib][keyserver] Introduce new threadPermissions types for reactions.
Mar 16 2023, 3:59 AM
ashoat committed rCOMM84b7cc6a4472: [lib][keyserver] Introduce new threadPermissions types for reactions (authored by ashoat).
[lib][keyserver] Introduce new threadPermissions types for reactions
Mar 16 2023, 3:59 AM
michal accepted D7072: [landing][web] Migrate from assets-webpack-plugin to webpack-manifest-plugin.

Looks good to me

Mar 16 2023, 2:59 AM
bartek accepted D7075: [keyserver] Add natural library for stemming and removing stopwords.
Mar 16 2023, 1:05 AM

Mar 15 2023

jon planned changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

i'm a little confused why we're moving config.rs and constants.rs into this cargo project. they seem pretty specific to the identity service.

Mar 15 2023, 9:04 PM
ginsu added inline comments to D7067: [native] render user avatars in chat screen.
Mar 15 2023, 5:25 PM
ashoat added a comment to D7067: [native] render user avatars in chat screen.

Open to decreasing media width

Mar 15 2023, 5:21 PM
ginsu attached a referenced file: F428875: 336223399_740379237747150_8312429542900821292_n.jpg.
Mar 15 2023, 5:16 PM
ginsu attached a referenced file: F428877: 336353513_590716002715617_5037247747435841645_n.jpg.
Mar 15 2023, 5:16 PM
ginsu attached a referenced file: F428879: 336162309_908146963557437_5514534208953352892_n.jpg.
Mar 15 2023, 5:16 PM
ginsu added a comment to D7067: [native] render user avatars in chat screen.

I feel like we should still reduce the width for viewer-composed multimedia messages so all the multimedia messages have a consistently smaller size,

Mar 15 2023, 5:15 PM
ginsu attached a referenced file: F428871: Screenshot 2023-03-15 at 7.38.28 PM.png.
Mar 15 2023, 5:01 PM
ginsu planned changes to D7067: [native] render user avatars in chat screen.
Mar 15 2023, 5:01 PM
atul closed D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.
Mar 15 2023, 4:35 PM
atul committed rCOMM734df39d7857: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response (authored by atul).
[keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response
Mar 15 2023, 4:35 PM
atul added inline comments to D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.
Mar 15 2023, 4:32 PM
atul updated the diff for D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.

rebase before landing

Mar 15 2023, 4:32 PM
atul added inline comments to D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.
Mar 15 2023, 4:24 PM
atul closed D7070: [web] Add `CryptoStore` to `persistConfig.whitelist`.
Mar 15 2023, 4:20 PM
atul committed rCOMM6bfaf0746b8f: [web] Add `CryptoStore` to `persistConfig.whitelist` (authored by atul).
[web] Add `CryptoStore` to `persistConfig.whitelist`
Mar 15 2023, 4:20 PM
ashoat added inline comments to D7067: [native] render user avatars in chat screen.
Mar 15 2023, 4:18 PM
atul updated the diff for D7070: [web] Add `CryptoStore` to `persistConfig.whitelist`.

rebase and land

Mar 15 2023, 4:12 PM
atul closed D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.
Mar 15 2023, 3:48 PM
atul committed rCOMM61f34545c837: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();` (authored by atul).
[web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`
Mar 15 2023, 3:48 PM
atul updated the diff for D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.

extract useSignedIdentityKeysBlob hook to cut repetition

Mar 15 2023, 3:34 PM
ginsu added inline comments to D7067: [native] render user avatars in chat screen.
Mar 15 2023, 2:27 PM
ginsu updated the summary of D7067: [native] render user avatars in chat screen.
Mar 15 2023, 2:26 PM
ginsu attached a referenced file: F428737: Screenshot 2023-03-15 at 4.06.49 PM.png.
Mar 15 2023, 2:26 PM
ginsu attached a referenced file: F428736: Screenshot 2023-03-15 at 2.13.21 PM.png.
Mar 15 2023, 2:26 PM
ginsu updated the summary of D7067: [native] render user avatars in chat screen.
Mar 15 2023, 2:26 PM
ginsu updated the diff for D7067: [native] render user avatars in chat screen.

fix maxWidth for chat bubble so it's not poking out anymore (see test plan for visulization)

Mar 15 2023, 2:17 PM
ashoat accepted D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.
Mar 15 2023, 1:54 PM
ashoat accepted D7069: [native] render the rest of the user avatars.

Seems uncontroversial

Mar 15 2023, 1:53 PM
ashoat accepted D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.
Mar 15 2023, 1:51 PM
atul updated the test plan for D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.
Mar 15 2023, 1:45 PM
atul published D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response for review.

This is the last diff in the stack that I planned on putting up Monday/Tuesday, but ran into issues with D7081. Going to do some additional testing before landing to be extra careful.

Mar 15 2023, 1:43 PM
atul updated the diff for D7070: [web] Add `CryptoStore` to `persistConfig.whitelist`.

rebase

Mar 15 2023, 1:16 PM
atul updated the summary of D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.
Mar 15 2023, 1:13 PM
atul updated the summary of D7070: [web] Add `CryptoStore` to `persistConfig.whitelist`.
Mar 15 2023, 1:12 PM
atul updated the test plan for D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.
Mar 15 2023, 1:12 PM
atul published D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();` for review.
Mar 15 2023, 1:10 PM
ashoat requested review of D7079: [lib] Don't refer to children of GENESIS as channels.
Mar 15 2023, 12:35 PM
ashoat requested review of D7080: [lib] Don't mention GENESIS in chat creation notifs.
Mar 15 2023, 12:35 PM
ashoat requested review of D7078: [lib] Pass threadType and parentThreadID to alwaysDisplayShortName ThreadEntity.
Mar 15 2023, 12:33 PM
varun requested changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 15 2023, 12:29 PM
varun added a comment to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

i'm a little confused why we're moving config.rs and constants.rs into this cargo project. they seem pretty specific to the identity service. if we decide we want to store the secret key in a different location, it feels awkward that we'd have to modify a library that the identity service consumes rather than the service's own config

Mar 15 2023, 12:29 PM
ashoat added a comment to D7017: [web] Added displaying 'Labels' to InlineEngagment.

Thanks!! Can you send that over to Ted on the design team to make sure he approves of the changes to FailedSend? (It's worth mentioning to Ted that it's not possible for both FailedSend and the edited label to appear at the same time.)

Mar 15 2023, 12:24 PM
kuba added a comment to D7017: [web] Added displaying 'Labels' to InlineEngagment.

Can you share an updated screenshot?

Mar 15 2023, 12:16 PM
ashoat added a comment to D7067: [native] render user avatars in chat screen.

Hmm, not sure if that's an issue or not. I think it might be best to try using things like paddingLeft / marginLeft instead of left and position: 'absolute'... worried that border miscalculations can lead to issues, but not immediately sure what sort of concrete issues

Mar 15 2023, 12:14 PM