Tablet / mobile screenshots have buttons with text that doesn't appear vertically centered. Can we look into that and ideally resolve it before landing?
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
All Stories
Jun 1 2023
Makes sense to me, but would be great to get @kuba to take a look and test it to make sure it doesn't break the edit message use case focus-trap was introduced to handle!
Just some nits, not a full review. This one is pretty complicated, so would appreciate a detailed review by one of the listed reviewers!
Ah – makes sense, thanks for explaining @inka!
Curious for your thoughts on the inline comments. I think it might be good to move await getDeviceID out so it's not called on every Websocket initialization
Use SORT_KEY
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
JS looks good. Rust changes look simple but I'm not clear on how all of them connect to the JS. Might be good to add a reviewer who has context on that part of the codebase, but defer to @jon
Rebase
In D7981#237198, @ashoat wrote:What happens on a refresh? Wondering if the results get "replaced" after the load is complete, or if they get "merged"
Also wondering what happens if there are multiple pages of results loaded and a refresh occurs. Will the refresh "reset" to only showing one page of results? Or will the refresh only refresh the second page of results, or something like that?
May 31 2023
Rebase on master and feedback in other diffs
Rebase on previous changes
Rebase on master
Address feedback
Apply feedback, rebase on master
Rebase on master