Page MenuHomePhorge
Feed All Stories

Jun 1 2023

ashoat closed D8049: [native] Default to ENS avatar for users that have one.
Jun 1 2023, 6:52 PM
ashoat closed D8048: [native] Introduce avatarData state to hold pending avatar in AvatarSelection.
Jun 1 2023, 6:52 PM
ashoat closed D8047: [native] Make EditUserAvatar component conditionally navigate to registration screens.
Jun 1 2023, 6:52 PM
ashoat committed rCOMMfd1cec1c4e0a: [native] Default to ENS avatar for users that have one.
Jun 1 2023, 6:52 PM
ashoat committed rCOMM408cea282dc6: [native] Introduce avatarData state to hold pending avatar in AvatarSelection.
Jun 1 2023, 6:52 PM
ashoat closed D8046: [native] Construct synthetic UserInfo to pass to EditUserAvatar.
Jun 1 2023, 6:52 PM
ashoat committed rCOMM27ebf48a0caa: [native] Make EditUserAvatar component conditionally navigate to registration….
Jun 1 2023, 6:52 PM
ashoat committed rCOMM58b5465af053: [native] Construct synthetic UserInfo to pass to EditUserAvatar.
Jun 1 2023, 6:52 PM
ashoat closed D8045: [lib] Introduce new GenericUserInfoWithAvatar type.
Jun 1 2023, 6:52 PM
ashoat committed rCOMM33be0a69d6ae: [lib] Introduce new GenericUserInfoWithAvatar type.
Jun 1 2023, 6:52 PM
ashoat closed D8044: [native] Introduce new RegistrationUserAvatarCameraModal screen for registration flow.
Jun 1 2023, 6:52 PM
ashoat committed rCOMMa7453042ae47: [native] Introduce new RegistrationUserAvatarCameraModal screen for….
Jun 1 2023, 6:52 PM
ashoat closed D8043: [native] Introduce new EmojiAvatarSelection screen for registration flow.
Jun 1 2023, 6:52 PM
ashoat closed D8042: [native] Replace savedEmojiAvatarSelector with savedEmojiAvatarFunc.
Jun 1 2023, 6:52 PM
ashoat committed rCOMM5081dfc4cdb9: [native] Introduce new EmojiAvatarSelection screen for registration flow.
Jun 1 2023, 6:52 PM
ashoat committed rCOMM59eb11c6dda0: [native] Replace savedEmojiAvatarSelector with savedEmojiAvatarFunc.
Jun 1 2023, 6:52 PM
ashoat closed D8041: [native] Introduce RegistrationMode in EditUserAvatarProvider.
Jun 1 2023, 6:51 PM
ashoat committed rCOMM3c9aefcd99b3: [native] Introduce RegistrationMode in EditUserAvatarProvider.
Jun 1 2023, 6:51 PM
atul accepted D8047: [native] Make EditUserAvatar component conditionally navigate to registration screens.
Jun 1 2023, 6:35 PM
atul accepted D8046: [native] Construct synthetic UserInfo to pass to EditUserAvatar.
Jun 1 2023, 6:35 PM
atul accepted D8048: [native] Introduce avatarData state to hold pending avatar in AvatarSelection.
Jun 1 2023, 6:23 PM
atul accepted D8049: [native] Default to ENS avatar for users that have one.
Jun 1 2023, 6:23 PM
atul accepted D8044: [native] Introduce new RegistrationUserAvatarCameraModal screen for registration flow.
Jun 1 2023, 6:22 PM
atul accepted D8043: [native] Introduce new EmojiAvatarSelection screen for registration flow.
Jun 1 2023, 6:21 PM
atul accepted D8045: [lib] Introduce new GenericUserInfoWithAvatar type.
Jun 1 2023, 6:21 PM
ashoat added a comment to D8039: [landing] add feedback text to subscription form component.

Tablet / mobile screenshots have buttons with text that doesn't appear vertically centered. Can we look into that and ideally resolve it before landing?

Jun 1 2023, 6:18 PM
ashoat accepted D8053: [web] Escape focus trap when an outside node is clicked.

Makes sense to me, but would be great to get @kuba to take a look and test it to make sure it doesn't break the edit message use case focus-trap was introduced to handle!

Jun 1 2023, 6:17 PM
atul accepted D8042: [native] Replace savedEmojiAvatarSelector with savedEmojiAvatarFunc.
Jun 1 2023, 6:15 PM
ashoat added a comment to D8027: [web] Scrolling to the edited message when it overflows.

Just some nits, not a full review. This one is pretty complicated, so would appreciate a detailed review by one of the listed reviewers!

Jun 1 2023, 6:15 PM
atul accepted D8041: [native] Introduce RegistrationMode in EditUserAvatarProvider.
Jun 1 2023, 6:13 PM
atul accepted D8055: [landing] rename asset to imageAsset.
Jun 1 2023, 6:11 PM
atul retitled D8054: [landing] remove deprecated info blocks from [landing] remove depricated info blocks
Jun 1 2023, 6:10 PM
atul accepted D8054: [landing] remove deprecated info blocks.
Jun 1 2023, 6:09 PM
atul accepted D8039: [landing] add feedback text to subscription form component.
Jun 1 2023, 6:09 PM
atul accepted D8038: [landing] add feature cards to competitor comparison.
Jun 1 2023, 6:07 PM
atul accepted D8034: [landing] introduce competitor comparison.
Jun 1 2023, 6:06 PM
ashoat accepted D8035: [web][fix] Fixed cursor issue in the message editing.
Jun 1 2023, 6:05 PM
ginsu requested review of D8055: [landing] rename asset to imageAsset.
Jun 1 2023, 5:31 PM
ashoat added 1 blocking reviewer(s) for D7981: [web] Don't hide pinned messages on reload: rohan.

Ah – makes sense, thanks for explaining @inka!

Jun 1 2023, 5:25 PM
ginsu requested review of D8054: [landing] remove deprecated info blocks.
Jun 1 2023, 5:23 PM
ginsu updated the summary of D8039: [landing] add feedback text to subscription form component.
Jun 1 2023, 5:10 PM
rohan requested review of D8053: [web] Escape focus trap when an outside node is clicked.
Jun 1 2023, 4:34 PM
ashoat requested changes to D8052: [Keyserver] Use olm identity key for tunnelbroker connection.

Curious for your thoughts on the inline comments. I think it might be good to move await getDeviceID out so it's not called on every Websocket initialization

Jun 1 2023, 3:41 PM
ashoat accepted D8051: [web] Fix preloading blob service URIs.
Jun 1 2023, 2:58 PM
ashoat accepted D8050: [web] Preload encrypted media.

Two concerns:

Jun 1 2023, 2:58 PM
jon requested review of D8052: [Keyserver] Use olm identity key for tunnelbroker connection.
Jun 1 2023, 2:29 PM
jon closed D7801: [Tunnelbroker] Remove usages of unwrap and expect.
Jun 1 2023, 2:15 PM
jon closed D7800: [Tunnelbroker] Refactor connection lifetimes into session object.
Jun 1 2023, 2:15 PM
jon committed rCOMM9372f4589dfc: [Tunnelbroker] Remove usages of unwrap and expect.
Jun 1 2023, 2:15 PM
jon committed rCOMMe9209308664f: [Tunnelbroker] Refactor connection lifetimes into session object.
Jun 1 2023, 2:15 PM
jon closed D7799: [Tunnelbroker] Initial message persistence.
Jun 1 2023, 2:15 PM
jon committed rCOMMfadf7a78b5bf: [Tunnelbroker] Initial message persistence.
Jun 1 2023, 2:15 PM
marcin closed D7860: Handle client response to initial notifications encrypted message request.
Jun 1 2023, 1:55 PM
marcin committed rCOMMa1fd590313e8: Handle client response to initial notifications encrypted message request.
Jun 1 2023, 1:55 PM
marcin closed D7858: Add initial notifications encrypted message generator to client responses selector on native.
Jun 1 2023, 1:55 PM
marcin closed D7853: Create new olm session during invalidated cookie resolution.
Jun 1 2023, 1:55 PM
marcin committed rCOMMbc9f1072d61f: Add initial notifications encrypted message generator to client responses….
Jun 1 2023, 1:55 PM
marcin committed rCOMM71a5db08b388: Create new olm session during invalidated cookie resolution.
Jun 1 2023, 1:55 PM
marcin closed D7657: Establish olm notifs session on both sides during registration.
Jun 1 2023, 1:55 PM
marcin closed D7669: Establish olm notifs sessions during siwe account creation.
Jun 1 2023, 1:55 PM
marcin committed rCOMM7cbc1822445f: Establish olm notifs session on both sides during registration.
Jun 1 2023, 1:55 PM
marcin committed rCOMM836bc26762dd: Establish olm notifs sessions during siwe account creation.
Jun 1 2023, 1:55 PM
marcin closed D7654: Establish olm sessions for notifs on both sides during log-in.
Jun 1 2023, 1:54 PM
marcin committed rCOMMcf0d9b15c2a2: Establish olm sessions for notifs on both sides during log-in.
Jun 1 2023, 1:54 PM
inka added inline comments to D8027: [web] Scrolling to the edited message when it overflows.
Jun 1 2023, 1:39 PM
inka added inline comments to D8027: [web] Scrolling to the edited message when it overflows.
Jun 1 2023, 1:22 PM
jon updated the diff for D7799: [Tunnelbroker] Initial message persistence.

Use SORT_KEY

Jun 1 2023, 1:17 PM
marcin updated the diff for D7860: Handle client response to initial notifications encrypted message request.

Rebase before landing

Jun 1 2023, 1:11 PM
marcin updated the diff for D7858: Add initial notifications encrypted message generator to client responses selector on native.

Rebase before landing

Jun 1 2023, 1:09 PM
marcin updated the diff for D7853: Create new olm session during invalidated cookie resolution.

Rebase before landing

Jun 1 2023, 1:09 PM
marcin updated the diff for D7669: Establish olm notifs sessions during siwe account creation.

Rebase before landing

Jun 1 2023, 1:08 PM
marcin updated the diff for D7657: Establish olm notifs session on both sides during registration.

Rebase before landing

Jun 1 2023, 1:08 PM
marcin updated the diff for D7654: Establish olm sessions for notifs on both sides during log-in.

Rebase before landing

Jun 1 2023, 1:07 PM
ashoat accepted D7702: [Keyserver] Introduce tunnelbroker types.

JS looks good. Rust changes look simple but I'm not clear on how all of them connect to the JS. Might be good to add a reviewer who has context on that part of the codebase, but defer to @jon

Jun 1 2023, 1:03 PM
kuba added inline comments to D8027: [web] Scrolling to the edited message when it overflows.
Jun 1 2023, 12:58 PM
kuba planned changes to D5463: [web] Call searchUsers in chat composer.
Jun 1 2023, 12:50 PM
kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Rebase

Jun 1 2023, 10:45 AM
kuba added inline comments to D8035: [web][fix] Fixed cursor issue in the message editing.
Jun 1 2023, 9:53 AM
inka added a comment to D7981: [web] Don't hide pinned messages on reload.

What happens on a refresh? Wondering if the results get "replaced" after the load is complete, or if they get "merged"

Also wondering what happens if there are multiple pages of results loaded and a refresh occurs. Will the refresh "reset" to only showing one page of results? Or will the refresh only refresh the second page of results, or something like that?

Jun 1 2023, 9:20 AM
inka added a reviewer for D7981: [web] Don't hide pinned messages on reload: rohan.
Jun 1 2023, 9:12 AM
InkaSokolowska closed D7955: [native] Change border radius of filled-in input fields.
Jun 1 2023, 9:09 AM
InkaSokolowska committed rCOMM874faf41d97a: [native] Change border radius of filled-in input fields.
Jun 1 2023, 9:09 AM
InkaSokolowska closed D7954: [web] Change border radius of filled-in input fields.
Jun 1 2023, 9:09 AM
InkaSokolowska committed rCOMM0df0241c3258: [web] Change border radius of filled-in input fields.
Jun 1 2023, 9:09 AM
kamil published D8040: [lib] limit report size to 200MB for review.
Jun 1 2023, 8:26 AM
bartek published D8051: [web] Fix preloading blob service URIs for review.
Jun 1 2023, 7:17 AM
bartek published D8050: [web] Preload encrypted media for review.
Jun 1 2023, 7:17 AM

May 31 2023

varun added inline comments to D7799: [Tunnelbroker] Initial message persistence.
May 31 2023, 10:26 PM
jon added inline comments to D7799: [Tunnelbroker] Initial message persistence.
May 31 2023, 10:11 PM
jon updated the diff for D7801: [Tunnelbroker] Remove usages of unwrap and expect.

Rebase on master and feedback in other diffs

May 31 2023, 10:10 PM
jon updated the diff for D7800: [Tunnelbroker] Refactor connection lifetimes into session object.

Rebase on previous changes

May 31 2023, 10:09 PM
jon updated the diff for D7799: [Tunnelbroker] Initial message persistence.

Rebase on master

May 31 2023, 10:08 PM
jon updated the diff for D7799: [Tunnelbroker] Initial message persistence.

Address feedback

May 31 2023, 10:00 PM
jon updated the diff for D7702: [Keyserver] Introduce tunnelbroker types.

Apply feedback, rebase on master

May 31 2023, 9:51 PM
jon updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

Rebase on master

May 31 2023, 9:50 PM
ashoat requested review of D8049: [native] Default to ENS avatar for users that have one.
May 31 2023, 8:41 PM
ashoat requested review of D8048: [native] Introduce avatarData state to hold pending avatar in AvatarSelection.
May 31 2023, 8:39 PM
ashoat requested review of D8047: [native] Make EditUserAvatar component conditionally navigate to registration screens.
May 31 2023, 8:38 PM
ashoat requested review of D8046: [native] Construct synthetic UserInfo to pass to EditUserAvatar.
May 31 2023, 8:37 PM
ashoat requested review of D8045: [lib] Introduce new GenericUserInfoWithAvatar type.
May 31 2023, 8:35 PM