We discussed this yesterday on 1:1 but today when updating I get confused a bit, so let me respond.
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Oct 11 2023
Oct 11 2023
address review
remove console.log
In D9421#277121, @varun wrote:Refreshing prekeys for user: ... just means the Identity service received the RefreshUserPreKeys request. Shouldn't we make sure that we actually received a successful response from the Identity service?
Rebase on feedback
Fix comment
Fix comment
Address feedback: Set --http-port as global, change dockerfile command
Address feedback: Optimize S3 path iteration
Rebase on parent diff feedback
Rebase on parent diff feedback
Address feedback: Add type alias for blob hash, use ref instead of cloning.
update comment
ginsu added a comment to D9393: [native] introduce userProfileBottomSheetActive state to markdown context.
rebase before landing
address comments + rebase before landing
ginsu updated the diff for D9393: [native] introduce userProfileBottomSheetActive state to markdown context.
rebase before landing
address comments + rebase before landing
Seems reasonable, could be good to test it with an ENS name being mentioned as well to cover all grounds
ginsu updated the diff for D9391: [lib/native/web] introduce createMemberMapForUserMentions function.
rebase before landing
address comments + rebase before landing
(I think you are missing a stack for this diff)
ginsu added inline comments to D9390: [native] make user profile accessible from MessageReactionsModal.
In D9351#276883, @michal wrote:
- Return impl Iterator<> instead of Vec
ginsu updated the diff for D9389: [lib/native/web] make user profile accessible from a user entity in a robotext.
rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
Refreshing prekeys for user: ... just means the Identity service received the RefreshUserPreKeys request. Shouldn't we make sure that we actually received a successful response from the Identity service?
Oct 10 2023
Oct 10 2023
ginsu updated the test plan for D9447: [web] implement RelationshipPromptButtons into user profiles.
update
Found a better way to address regression mentioned in inline comment
GitHub <noreply@github.com> committed rCOMM1bd3b95071de: Bump fsevents from 1.2.9 to 1.2.13 (#273) (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
address @ashoat's feedback
ashoat updated subscribers of D9430: [lib/web/native] Display community role for users in subchannels/sidebars.
There is perhaps a design question here around how to handle more than two tabs in ThreadMembersModalContent. Can you create a DES task on Linear and assign it to @ted to take a look? It might also be good to send a message to the Design Team chat in case there's some discussion to be had.
ashoat requested changes to D9430: [lib/web/native] Display community role for users in subchannels/sidebars.
It looks like ThreadMembersModalContent is still determining its tabs differently from how the pills are being determined. The fact that this code is different is what got us into this mess, and I'd like to make sure it's unified.
rohan updated the summary of D9331: [lib] Move test messages outside of the describe scope to reuse them.
rohan updated the summary of D9330: [keyserver/lib] Update isInvalidSidebarSource to check messageSpec.canBeSidebarSource.
rohan updated the summary of D9325: [lib] Introduce a canBeSidebarSource function in each message spec.
rohan updated the summary of D9324: [lib] Update types for SIDEBAR_SOURCE messages to reflect isInvalidSidebarSource.