Page MenuHomePhorge
Feed Search

May 24 2023

tomek accepted D7919: [lib] add tests for report reducer.
May 24 2023, 9:03 AM
tomek accepted D7936: [CommCoreModule] implement getting report store from database.
May 24 2023, 9:01 AM
tomek accepted D7934: [CommCoreModule] implement report store operations.
May 24 2023, 8:54 AM
tomek accepted D7918: [CommCoreModule] add table and methods for report store.
May 24 2023, 8:49 AM
tomek requested changes to D7873: Implement notification decryption in CommNotificationsHandler.
May 24 2023, 8:46 AM
tomek added inline comments to D7877: [lib] Create a store in redux for the invite links.
May 24 2023, 8:07 AM
tomek added a comment to D7730: [native] Create a modal where invite links are displayed.

As @ted is off for now, I don't think it makes sense to block this diff on this change.

Can you create a DES task and assign it to Ted, to make sure we follow up after he is back?

May 24 2023, 7:57 AM

May 23 2023

tomek updated the diff for D7877: [lib] Create a store in redux for the invite links.

Use readonly type

May 23 2023, 2:40 PM
tomek added inline comments to D7730: [native] Create a modal where invite links are displayed.
May 23 2023, 2:20 PM
tomek requested review of D7944: [keyserver] Use mixed as an input type in inviteLinkVerificationResponder.
May 23 2023, 2:05 PM
tomek updated the diff for D7908: [native] Introduce disable link button.

Use brighter color

May 23 2023, 2:02 PM
tomek updated the diff for D7907: [lib] Allow calling link-disabling endpoint.

Make reducer more efficient

May 23 2023, 1:59 PM
tomek retitled D7907: [lib] Allow calling link-disabling endpoint from [lib] Add reducer and endpoint calling code
May 23 2023, 1:52 PM
tomek added a comment to D7907: [lib] Allow calling link-disabling endpoint.
In D7907#234718, @kamil wrote:

I think the differential name is not complete and confusing a bit

May 23 2023, 1:50 PM
tomek added inline comments to D7906: [keyserver] Create an endpoint that allows disabling links.
May 23 2023, 1:48 PM
tomek updated the diff for D7906: [keyserver] Create an endpoint that allows disabling links.

Specify return type and use mixed as input type

May 23 2023, 1:45 PM
tomek added inline comments to D7906: [keyserver] Create an endpoint that allows disabling links.
May 23 2023, 1:42 PM
tomek added a comment to D7885: [native] Add a link to manage public link screen.
In D7885#234677, @kamil wrote:

Can you share a screenshot of how this looks like?

May 23 2023, 1:37 PM
tomek updated the diff for D7885: [native] Add a link to manage public link screen.

Minor fixes

May 23 2023, 1:37 PM
tomek updated the summary of D7885: [native] Add a link to manage public link screen.
May 23 2023, 1:29 PM
tomek requested review of D7941: [keyserver] Convert flag to a boolean.
May 23 2023, 1:23 PM
tomek added inline comments to D7884: [native] Introduce simple error handling.
May 23 2023, 1:21 PM
tomek updated the diff for D7879: [lib] Add client side boilerplate and reducer for an endpoint that allows creating or updating public links.

Rebase

May 23 2023, 1:15 PM
tomek added inline comments to D7879: [lib] Add client side boilerplate and reducer for an endpoint that allows creating or updating public links.
May 23 2023, 1:12 PM
tomek updated the diff for D7878: [keyserver] Create an endpoint that can be used to create or update a public link.

Minor fixes

May 23 2023, 12:55 PM
tomek added inline comments to D7878: [keyserver] Create an endpoint that can be used to create or update a public link.
May 23 2023, 12:51 PM
tomek added inline comments to D7878: [keyserver] Create an endpoint that can be used to create or update a public link.
May 23 2023, 12:39 PM
tomek added inline comments to D7733: [native] Display a button and navigate to invite links if they are present.
May 23 2023, 12:32 PM
tomek added inline comments to D7730: [native] Create a modal where invite links are displayed.
May 23 2023, 12:30 PM
tomek updated the diff for D7730: [native] Create a modal where invite links are displayed.

Update color name

May 23 2023, 12:27 PM
tomek added inline comments to D7730: [native] Create a modal where invite links are displayed.
May 23 2023, 12:19 PM
tomek updated the diff for D7877: [lib] Create a store in redux for the invite links.

Delete unnecessary migration

May 23 2023, 12:14 PM
tomek added inline comments to D7877: [lib] Create a store in redux for the invite links.
May 23 2023, 12:07 PM
tomek added inline comments to D7877: [lib] Create a store in redux for the invite links.
May 23 2023, 11:57 AM
tomek updated the diff for D7876: [lib] Update invite link type.

Fix the diff

May 23 2023, 11:52 AM
tomek updated the diff for D7876: [lib] Update invite link type.

Update validator

May 23 2023, 11:49 AM
tomek accepted D7916: [lib] make report id mandatory.
May 23 2023, 10:16 AM
tomek accepted D7913: [lib] assign local id to report while creating.

It might be a good idea to create an intermediate function that generates the id. At this point that function would just return getUUID(), but if we ever decide to change id scheme, having this function would be really helpful.

May 23 2023, 10:15 AM
tomek accepted D7912: [lib] add local id field to existing reports.
May 23 2023, 10:14 AM
tomek accepted D7910: [lib] extract local id field before sending report.
May 23 2023, 10:12 AM
tomek accepted D7909: [lib] add local is field to reports.
May 23 2023, 10:00 AM
tomek accepted D7903: [keyserver] Don't use web version when sending desktop notifs.

Are you sure about this? Don't we need both web (js code) version and desktop (electron)?

May 23 2023, 9:02 AM
tomek attached a referenced file: F551539: disable-button-bright.png.
May 23 2023, 8:42 AM
tomek added inline comments to D7911: [landing] change text content on HeroContent component.
May 23 2023, 8:39 AM

May 22 2023

tomek added inline comments to D7908: [native] Introduce disable link button.
May 22 2023, 3:21 PM
tomek accepted D7873: Implement notification decryption in CommNotificationsHandler.
May 22 2023, 1:52 PM
tomek requested review of D7908: [native] Introduce disable link button.
May 22 2023, 1:50 PM
tomek requested review of D7907: [lib] Allow calling link-disabling endpoint.
May 22 2023, 1:47 PM
tomek requested review of D7906: [keyserver] Create an endpoint that allows disabling links.
May 22 2023, 1:42 PM
tomek planned changes to D7878: [keyserver] Create an endpoint that can be used to create or update a public link.
May 22 2023, 10:47 AM
tomek updated the diff for D7878: [keyserver] Create an endpoint that can be used to create or update a public link.

Use tID type

May 22 2023, 10:47 AM
tomek updated the summary of D7880: [native] Implement the UI of manage invite links screen.
May 22 2023, 10:18 AM
tomek updated the diff for D7880: [native] Implement the UI of manage invite links screen.

Fix light mode

May 22 2023, 10:17 AM
tomek accepted D7341: [web] Move reducing logic for picking a community to its own reducer.
May 22 2023, 10:07 AM
tomek requested changes to D7874: Encrypt Android notifications on the keyserver before sending them.
May 22 2023, 9:55 AM
tomek requested changes to D7873: Implement notification decryption in CommNotificationsHandler.
May 22 2023, 9:48 AM
tomek accepted D7872: Implement function to encrypt android notification.
May 22 2023, 9:38 AM
tomek accepted D7861: Implement JNI layer over NotificationsCryptoModule.
May 22 2023, 9:32 AM
tomek accepted D7860: Handle client response to initial notifications encrypted message request.
May 22 2023, 9:26 AM
tomek accepted D7859: Add method to check for missing olm sessions for notifs and use it to send relevant request.
May 22 2023, 9:10 AM
tomek accepted D7858: Add initial notifications encrypted message generator to client responses selector on native.
May 22 2023, 9:03 AM
tomek accepted D7856: Add request and response types for the keyserver to request first encrypted message for e2e notifs.
May 22 2023, 9:02 AM
tomek accepted D7853: Create new olm session during invalidated cookie resolution.
May 22 2023, 9:00 AM
tomek added inline comments to D7868: [landing] implement on click functions in header.
May 22 2023, 7:50 AM

May 19 2023

tomek requested review of D7885: [native] Add a link to manage public link screen.
May 19 2023, 5:35 PM
tomek requested review of D7884: [native] Introduce simple error handling.
May 19 2023, 5:33 PM
tomek requested review of D7883: [native] Call create / update endpoint.
May 19 2023, 5:27 PM
tomek requested review of D7881: [native] Show actions conditionally.
May 19 2023, 5:24 PM
tomek requested review of D7880: [native] Implement the UI of manage invite links screen.
May 19 2023, 5:20 PM
tomek requested review of D7879: [lib] Add client side boilerplate and reducer for an endpoint that allows creating or updating public links.
May 19 2023, 5:18 PM
tomek requested review of D7878: [keyserver] Create an endpoint that can be used to create or update a public link.
May 19 2023, 5:14 PM
tomek requested review of D7877: [lib] Create a store in redux for the invite links.
May 19 2023, 5:02 PM
tomek requested review of D7876: [lib] Update invite link type.
May 19 2023, 4:59 PM
tomek requested review of D7733: [native] Display a button and navigate to invite links if they are present.

The code changed significantly. It is much simpler, though.

May 19 2023, 4:52 PM
tomek updated the diff for D7733: [native] Display a button and navigate to invite links if they are present.

Extract button component

May 19 2023, 4:51 PM
tomek updated the diff for D7730: [native] Create a modal where invite links are displayed.

Use redux instead of local state. The colors still need to be updated.

May 19 2023, 4:47 PM
tomek accepted D7855: [web] Send platform details on websocket connection.
May 19 2023, 12:41 PM
tomek requested changes to D7855: [web] Send platform details on websocket connection.
May 19 2023, 8:32 AM
tomek accepted D7854: [keyserver] Handle web version in hasMinCodeVersion.

Do we still have places where we don't use hasMinCodeVersion function? Do we have to update these?

May 19 2023, 8:25 AM
tomek accepted D7852: [web] Convert ids during state check.
May 19 2023, 8:16 AM
tomek accepted D7851: [lib] Move id conversion functions to lib.
May 19 2023, 8:08 AM
tomek accepted D7848: [keyserver] Validate fetchPrimaryInviteLinksResponder output.
May 19 2023, 8:00 AM
tomek accepted D7808: [keyserver] Convert upload responders.
May 19 2023, 7:58 AM

May 17 2023

tomek added inline comments to D7762: [lib] Introduce a new permission for managing invite links.
May 17 2023, 8:51 AM
tomek added inline comments to D7730: [native] Create a modal where invite links are displayed.
May 17 2023, 8:46 AM
tomek added a comment to D7807: [keyserver] Validate link responders.

@michal are you planning to write validators for fetchPrimaryInviteLinksResponder? I guess it should be done during the rebase.

May 17 2023, 8:35 AM
tomek added inline comments to D7839: [landing] introduce new header elements to header component.
May 17 2023, 8:24 AM

May 16 2023

tomek updated the diff for D7733: [native] Display a button and navigate to invite links if they are present.

Select action sheet theme

May 16 2023, 4:01 PM
tomek updated the summary of D7730: [native] Create a modal where invite links are displayed.
May 16 2023, 3:39 PM
tomek updated the summary of D7733: [native] Display a button and navigate to invite links if they are present.
May 16 2023, 3:39 PM
tomek updated the diff for D7733: [native] Display a button and navigate to invite links if they are present.

Use new navigation structure

May 16 2023, 3:34 PM
tomek updated the diff for D7730: [native] Create a modal where invite links are displayed.

Update the approach - use stack inside modal

May 16 2023, 3:32 PM
tomek planned changes to D7730: [native] Create a modal where invite links are displayed.

The design should be updated

May 16 2023, 12:52 PM
tomek closed D7744: [native] Check install referrer on Android.
May 16 2023, 12:10 PM
tomek closed D7751: [native] Introduce a hook that allows running an effect just once per installation.
May 16 2023, 12:10 PM
tomek committed rCOMMfb20be65e509: [native] Check install referrer on Android.
May 16 2023, 12:10 PM
tomek committed rCOMMd9cb54ebdc11: [native] Introduce a hook that allows running an effect just once per….
May 16 2023, 12:10 PM
tomek closed D7743: [native] Unsubscribe listener on unmount.
May 16 2023, 12:10 PM
tomek committed rCOMM7c38edf5ea5d: [native] Unsubscribe listener on unmount.
May 16 2023, 12:10 PM
tomek updated the diff for D7762: [lib] Introduce a new permission for managing invite links.

Rebase

May 16 2023, 11:18 AM