As of this diff we've brought the "second render" of MessageList from ~100ms to ~40ms. The ThreadList optimizations should be 4-5x as impactful.
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Sep 1 2023
Sep 1 2023
atul requested review of D9051: [native] Convert `ConnectedMessage` class component to functional `Message`.
Aug 31 2023
Aug 31 2023
a little more memoization. i think i'm going to "call this diff" for now. the core issue is the children React.Node that gets drilled down that contains InnerTextMessage. I'll need to memoize that "futher up the component tree" to really make an impact
Okay looks like that stopped re-render of one of the SwipeSnakes, but we still have another SwipeSnake and panGestureHandler re-rendering.. will take another look and update Test Plan with before/after flamegraphs
atul updated the summary of D9053: [native] Memoize `PanGestureHandler` props in `SwipeableMessage`.
atul updated the summary of D9051: [native] Convert `ConnectedMessage` class component to functional `Message`.
atul published D9051: [native] Convert `ConnectedMessage` class component to functional `Message` for review.
On re-render of MessageList, Timestamp is actually the component that takes the longest to render.
Aug 27 2023
Aug 27 2023
Also not super familiar with tooltip logic, but looks reasonable to me
Looks good to me. Don't have any experience forwarding refs so adding @tomek as blocking to take another look.
Haven't seen how BottomSheetModalProvider was implemented, but this seems like a reasonable place to place the provider in the hierarchy.
Aug 26 2023
Aug 26 2023
Aug 25 2023
Aug 25 2023
IMO it's a little confusing that we have like generic micro and small but then also usage specific profile size names. Personally would prefer something "standard" so progression of sizes is clear. Like it's not super clear where profile sits relative to eg small and large.
Aug 22 2023
Aug 22 2023
atul published D8919: [web] Fix `ThreadSettingsModal` and flip switch to enable `EditThreadAvatar` for review.
In D8856#263021, @ashoat wrote:Please address or respond to my comment before landing!
address feedback
rebase and land
Aug 21 2023
Aug 21 2023
rebase and alnd
atul updated the diff for D8854: [web] "Flip the switch" to enable editing of user avatars on `web`.
rebase and land
rebase and land
Aug 20 2023
Aug 20 2023
Also, this is outside the scope of this diff, but I think a better UI/UX would be to make the whole Edit Avatar component here clickable instead of just the badge.
cc @ted
Aug 18 2023
Aug 18 2023
rebase and land
Aug 17 2023
Aug 17 2023
newline after // @flow
atul published D8854: [web] "Flip the switch" to enable editing of user avatars on `web` for review.
Aug 16 2023
Aug 16 2023
Adding Rohan as reviewer
Wow 15min to 0.1s is huge
rebase and land
In D8802#259870, @ginsu wrote:code looks good, but could we also get a screenshot of what ThreadSettingsGeneralTab looks like with editingAvatarsOnWebEnabled set to true
atul added inline comments to D8821: [web] Create a new 'secondary device' screen that will generate the QR code.
Aug 15 2023
Aug 15 2023
rebase and land
rebase and land
Aug 14 2023
Aug 14 2023
Aug 10 2023
Aug 10 2023
atul updated the diff for D8774: [lib] Consolidate `updateImageThreadAvatar` into `baseSetThreadAvatar`.
rebase and land
Aug 9 2023
Aug 9 2023
atul published D8774: [lib] Consolidate `updateImageThreadAvatar` into `baseSetThreadAvatar` for review.
Accepting, but make sure to address @ashoat's feedback before landing
atul updated the diff for D8773: Remove `useUploadSelectedMedia` prop from `BaseEditThreadAvatarProvider`.
rebase and land
atul updated the diff for D8772: Move `native`-specific `uploadSelectedMedia` from `updateImageThreadAvatar` to `nativeUpdateImageThreadAvatar`.
rebase and alnd
atul updated the diff for D8773: Remove `useUploadSelectedMedia` prop from `BaseEditThreadAvatarProvider`.
rebase and land
atul published D8773: Remove `useUploadSelectedMedia` prop from `BaseEditThreadAvatarProvider` for review.