Page MenuHomePhorge
Feed All Stories

May 30 2023

varun accepted D7800: [Tunnelbroker] Refactor connection lifetimes into session object.
May 30 2023, 9:08 PM
varun accepted D7801: [Tunnelbroker] Remove usages of unwrap and expect.
May 30 2023, 9:07 PM
varun accepted D7799: [Tunnelbroker] Initial message persistence.

nvm misunderstood the persist_message fn. just a couple nits

May 30 2023, 9:00 PM
varun requested changes to D7799: [Tunnelbroker] Initial message persistence.
May 30 2023, 8:50 PM
Harbormaster failed remote builds in B19913: Diff 27275 for D8032: [landing] introduce slack competitor data!
May 30 2023, 7:12 PM
ashoat closed D8023: [native] Make EmojiThreadAvatarCreation work with activeThreadSelector.
May 30 2023, 7:09 PM
ashoat committed rCOMMce10be74ff99: [native] Make EmojiThreadAvatarCreation work with activeThreadSelector.
May 30 2023, 7:09 PM
ashoat closed D8022: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar.
May 30 2023, 7:09 PM
ashoat closed D8021: [native] Replace generic useSaveThreadAvatar with new generic setThreadAvatar.
May 30 2023, 7:09 PM
ashoat closed D8020: [native] Replace removeThreadAvatar with generic setThreadAvatar.
May 30 2023, 7:09 PM
ashoat committed rCOMM894ce8c8bac0: [native] Replace generic useSaveThreadAvatar with new generic setThreadAvatar.
May 30 2023, 7:09 PM
ashoat committed rCOMM5d343f2ba01b: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar.
May 30 2023, 7:09 PM
ashoat committed rCOMMf5969fd86183: [native] Replace removeThreadAvatar with generic setThreadAvatar.
May 30 2023, 7:09 PM
ashoat closed D8018: [native] Replace generic useSaveUserAvatar with new generic setUserAvatar.
May 30 2023, 7:09 PM
ashoat closed D8019: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar.
May 30 2023, 7:09 PM
ashoat committed rCOMM886fbe9e1293: [native] Replace generic useSaveUserAvatar with new generic setUserAvatar.
May 30 2023, 7:09 PM
ashoat committed rCOMM649d3964fd77: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar.
May 30 2023, 7:09 PM
ashoat closed D8017: [native] Replace setENSUserAvatar and removeUserAvatar with generic setUserAvatar.
May 30 2023, 7:09 PM
ashoat committed rCOMM4767be3e48bf: [native] Replace setENSUserAvatar and removeUserAvatar with generic….
May 30 2023, 7:09 PM
ashoat updated the diff for D8022: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar.

displayFailureAlert

May 30 2023, 7:06 PM
ashoat updated the diff for D8019: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar.

displayFailureAlert

May 30 2023, 7:05 PM
ginsu planned changes to D8034: [landing] introduce competitor comparison.

Need to make one small adjustment to alignment of cards

May 30 2023, 7:04 PM
ginsu requested review of D8034: [landing] introduce competitor comparison.
May 30 2023, 6:59 PM
ginsu requested review of D8033: [landing] introduce telegram competitor data.
May 30 2023, 6:55 PM
ginsu updated the diff for D8032: [landing] introduce slack competitor data.

add key

May 30 2023, 6:35 PM
ginsu updated the diff for D8030: [landing] introduce Matrix competitor data.

add key

May 30 2023, 6:34 PM
ginsu updated the diff for D8031: [landing] introduce keybase competitor data.

add key

May 30 2023, 6:34 PM
ginsu updated the diff for D8029: [landing] introduce Discord competitor data.

add key

May 30 2023, 6:33 PM
ginsu added a comment to D8028: [landing] key competitor data.

(Looks like you added the Signal key in the update, did you mean to update the other entries as well?)

May 30 2023, 6:32 PM
atul added a comment to D8028: [landing] key competitor data.

(Looks like you added the Signal key in the update, did you mean to update the other entries as well?)

May 30 2023, 6:30 PM
ginsu updated the diff for D8028: [landing] key competitor data.

address comments

May 30 2023, 6:00 PM
kamil accepted D8010: [native] Use search users in chat composer.

Looks good but check comments from D8013 related to shared code

May 30 2023, 4:45 PM
kamil requested changes to D8013: [web] Use search users in chat composer.
May 30 2023, 4:42 PM
kamil accepted D8011: [web] Change navInfo.selectedUserList to contains user infos.
May 30 2023, 4:42 PM
kamil accepted D8009: [lib] Include searchUsers results in getPotentialMemberItems.

Looks good but address @ashoat's comment before landing

May 30 2023, 4:41 PM
atul accepted D7993: [web] Add multimediaClassName prop to encrypted media components.
May 30 2023, 4:35 PM
atul accepted D8023: [native] Make EmojiThreadAvatarCreation work with activeThreadSelector.
May 30 2023, 4:35 PM
atul accepted D8022: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar.
May 30 2023, 4:34 PM
atul accepted D7994: [web] Add MediaGalleryItem component.

Re-requesting because I see no way of creating a dynamic style with classnames

May 30 2023, 4:31 PM
atul accepted D8021: [native] Replace generic useSaveThreadAvatar with new generic setThreadAvatar.
May 30 2023, 4:29 PM
atul accepted D8020: [native] Replace removeThreadAvatar with generic setThreadAvatar.
May 30 2023, 4:27 PM
ginsu requested review of D8032: [landing] introduce slack competitor data.
May 30 2023, 4:25 PM
ginsu requested review of D8031: [landing] introduce keybase competitor data.
May 30 2023, 4:21 PM
atul added inline comments to D8019: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar.
May 30 2023, 4:15 PM
ginsu requested review of D8030: [landing] introduce Matrix competitor data.
May 30 2023, 4:15 PM
atul accepted D8019: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar.
May 30 2023, 4:13 PM
atul accepted D8018: [native] Replace generic useSaveUserAvatar with new generic setUserAvatar.
May 30 2023, 4:13 PM
atul accepted D8017: [native] Replace setENSUserAvatar and removeUserAvatar with generic setUserAvatar.
May 30 2023, 4:12 PM
ginsu requested review of D8029: [landing] introduce Discord competitor data.
May 30 2023, 4:11 PM
atul accepted D8025: [landing] introduce feature modal component.

Thanks for updating, looks good

May 30 2023, 4:01 PM
atul accepted D8028: [landing] key competitor data.

If we only plan on exporting keyedCompetitorData, could we just add keys to competitorData and turn it from array -> keyed obj?

May 30 2023, 3:58 PM
michal accepted D7986: [web-db] dispatch reports from SQLite to store.
May 30 2023, 3:27 PM
michal accepted D7985: [web-db] start processing report store operations.
May 30 2023, 3:27 PM
michal accepted D7984: [web-db] add report table on web.
May 30 2023, 3:27 PM
michal accepted D7983: [web-db] implement SQL queries for report store.
May 30 2023, 3:26 PM
michal accepted D7982: [web-db] add migration logic to SQLite on web.

I think you could test the migration code by mocking the migrations variable with jest, but not sure if that's worth it.

May 30 2023, 3:26 PM
michal accepted D7977: [native] migrate reports to SQLite.
May 30 2023, 3:25 PM
michal accepted D7975: [CommCoreModule] implement synchronous report store operations.
May 30 2023, 3:25 PM
ginsu requested review of D8028: [landing] key competitor data.
May 30 2023, 3:18 PM
ginsu added a comment to D8025: [landing] introduce feature modal component.

Not sure why we're using black-with-opacity on web, versus almost-black-with-opacity on landing. Wonder if we could replace #010101bf with one of the colors we're using on web, but I guess it's not super important given that landing has its own distinct design system.

May 30 2023, 3:08 PM
ashoat updated subscribers of D8025: [landing] introduce feature modal component.
May 30 2023, 3:00 PM
ginsu added inline comments to D8025: [landing] introduce feature modal component.
May 30 2023, 2:57 PM
ginsu updated the diff for D8025: [landing] introduce feature modal component.

address comments

May 30 2023, 2:55 PM
ginsu added inline comments to D8025: [landing] introduce feature modal component.
May 30 2023, 2:36 PM
atul requested changes to D8025: [landing] introduce feature modal component.

Looks good, can we avoid hard coding hex value being passed to ModalOverlay backgroundColor?

May 30 2023, 2:27 PM
atul accepted D8024: [landing] introduce competitor feature base component.
May 30 2023, 2:23 PM
atul accepted D8016: [landing] introduce competitors type.
May 30 2023, 2:17 PM
atul accepted D8015: [landing] introduce competitor logo component.
May 30 2023, 2:16 PM
ashoat accepted D7691: [Keyserver] Open websocket connection with tunnelbroker.
May 30 2023, 2:15 PM
jon requested review of D7691: [Keyserver] Open websocket connection with tunnelbroker.
May 30 2023, 2:09 PM
Restricted Repository Identity closed D8014: [web] Revert wordmark position on macos.
May 30 2023, 2:00 PM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM9e4ffc885b7e: [web] Revert wordmark position on macos.
May 30 2023, 2:00 PM
bartek accepted D7800: [Tunnelbroker] Refactor connection lifetimes into session object.
May 30 2023, 1:30 PM
bartek accepted D7801: [Tunnelbroker] Remove usages of unwrap and expect.

Fair enough, accepting to unblock you now, but we definitely need to prioritize the comm-services-lib sync, or maintaining the lib will bring more costs than benefits. Anyway, this can be discussed in the Linear task you created ;)

May 30 2023, 1:30 PM
jon requested review of D7801: [Tunnelbroker] Remove usages of unwrap and expect.
May 30 2023, 1:19 PM
ashoat updated the diff for D8020: [native] Replace removeThreadAvatar with generic setThreadAvatar.

Make setThreadAvatar return Promise<void> for consistency with D8017, since nothing needs its return anyways

May 30 2023, 12:52 PM
ashoat updated the diff for D8017: [native] Replace setENSUserAvatar and removeUserAvatar with generic setUserAvatar.

Make setUserAvatar return Promise<void> so that it can be used in the registration flow with the expectation that it calls the keyserver

May 30 2023, 12:51 PM
kuba updated the test plan for D8027: [web] Scrolling to the edited message when it overflows.
May 30 2023, 12:10 PM
kuba requested review of D8027: [web] Scrolling to the edited message when it overflows.
May 30 2023, 12:03 PM
ashoat accepted D8026: [web] Fix "invariant violation" for encrypted uploads.
May 30 2023, 11:38 AM
kamil closed D7754: [lib] modify `assertObjectsAreEqual` to return deep differential instead of only one level keys.
May 30 2023, 10:36 AM
kamil committed rCOMM96701d4d30c4: [lib] modify `assertObjectsAreEqual` to return deep differential instead of….
May 30 2023, 10:36 AM
kamil closed D7753: [lib] introduce function to find deep difference between two objects.
May 30 2023, 10:36 AM
kamil committed rCOMMf1bfa41e62f4: [lib] introduce function to find deep difference between two objects.
May 30 2023, 10:36 AM
kamil removed a reviewer for D7753: [lib] introduce function to find deep difference between two objects: tomek.

Removing @tomek to unblock this because he does not work this week and his review is no longer applicable as this function was typed differently than in the previous version.

May 30 2023, 10:34 AM
kamil updated the diff for D7754: [lib] modify `assertObjectsAreEqual` to return deep differential instead of only one level keys.

rebase

May 30 2023, 9:44 AM
kamil added inline comments to D7753: [lib] introduce function to find deep difference between two objects.
May 30 2023, 9:43 AM
kamil updated the diff for D7753: [lib] introduce function to find deep difference between two objects.

introduce NestedObjectMap type

May 30 2023, 9:43 AM
bartek added reviewers for D7993: [web] Add multimediaClassName prop to encrypted media components: atul, kuba.
May 30 2023, 9:36 AM
bartek requested review of D8026: [web] Fix "invariant violation" for encrypted uploads.
May 30 2023, 9:29 AM
bartek closed D7976: [native] Use BlobUtils for media encryption/decryption.
May 30 2023, 8:57 AM
bartek closed D7974: [native] Implement BlobUtils expo-module on Android.
May 30 2023, 8:57 AM
bartek committed rCOMM0cbe6716f620: [native] Use BlobUtils for media encryption/decryption.
May 30 2023, 8:57 AM
bartek committed rCOMMca7dc26f16b4: [native] Implement BlobUtils expo-module on Android.
May 30 2023, 8:57 AM
bartek closed D7973: [native] Add BlobUtils expo-module and add iOS implementation.
May 30 2023, 8:57 AM
bartek committed rCOMM42bca7921375: [native] Add BlobUtils expo-module and add iOS implementation.
May 30 2023, 8:57 AM
marcin committed rCOMM14fca1204d10: Fix code version check condition when deciding whether to ask the client for….
May 30 2023, 8:04 AM
marcin added inline comments to D7859: Add method to check for missing olm sessions for notifs and use it to send relevant request.
May 30 2023, 8:01 AM
ginsu requested review of D8025: [landing] introduce feature modal component.
May 30 2023, 6:38 AM
bartek updated the diff for D7976: [native] Use BlobUtils for media encryption/decryption.

Rebase

May 30 2023, 6:00 AM