nvm misunderstood the persist_message fn. just a couple nits
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
All Stories
May 30 2023
displayFailureAlert
displayFailureAlert
Need to make one small adjustment to alignment of cards
add key
add key
add key
add key
(Looks like you added the Signal key in the update, did you mean to update the other entries as well?)
(Looks like you added the Signal key in the update, did you mean to update the other entries as well?)
address comments
Looks good but check comments from D8013 related to shared code
Looks good but address @ashoat's comment before landing
Re-requesting because I see no way of creating a dynamic style with classnames
Thanks for updating, looks good
If we only plan on exporting keyedCompetitorData, could we just add keys to competitorData and turn it from array -> keyed obj?
I think you could test the migration code by mocking the migrations variable with jest, but not sure if that's worth it.
Not sure why we're using black-with-opacity on web, versus almost-black-with-opacity on landing. Wonder if we could replace #010101bf with one of the colors we're using on web, but I guess it's not super important given that landing has its own distinct design system.
address comments
Looks good, can we avoid hard coding hex value being passed to ModalOverlay backgroundColor?
Fair enough, accepting to unblock you now, but we definitely need to prioritize the comm-services-lib sync, or maintaining the lib will bring more costs than benefits. Anyway, this can be discussed in the Linear task you created ;)
Make setThreadAvatar return Promise<void> for consistency with D8017, since nothing needs its return anyways
Make setUserAvatar return Promise<void> so that it can be used in the registration flow with the expectation that it calls the keyserver
Removing @tomek to unblock this because he does not work this week and his review is no longer applicable as this function was typed differently than in the previous version.
rebase
introduce NestedObjectMap type
Rebase