update
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jul 6 2024
Jul 6 2024
ashoat added a reverting change for D12674: [lib] Fix missing usernames: D12680: [lib] Fix crash when pressing message from anonymous author.
Jul 5 2024
Jul 5 2024
Harbormaster failed remote builds in B30173: Diff 42084 for D12675: [native] update copy for thread notification settings!
Found a bug with saving the thread notif settings
ashoat committed rCOMM89dc3aef75e2: Revert "[lib] Temporarily flip usingCommServicesAccessToken to false" (authored by ashoat).
Revert "[lib] Temporarily flip usingCommServicesAccessToken to false"
ashoat committed rCOMM200140b0871c: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
[native] codeVersion -> 366
ashoat committed rCOMM7be353f6f870: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
[native] codeVersion -> 365
[web][keyserver] codeVersion -> 95
ashoat committed rCOMMf0ddbc7fb5b8: [lib] Temporarily flip usingCommServicesAccessToken to false (authored by ashoat).
[lib] Temporarily flip usingCommServicesAccessToken to false
[lib] Fix missing usernames
tomek added a comment to D12422: [web][native] Display both thread and community names in the modal.
In D12422#355471, @inka wrote:"within" is not centered on web (vertically), can we fix this?
In D12667#358976, @ashoat wrote:On Linear, you asked whether we should check the parent or the top ancestor under GENESIS for permissions. I suggested that the top ancestor made more sense, but I probably care more about consistency with native. What do we do there?
Jul 4 2024
Jul 4 2024
ashoat committed rCOMMff18eb3b1024: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
ashoat committed rCOMM24c1ee40ddf4: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
[native] codeVersion -> 364
ashoat committed rCOMM9531e5e257ce: Revert "[lib] Temporarily flip usingCommServicesAccessToken to false" (authored by ashoat).
Revert "[lib] Temporarily flip usingCommServicesAccessToken to false"
[native] codeVersion -> 363
[web][keyserver] codeVersion -> 94
ashoat committed rCOMM96fb14a8477c: [lib] Temporarily flip usingCommServicesAccessToken to false (authored by ashoat).
[lib] Temporarily flip usingCommServicesAccessToken to false
On Linear, you asked whether we should check the parent or the top ancestor under GENESIS for permissions. I suggested that the top ancestor made more sense, but I probably care more about consistency with native. What do we do there?
ashoat added inline comments to D12650: Update extractKeyserverIDFromID so that it returns null for DMs.
ashoat added inline comments to D12638: [lib] Send primary device logout message to secondary devices.
ginsu committed rCOMMd78ef501ea74: [native] update ThreadSettingsPushNotifs to use new thread notifs settings… (authored by ginsu).
[native] update ThreadSettingsPushNotifs to use new thread notifs settings…
[native] deprecate ThreadSettingsHomeNotifs
ginsu committed rCOMMe60d77284b98: [native] update thread notif settings ui to handle case when parent thread is… (authored by ginsu).
[native] update thread notif settings ui to handle case when parent thread is…
ginsu committed rCOMM17786b62ab07: [lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT (authored by ginsu).
[lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT
[native] introduce NotificationDescription
ginsu committed rCOMM0e0eeebb12fa: [native] introduce thread notif settings notice text (authored by ginsu).
[native] introduce thread notif settings notice text
ginsu committed rCOMM769fcab17eac: [native] introduce barebones UI for ThreadSettingsNotifications (authored by ginsu).
[native] introduce barebones UI for ThreadSettingsNotifications
ginsu committed rCOMMd805cb6dbfba: [lib/native/web] factor out remaining shared logic + copy for thread… (authored by ginsu).
[lib/native/web] factor out remaining shared logic + copy for thread…
[native] update EnumSettingsOption UI
ginsu committed rCOMMa9358077a210: [native] introduce disabled prop for EnumSettingsOption (authored by ginsu).
[native] introduce disabled prop for EnumSettingsOption
ginsu committed rCOMM5795c5998829: [native] extend icon prop in EnumSettingsOption to handle illustration… (authored by ginsu).
[native] extend icon prop in EnumSettingsOption to handle illustration…
ginsu committed rCOMM8ec15fd60aa1: [native] introduce type prop to EnumSettingsOption component (authored by ginsu).
[native] introduce type prop to EnumSettingsOption component
ginsu committed rCOMM4df530f032dc: [native] introduce nav logic for ThreadSettingsNotifications (authored by ginsu).
[native] introduce nav logic for ThreadSettingsNotifications
rebae before landing
ashoat committed rCOMM1b3dff868ac3: [lib] Fix accidental variable naming from D12495 (authored by ashoat).
[lib] Fix accidental variable naming from D12495
[lib] Introduce DMOperations
ashoat committed rCOMM23cf032f052c: [lib] DMOperationSpec for SEND_TEXT_MESSAGE operation (authored by ashoat).
[lib] DMOperationSpec for SEND_TEXT_MESSAGE operation
ashoat committed rCOMMa761d91e9ae2: [keyserver] Update ServerThreadInfo to only cover ThinThreadType (authored by ashoat).
[keyserver] Update ServerThreadInfo to only cover ThinThreadType
ashoat committed rCOMM4f9c9876a478: [lib] Make it possible to skip some thread/message properties (authored by ashoat).
[lib] Make it possible to skip some thread/message properties
ginsu updated the diff for D12665: [native] update ThreadSettingsPushNotifs to use new thread notifs settings experience.
address comments + rebase before landing
address comments + rebase before landing
- Actually pass sourceMessageAuthorID in based on sourceMessage
- Decided to use a UUID instead of 'ignored'. I'm pretty sure it's not used on the client anywhere, but figured it's better to avoid any risks in case it affects anything, given our tight timeline for launch
Decided to use a UUID instead of 'ignored'. I'm pretty sure it's not used on the client anywhere, but figured it's better to avoid any risks in case it affects anything, given our tight timeline for launch
ginsu updated the diff for D12663: [native] update thread notif settings ui to handle case when parent thread is in background.
rebase before landing
rebase before landing
rebase before landing
rebase before landing
ashoat committed rCOMM51a51ba64cc9: [keyserver][lib][native] Continue storing password hash in authoritative… (authored by ashoat).
[keyserver][lib][native] Continue storing password hash in authoritative…
rebase before landing
ginsu updated the diff for D12661: [lib/native/web] factor out remaining shared logic + copy for thread notification settings.
rebase before landing
address comments + rebase before landing
rebase before landing
ginsu updated the diff for D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.
rebase before landing
rebase before landing
rebase before landing
In D12657#358709, @inka wrote:Should we be able to create a subchannel of a thick thread?
I am afraid that there is a vulnerability in this diff. Basically it is possible that two createOlmSessionWithPeer promises will execute concurrently. This might lead to corrupted state. In order to mitigate that I think it is best expose this method as a context. The context would internally keep a map like [(userID, deviceID)] : Promise mapping from particular deviceID and userID to currently executing promise (if any).
marcin updated the test plan for D12668: Implement peer notifications session creation as outbound on native.