Page MenuHomePhabricator

[native] [21/40] RN 0.70: Update comm-react-native-codegen
ClosedPublic

Authored by ashoat on Dec 18 2022, 7:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 8:53 PM
Unknown Object (File)
Mon, Nov 4, 4:53 PM
Unknown Object (File)
Sat, Nov 2, 3:34 AM
Unknown Object (File)
Sat, Nov 2, 3:34 AM
Unknown Object (File)
Sat, Nov 2, 3:34 AM
Unknown Object (File)
Sat, Nov 2, 3:34 AM
Unknown Object (File)
Sat, Nov 2, 3:34 AM
Unknown Object (File)
Sat, Nov 2, 3:34 AM
Subscribers

Details

Summary

Updated to the latest version, and then ran yarn codegen-jsi in native. After that I had to made some adjustments to CommCoreModule to match updated generated code.

Test Plan

Tested along with whole stack: test plan

Depends on D5914

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 7:15 PM
Harbormaster failed remote builds in B14244: Diff 19483!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:25 PM
Harbormaster failed remote builds in B14266: Diff 19505!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:57 PM
Harbormaster failed remote builds in B14293: Diff 19532!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 9:07 AM
Harbormaster failed remote builds in B14378: Diff 19627!

Please ignore CI until the end of the stack

This revision is now accepted and ready to land.Dec 20 2022, 5:15 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:01 PM
This revision was automatically updated to reflect the committed changes.