Page MenuHomePhabricator
Differential D7938

[native] fetch reports from SQLite and dispatch to store
ClosedPublic
Actions

Authored by kamil on May 23 2023, 3:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 3:41 PM
Unknown Object (File)
Wed, May 1, 9:21 AM
Unknown Object (File)
Tue, Apr 30, 8:04 PM
Unknown Object (File)
Tue, Apr 30, 1:31 PM
Unknown Object (File)
Mon, Apr 29, 7:54 AM
Unknown Object (File)
Sun, Apr 28, 4:32 PM
Unknown Object (File)
Sun, Apr 28, 2:39 AM
Unknown Object (File)
Fri, Apr 26, 12:56 PM
View All 59 Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMM2cb7cef3cfe0: [native] fetch reports from SQLite and dispatch to store
Summary

Retrieving data and putting back to store.
We could consider moving this logic to different place - reports are not needed on app start.

Depends on D7937

Test Plan

Check if reports are properly fetched and converted.

Diff Detail

Repository
rCOMM Comm
Branch
reports-native
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.May 23 2023, 3:44 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 23 2023, 3:44 AM
kamil added a child revision: D7939: [native] stop persisting reports.May 23 2023, 4:00 AM
Harbormaster completed remote builds in B19650: Diff 26858.May 23 2023, 4:03 AM
kamil published this revision for review.May 23 2023, 4:55 PM
tomek accepted this revision.May 24 2023, 3:19 AM

We could consider moving this logic to different place - reports are not needed on app start.

Yeah, waiting for these when the app starts isn't ideal.

This revision is now accepted and ready to land.May 24 2023, 3:19 AM
kamil updated this revision to Diff 27298.May 31 2023, 8:32 AM

rebase before landing

kamil added a comment.May 31 2023, 8:33 AM
In D7938#235912, @tomek wrote:

We could consider moving this logic to different place - reports are not needed on app start.

Yeah, waiting for these when the app starts isn't ideal.

created task: ENG-4021

Harbormaster completed remote builds in B19923: Diff 27298.May 31 2023, 8:51 AM
Closed by commit rCOMM2cb7cef3cfe0: [native] fetch reports from SQLite and dispatch to store (authored by kamil). · Explain WhyMay 31 2023, 9:24 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM2cb7cef3cfe0: [native] fetch reports from SQLite and dispatch to store.

Revision Contents
Changeset List

PathSize
lib/
ops/
7 lines
reducers/
1 line
25 lines
types/
2 lines
native/
data/
7 lines
schema/
2 lines

Diff 26858

View Options

lib/ops/report-store-ops.js

Loading...
View Options

lib/reducers/message-reducer.test.js

Loading...
View Options

lib/reducers/report-store-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

native/data/sqlite-data-handler.js

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...