reabase
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
All Stories
Mar 13 2023
there is more crypto-relatud stuff, making names more exact to easily distinguish
Check if database result is not empty
- update type
- add message type to error message
- update type
- update worker path
- add check
Change order
Looks ok - it doesn't seem necessary to do a migration.
Good point, I've added a check that makes sure that the timer doesn't already exist before creating a new one
Can you check what it looks like with the "Delivery failed. RETRY?" text which appears when sending a message, and attach a screenshot? Not sure if this case was considered in the designs.
Looks good to me, but I haven't worked with this code so it would be nice if someone else could also take a look.
Revert accidental changes
- Rebase
- Added new tests
- Rebase on new types
- Address review feedback
- Used consistent naming for ciphertext, sealed data etc.
Add comment explaining even release pattern
Address code review feedback
Address code review feedback
Address code review feedback
Address code review feedback
Address code review feedback
Regarding all naming issues (applies to the whole stack), I've created a Notion doc that clarifies the names
Rebase
Remove unnnecessary div
In D6963#208218, @ginsu wrote:I think we should consider if we also need shimUnsupportedMessageInfo and unshimMessageInfo. These functions will help us support older native clients that haven't been updated yet.
Responded to comments
Replaced by D6994
LGTM, Works with my changes. Thank you for taking care of this!
Mar 12 2023
fix..