Page MenuHomePhorge
Feed All Stories

Mar 13 2023

ashoat requested changes to D7053: [lib] introduce getAvatarForUser in avatar-utils.
Mar 13 2023, 4:29 PM
kamil updated the diff for D6996: [web-db] generate `CryptoKey` and persist.

reabase

Mar 13 2023, 3:48 PM
kamil added a reviewer for D6995: [web-db] implement crypto functions: bartek.
Mar 13 2023, 3:47 PM
kamil updated the diff for D6995: [web-db] implement crypto functions.

there is more crypto-relatud stuff, making names more exact to easily distinguish

Mar 13 2023, 3:47 PM
kamil added inline comments to D6993: [web-db] initialize SQLite database.
Mar 13 2023, 3:45 PM
kamil updated the diff for D6993: [web-db] initialize SQLite database.

Check if database result is not empty

Mar 13 2023, 3:43 PM
kamil added inline comments to D6992: [web-db] implement proxy for promise-based connection with worker.
Mar 13 2023, 3:42 PM
kamil updated the diff for D6992: [web-db] implement proxy for promise-based connection with worker.
  • update type
  • add message type to error message
Mar 13 2023, 3:40 PM
kamil added inline comments to D6991: [web-db] implement basic app-worker connection types.
Mar 13 2023, 3:39 PM
kamil added inline comments to D6990: [web-db] add indexedDB config.
Mar 13 2023, 3:38 PM
kamil added inline comments to D6987: [web-db] add Shared Worker config.
Mar 13 2023, 3:37 PM
kamil updated the diff for D6987: [web-db] add Shared Worker config.
  • update type
  • update worker path
  • add check
Mar 13 2023, 3:36 PM
bartek published D7061: [lib] Introduce combined padding interface for review.
Mar 13 2023, 3:11 PM
bartek published D7060: [lib] Introduce superblock padding for review.
Mar 13 2023, 3:10 PM
bartek published D7059: [lib] Introduce PKCS#7 padding for review.
Mar 13 2023, 3:09 PM
atul removed a reviewer for D7051: [keyserver] Send `SIGNED_IDENTITY_KEYS_BLOB` request to client if data missing in DB: tomek.
Mar 13 2023, 2:35 PM
atul removed a reviewer for D7050: [keyserver] Introduce `isCookieMissingSignedIdentityKeysBlob`: tomek.
Mar 13 2023, 2:35 PM
atul removed a reviewer for D7049: [keyserver] Introduce `setCookieSignedIdentityKeysBlob`: tomek.
Mar 13 2023, 2:34 PM
atul removed a reviewer for D7048: [web] Use `signedIdentityKeysBlobSelector` in `SIWELoginForm`: tomek.
Mar 13 2023, 2:34 PM
atul removed a reviewer for D7047: [web] Use `signedIdentityKeysBlobSelector` in `TraditionalLoginForm`: tomek.
Mar 13 2023, 2:34 PM
Restricted Repository Identity closed D7031: [CI] Fix macos buildkite ci.
Mar 13 2023, 2:28 PM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMf03bb732b176: [CI] Fix macos buildkite ci.
Mar 13 2023, 2:28 PM
michal updated the diff for D7032: [desktop] Handle autoUpdate errors.

Change order

Mar 13 2023, 2:27 PM
kamil accepted D7032: [desktop] Handle autoUpdate errors.
Mar 13 2023, 2:23 PM
tomek accepted D7029: [native] Move NotifPermissionAlertInfo to lib.

Looks ok - it doesn't seem necessary to do a migration.

Mar 13 2023, 2:22 PM
michal updated the diff for D7032: [desktop] Handle autoUpdate errors.

Good point, I've added a check that makes sure that the timer doesn't already exist before creating a new one

Mar 13 2023, 2:04 PM
tomek accepted D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start..
Mar 13 2023, 2:02 PM
marcin added inline comments to D6920: Modify TemporaryMessageStorage API, so that we can have two storages: one (created by default init) for messages and the other for rescinds..
Mar 13 2023, 1:50 PM
tomek accepted D6920: Modify TemporaryMessageStorage API, so that we can have two storages: one (created by default init) for messages and the other for rescinds..
Mar 13 2023, 1:37 PM
InkaSokolowska closed D6851: [web] Fix long names in displaying incorrectly in the ChatMessageListContainers header.
Mar 13 2023, 1:35 PM
InkaSokolowska closed D6848: [web] Fix filter panel showing over the topbar.
Mar 13 2023, 1:35 PM
InkaSokolowska closed D6849: [web] Style the AppSwitcher.
Mar 13 2023, 1:35 PM
InkaSokolowska committed rCOMM5339cf4c28f1: [web] Fix long names in displaying incorrectly in the ChatMessageListContainers….
Mar 13 2023, 1:35 PM
InkaSokolowska committed rCOMM4bd6b6c4efa6: [web] Fix filter panel showing over the topbar.
Mar 13 2023, 1:35 PM
InkaSokolowska committed rCOMM8b43a5edf514: [web] Style the AppSwitcher.
Mar 13 2023, 1:35 PM
InkaSokolowska closed D6845: [web] Style navigation state info in the top bar.
Mar 13 2023, 1:35 PM
InkaSokolowska closed D6842: [web] Add navigation state info to the topbar.
Mar 13 2023, 1:35 PM
InkaSokolowska closed D6841: [web] Add PossiblyEmptyNavStateInfoBar to handle collapse animation in the topbar when no community is selected.
Mar 13 2023, 1:35 PM
InkaSokolowska committed rCOMM966d977bbe17: [web] Style navigation state info in the top bar.
Mar 13 2023, 1:35 PM
InkaSokolowska committed rCOMM11b19a3e414c: [web] Add PossiblyEmptyNavStateInfoBar to handle collapse animation in the….
Mar 13 2023, 1:35 PM
InkaSokolowska committed rCOMMf50f8f28a5ba: [web] Add navigation state info to the topbar.
Mar 13 2023, 1:35 PM
InkaSokolowska closed D6746: [web] Add a selector for getting the item currently selected in the drawer.
Mar 13 2023, 1:35 PM
InkaSokolowska closed D6745: [web] Split ThreadTopBar into two components.
Mar 13 2023, 1:35 PM
InkaSokolowska committed rCOMM9b215ace7eb8: [web] Add a selector for getting the item currently selected in the drawer.
Mar 13 2023, 1:35 PM
InkaSokolowska committed rCOMM24839908bd81: [web] Split ThreadTopBar into two components.
Mar 13 2023, 1:35 PM
InkaSokolowska closed D6741: [web] Move logic for fetching ThreadInfo for possibly pending chat out of ChatMessageListContainer component.
Mar 13 2023, 1:35 PM
InkaSokolowska committed rCOMM15dad779d824: [web] Move logic for fetching ThreadInfo for possibly pending chat out of….
Mar 13 2023, 1:35 PM
michal updated the diff for D7031: [CI] Fix macos buildkite ci.

Rebase

Mar 13 2023, 1:30 PM
ashoat resigned from D7052: [direnv] Redirect `use flake` to `/dev/null` if `COMM_NIX_LOGGING_LEVEL` is "none".
Mar 13 2023, 1:09 PM
michal added a comment to D7017: [web] Added displaying 'Labels' to InlineEngagment.

Can you check what it looks like with the "Delivery failed. RETRY?" text which appears when sending a message, and attach a screenshot? Not sure if this case was considered in the designs.

Mar 13 2023, 1:03 PM
michal accepted D6965: [lib][native] Displaying edited messages from database.

Looks good to me, but I haven't worked with this code so it would be nice if someone else could also take a look.

Mar 13 2023, 12:59 PM
kamil added inline comments to D7032: [desktop] Handle autoUpdate errors.
Mar 13 2023, 12:54 PM
Harbormaster failed remote builds in B17288: Diff 23677 for D7024: [web] Implement AES encryption functions!
Mar 13 2023, 12:32 PM
bartek updated the diff for D7024: [web] Implement AES encryption functions.

Revert accidental changes

Mar 13 2023, 12:21 PM
bartek planned changes to D7024: [web] Implement AES encryption functions.
Mar 13 2023, 12:19 PM
bartek updated the diff for D7025: [web] Add unit tests for AES functions.
  • Rebase
  • Added new tests
Mar 13 2023, 12:19 PM
bartek updated the diff for D7024: [web] Implement AES encryption functions.
  • Rebase on new types
  • Address review feedback
    • Used consistent naming for ciphertext, sealed data etc.
Mar 13 2023, 12:18 PM
marcin updated the diff for D6917: Prepare to conditionally process rescinds in NSE..

Add comment explaining even release pattern

Mar 13 2023, 12:17 PM
Harbormaster failed remote builds in B17283: Diff 23672 for D7007: [native][AES] Implement encrypt function on Android!
Mar 13 2023, 12:09 PM
bartek updated the diff for D7008: [native][AES] Implement decrypt function on Android.

Address code review feedback

Mar 13 2023, 11:55 AM
bartek updated the diff for D7007: [native][AES] Implement encrypt function on Android.

Address code review feedback

Mar 13 2023, 11:55 AM
bartek updated the diff for D7006: [native][AES] Implement decrypt function on iOS.

Address code review feedback

Mar 13 2023, 11:55 AM
bartek updated the diff for D7005: [native][AES] Implement encrypt function on iOS.

Address code review feedback

Mar 13 2023, 11:54 AM
bartek updated the diff for D7004: [native][AES] Implement generateKey function.

Address code review feedback

Mar 13 2023, 11:54 AM
marcin added inline comments to D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start..
Mar 13 2023, 11:52 AM
bartek added a comment to D7005: [native][AES] Implement encrypt function on iOS.

Regarding all naming issues (applies to the whole stack), I've created a Notion doc that clarifies the names

Mar 13 2023, 11:14 AM
inka updated the diff for D6848: [web] Fix filter panel showing over the topbar.

Rebase

Mar 13 2023, 11:13 AM
bartek added inline comments to D7006: [native][AES] Implement decrypt function on iOS.
Mar 13 2023, 11:12 AM
inka updated the diff for D6845: [web] Style navigation state info in the top bar.

Remove unnnecessary div

Mar 13 2023, 11:10 AM
inka added inline comments to D6745: [web] Split ThreadTopBar into two components.
Mar 13 2023, 11:05 AM
marcin requested review of D7058: Use initial notifications from queue rather than from launch options.
Mar 13 2023, 11:02 AM
inka added inline comments to D6745: [web] Split ThreadTopBar into two components.
Mar 13 2023, 11:01 AM
kuba attached a referenced file: F425177: Screenshot 2023-03-13 at 11.24.47.png.
Mar 13 2023, 10:34 AM
kuba added a comment to D6963: [lib] Added new MessageSpec for editing messages.
In D6963#208218, @ginsu wrote:

I think we should consider if we also need shimUnsupportedMessageInfo and unshimMessageInfo. These functions will help us support older native clients that haven't been updated yet.

Mar 13 2023, 10:32 AM
kuba updated the diff for D6963: [lib] Added new MessageSpec for editing messages.

Responded to comments

Mar 13 2023, 10:32 AM
bartek updated the summary of D7024: [web] Implement AES encryption functions.
Mar 13 2023, 10:22 AM
kamil accepted D6845: [web] Style navigation state info in the top bar.
Mar 13 2023, 9:37 AM
ginsu updated the summary of D7057: [native] render avatar in profile screen.
Mar 13 2023, 8:25 AM
kamil closed D6994: [web-db] implement types for `SubtleCrypto` module.
Mar 13 2023, 8:13 AM
kamil committed rCOMM498483793f2e: [web-db] implement types for `SubtleCrypto` module.
Mar 13 2023, 8:13 AM
bartek published D7056: [native] Remove network.json fallbacks for review.
Mar 13 2023, 7:12 AM
ginsu updated the summary of D7057: [native] render avatar in profile screen.
Mar 13 2023, 6:52 AM
ginsu requested review of D7057: [native] render avatar in profile screen.
Mar 13 2023, 6:52 AM
bartek abandoned D7023: [web] Add Flow types for WebCrypto / SubtleCrypto.

Replaced by D6994

Mar 13 2023, 6:50 AM
bartek accepted D6994: [web-db] implement types for `SubtleCrypto` module.

LGTM, Works with my changes. Thank you for taking care of this!

Mar 13 2023, 6:48 AM
ginsu requested review of D7055: [native] introduce Avatar component.
Mar 13 2023, 6:22 AM
ginsu requested review of D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Mar 13 2023, 6:08 AM
ginsu added inline comments to D7053: [lib] introduce getAvatarForUser in avatar-utils.
Mar 13 2023, 5:47 AM
ginsu attached a referenced file: F424838: Screenshot 2023-03-13 at 1.22.55 AM.png.
Mar 13 2023, 5:46 AM
ginsu attached a referenced file: F424840: Screenshot 2023-03-13 at 1.43.52 AM.png.
Mar 13 2023, 5:46 AM
ginsu requested review of D7053: [lib] introduce getAvatarForUser in avatar-utils.
Mar 13 2023, 5:46 AM
jon added inline comments to D7052: [direnv] Redirect `use flake` to `/dev/null` if `COMM_NIX_LOGGING_LEVEL` is "none".
Mar 13 2023, 3:05 AM
atul published D7052: [direnv] Redirect `use flake` to `/dev/null` if `COMM_NIX_LOGGING_LEVEL` is "none" for review.
Mar 13 2023, 2:07 AM
atul attached a referenced file: F424535: 5eb0cb.png.
Mar 13 2023, 1:40 AM
atul added inline comments to D7051: [keyserver] Send `SIGNED_IDENTITY_KEYS_BLOB` request to client if data missing in DB.
Mar 13 2023, 1:40 AM
atul published D7051: [keyserver] Send `SIGNED_IDENTITY_KEYS_BLOB` request to client if data missing in DB for review.
Mar 13 2023, 12:59 AM

Mar 12 2023

atul updated the diff for D7050: [keyserver] Introduce `isCookieMissingSignedIdentityKeysBlob`.

fix..

Mar 12 2023, 11:20 PM
atul published D7050: [keyserver] Introduce `isCookieMissingSignedIdentityKeysBlob` for review.
Mar 12 2023, 11:16 PM
atul requested changes to D4779: [lintstaged] Add cmake-lint to lintstagedrc.
Mar 12 2023, 11:08 PM
atul removed a reviewer for D4779: [lintstaged] Add cmake-lint to lintstagedrc: abosh.
Mar 12 2023, 11:08 PM