Page MenuHomePhabricator
Feed All Stories

Mar 28 2024

Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM36cd50031add: [web] Use crypto store and olm from shared worker (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web] Use crypto store and olm from shared worker
Mar 28 2024, 3:58 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMd3bc189df896: [web/native] Add signMessage to olmAPI (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web/native] Add signMessage to olmAPI
Mar 28 2024, 3:58 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMbe6c43405452: [web] Migrate crypto store to shared worker (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web] Migrate crypto store to shared worker
Mar 28 2024, 3:58 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D11372: [web/native] Create tunnelbroker init message on connection.
Mar 28 2024, 3:58 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D11373: [web] Use shared worker crypto store in identity client provider.
Mar 28 2024, 3:58 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMc95d85e89e2f: [web] Use shared worker crypto store in identity client provider (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web] Use shared worker crypto store in identity client provider
Mar 28 2024, 3:58 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM9e3da11b867f: [web/native] Create tunnelbroker init message on connection (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web/native] Create tunnelbroker init message on connection
Mar 28 2024, 3:58 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D11347: [web/native] Use olmAPI instead of `OlmSessionCreatorContext`.
Mar 28 2024, 3:58 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM925f1b6550b5: [web/native] Use olmAPI instead of `OlmSessionCreatorContext` (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web/native] Use olmAPI instead of `OlmSessionCreatorContext`
Mar 28 2024, 3:58 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D11385: [web] Pass platform details to worker.
Mar 28 2024, 3:55 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D11342: [web/native] Move notificationsSessionCreator to olmAPI.
Mar 28 2024, 3:55 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMc3489d7b6f5b: [web/native] Move notificationsSessionCreator to olmAPI (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web/native] Move notificationsSessionCreator to olmAPI
Mar 28 2024, 3:55 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM5bcdfa0eff68: [web] Pass platform details to worker (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web] Pass platform details to worker
Mar 28 2024, 3:55 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D11341: [web] Olm session creation between own devices.
Mar 28 2024, 3:55 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D11340: [web/native] Add getUserPublicKey to olmAPI.
Mar 28 2024, 3:55 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM90a9d4b9e87e: [web] Olm session creation between own devices (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web] Olm session creation between own devices
Mar 28 2024, 3:55 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMaa155a4a7e69: [web/native] Add getUserPublicKey to olmAPI (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web/native] Add getUserPublicKey to olmAPI
Mar 28 2024, 3:55 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D11339: [web/native] Add content outbound session to olmAPI.
Mar 28 2024, 3:55 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM6269b7df59c6: [web/native] Add content outbound session to olmAPI (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web/native] Add content outbound session to olmAPI
Mar 28 2024, 3:55 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D11338: [web] olmAPI on shared worker.
Mar 28 2024, 3:55 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMb46454f32943: [web] olmAPI on shared worker (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[web] olmAPI on shared worker
Mar 28 2024, 3:55 AM
kamil accepted D11369: [lib] Create a wrapper over dispatch.
Mar 28 2024, 3:54 AM
tomek accepted D11433: [lib][web][native] add unlinkFarcasterAccount to IdentityServiceClient interface and implementations.
Mar 28 2024, 3:54 AM
kamil accepted D11368: [native][web] Remove processing the ops from reducers.
Mar 28 2024, 3:52 AM
kamil accepted D11367: [lib] Handle processing of the ops.
Mar 28 2024, 3:49 AM
bartek closed D11378: [protos] Rename UpdateDeviceListForUser RPC to UpdateDeviceList.
Mar 28 2024, 12:03 AM
bartek committed rCOMM9f580a5f8191: [protos] Rename UpdateDeviceListForUser RPC to UpdateDeviceList (authored by bartek).
[protos] Rename UpdateDeviceListForUser RPC to UpdateDeviceList
Mar 28 2024, 12:03 AM

Mar 27 2024

bartek accepted D11431: [native] add unlinkFarcasterAccount to CommRustModule.
Mar 27 2024, 11:59 PM
bartek accepted D11430: [native_rust_library] unlink_farcaster_account method.
Mar 27 2024, 11:59 PM
bartek accepted D11423: [identity] unlink farcaster account RPC.
Mar 27 2024, 11:58 PM
bartek accepted D11413: [identity] on linkFarcasterUser we should return an error if the FID already exists for a different user in the users table.
Mar 27 2024, 11:58 PM
bartek accepted D11412: [identity] check if fid is already taken when registering new user.

Read the issue and seems like it was unrelated to this code.

Mar 27 2024, 11:57 PM
bartek updated the diff for D11379: [protos][identity] Add RPC to find username by user ID.
  • Made get_user_identifier() return Option
  • Updated callsites to return Status::not_found if missing identifier
Mar 27 2024, 11:35 PM
bartek accepted D11411: [identity] don't let linkFarcasterAccount overwrite existing fid for user.
Mar 27 2024, 11:20 PM
bartek accepted D11408: [native] add linkFarcasterAccount to commRustModule.
Mar 27 2024, 11:08 PM
bartek accepted D11407: [native_rust_library] implement link_farcaster_account client method.
Mar 27 2024, 11:06 PM
bartek accepted D11406: [identity] link farcaster account implementation.
Mar 27 2024, 11:05 PM
bartek accepted D11404: [native] add getFarcasterUsers to commRustModule.
Mar 27 2024, 11:02 PM
bartek accepted D11403: [native_rust_library] get_farcaster_users client method.
Mar 27 2024, 11:01 PM
bartek accepted D11402: [identity] get farcaster users rpc implementation.
Mar 27 2024, 10:55 PM
bartek requested changes to D11401: [identity] db method to get users for a set of farcaster ids.

Requesting changes to discuss possible usage of BatchGetItem

Mar 27 2024, 10:54 PM
bartek added inline comments to D11401: [identity] db method to get users for a set of farcaster ids.
Mar 27 2024, 10:43 PM
bartek accepted D11400: [terraform] add GSI for farcasterID.
Mar 27 2024, 10:27 PM
bartek accepted D11399: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs.
Mar 27 2024, 10:26 PM
bartek accepted D11398: [native] expose farcaster id param to native identity service context provider.
Mar 27 2024, 10:24 PM
bartek accepted D11396: [proto][identity] add optional fid to registration request messages.
Mar 27 2024, 10:23 PM
ginsu requested review of D11434: [native] introduce FarcasterLogo.
Mar 27 2024, 10:06 PM
varun requested review of D11433: [lib][web][native] add unlinkFarcasterAccount to IdentityServiceClient interface and implementations.
Mar 27 2024, 9:51 PM
ginsu requested review of D11432: [landing/lib/native] introduce FarcasterWebView.
Mar 27 2024, 9:44 PM
varun requested review of D11431: [native] add unlinkFarcasterAccount to CommRustModule.
Mar 27 2024, 9:38 PM
varun requested review of D11430: [native_rust_library] unlink_farcaster_account method.
Mar 27 2024, 9:36 PM
ginsu requested review of D11429: [landing] introduce /connect-farcaster route.
Mar 27 2024, 9:34 PM
ginsu requested review of D11428: [landing] introduce ConnectFarcaster.
Mar 27 2024, 9:30 PM
ginsu requested review of D11427: [keyserver/landing] add @babel/plugin-transform-private-methods to list of plugins.
Mar 27 2024, 9:16 PM
ginsu accepted D11425: [lib][native] FIDProvider.
Mar 27 2024, 8:43 PM
ginsu updated the summary of D11426: [landing] add @farcaster/auth-kit dep.
Mar 27 2024, 8:42 PM
ginsu updated the summary of D11426: [landing] add @farcaster/auth-kit dep.
Mar 27 2024, 8:42 PM
ginsu requested review of D11426: [landing] add @farcaster/auth-kit dep.
Mar 27 2024, 8:38 PM
varun added a comment to D11412: [identity] check if fid is already taken when registering new user.

@varun looking at the test plan here, is it fair to say you weren't able to reproduce ENG-7390? Is it worth trying to test via the UI to see if that reproduces it?

Mar 27 2024, 8:12 PM
varun added a comment to D11410: [web] add client methods to web.

Do we need to update anything for registerPasswordUser or registerWalletUser on web?

Mar 27 2024, 7:15 PM
will added a comment to D11425: [lib][native] FIDProvider.

Here's the linear issue for replacing usages of the FIDProvider and reverting once it's no longer needed:
https://linear.app/comm/issue/ENG-7590/replace-all-fidprovider-usages-with-synced-metadata-store

Mar 27 2024, 6:56 PM
will accepted D11425: [lib][native] FIDProvider.
Mar 27 2024, 6:51 PM
ashoat requested review of D11425: [lib][native] FIDProvider.
Mar 27 2024, 6:03 PM
will requested review of D11424: [native][web] read synced metadata on app startup.
Mar 27 2024, 5:44 PM
ashoat added inline comments to D11418: [sqlite] implement C++ synced metadata store ops.
Mar 27 2024, 5:41 PM
ashoat accepted D11423: [identity] unlink farcaster account RPC.

Guessing the plumbing for native (and the rest of the plumbing for web) will come in a later diff

Mar 27 2024, 5:34 PM
ashoat added a comment to D11410: [web] add client methods to web.

Do we need to update anything for registerPasswordUser or registerWalletUser on web?

Mar 27 2024, 5:33 PM
ashoat accepted D11398: [native] expose farcaster id param to native identity service context provider.
Mar 27 2024, 5:32 PM
ashoat added a comment to D11412: [identity] check if fid is already taken when registering new user.

@varun looking at the test plan here, is it fair to say you weren't able to reproduce ENG-7390? Is it worth trying to test via the UI to see if that reproduces it?

Mar 27 2024, 5:29 PM
ashoat added a comment to D11411: [identity] don't let linkFarcasterAccount overwrite existing fid for user.
Mar 27 2024, 5:28 PM
ashoat accepted D11410: [web] add client methods to web.
Mar 27 2024, 5:25 PM
ashoat accepted D11409: [native] add linkFarcasterAccount to native IdentityServiceContextProvider.
Mar 27 2024, 5:23 PM
ashoat accepted D11405: [lib][native] Add getFarcasterUsers to IdentityServiceContextProvider.
Mar 27 2024, 5:22 PM
ashoat accepted D11399: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs.
Mar 27 2024, 5:21 PM
ashoat accepted D11396: [proto][identity] add optional fid to registration request messages.
Mar 27 2024, 5:19 PM
will updated the summary of D11422: [lib/native/web] introduce synced metadata reducer.
Mar 27 2024, 5:15 PM
ashoat added inline comments to D11368: [native][web] Remove processing the ops from reducers.
Mar 27 2024, 5:15 PM
will updated the diff for D11422: [lib/native/web] introduce synced metadata reducer.

add support for the remove synced metadata action type

Mar 27 2024, 5:14 PM
ashoat added inline comments to D11393: [lib] Add preRequestUserState to identity login.
Mar 27 2024, 5:12 PM
ashoat added inline comments to D11394: [lib][web][native] Handle idnentity login in reducers.
Mar 27 2024, 5:11 PM
will updated the test plan for D11422: [lib/native/web] introduce synced metadata reducer.
Mar 27 2024, 5:10 PM
varun requested review of D11423: [identity] unlink farcaster account RPC.
Mar 27 2024, 5:06 PM
will planned changes to D11422: [lib/native/web] introduce synced metadata reducer.
Mar 27 2024, 5:05 PM
will requested review of D11422: [lib/native/web] introduce synced metadata reducer.
Mar 27 2024, 4:33 PM
will requested review of D11421: [lib] introduce sync metadata add and remove action types.
Mar 27 2024, 4:29 PM
will requested review of D11420: [sqlite] implement processing synced metadata store ops on worker.
Mar 27 2024, 4:25 PM
will updated the summary of D11419: [sqlite] implement C++ code to get synced metadata.
Mar 27 2024, 4:10 PM
will requested review of D11419: [sqlite] implement C++ code to get synced metadata.
Mar 27 2024, 3:46 PM
will requested review of D11418: [sqlite] implement C++ synced metadata store ops.
Mar 27 2024, 3:41 PM
varun added inline comments to D11398: [native] expose farcaster id param to native identity service context provider.
Mar 27 2024, 3:22 PM
will requested review of D11417: [sqlite] add methods to operate on synced metadata table.
Mar 27 2024, 2:11 PM
Harbormaster failed remote builds in B27732: Diff 38395 for D11398: [native] expose farcaster id param to native identity service context provider!
Mar 27 2024, 2:06 PM
will requested review of D11416: [sqlite] add sync metadata table to sqlite.
Mar 27 2024, 2:04 PM
varun updated the test plan for D11401: [identity] db method to get users for a set of farcaster ids.
Mar 27 2024, 1:59 PM
will requested review of D11415: [lib] introduce SyncedMetadata store spec.
Mar 27 2024, 1:59 PM
varun updated the diff for D11402: [identity] get farcaster users rpc implementation.

rebase, but nothing changed

Mar 27 2024, 1:58 PM
will requested review of D11414: [lib] introduce synced metadata types.
Mar 27 2024, 1:57 PM
varun updated the diff for D11398: [native] expose farcaster id param to native identity service context provider.

remove TODOs. Here's the linear task, instead: https://linear.app/comm/issue/ENG-7588/replace-params-in-native-rust-library-methods-with-serialized-structs

Mar 27 2024, 1:56 PM
varun requested review of D11413: [identity] on linkFarcasterUser we should return an error if the FID already exists for a different user in the users table.
Mar 27 2024, 1:52 PM
varun added inline comments to D11401: [identity] db method to get users for a set of farcaster ids.
Mar 27 2024, 1:50 PM