Rename shouldRestart, start db intialization on load, add comment for transform migration
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Sep 11 2023
Change initError to notSupported, move safari key init after setting status to initInProgress
Sep 8 2023
Instead of removing the previous migration, make it noop.
Sep 7 2023
Change temporary docker repo to commapp
Sep 5 2023
LGTM, could you check that it still works with something like this:
Sep 4 2023
Sep 1 2023
Aug 31 2023
More consistent vec creation
LGTM, would be good for someone working on identity to look over this
LGTM (would be nice to have ENG-4548)
Is there a reason for not building dependencies on another layer?
The whole native, with some exceptions, is already added.
Can we also add native/native_rust_library/target?
Adding tomek as blocking because of new deps. Left some comments regarding the rust code side, but I'm not really familiar with crypto so hoping someone else will also look at it
Aug 30 2023
Landed D8966 so we can cancel this
Rebase, improve how we skip the latest backup when removing old backups (search for the backup with max creation time)
Rebase, fix typos, introduce get_named_text_field function
Would something like this work?
Aug 29 2023
I'm probably going to land the test improvements this morning, but accepting if it's blocking someone. I will rebase over this diff if required. If I land first we cancel this
Adding @tomek because of a new dependency
Adding @tomek because of new dependency
This and the next diffs seem a bit complicated for the email configuration. I'm going to accept them because this is probably more of a preference but what do you think about:
- Moving the "token replacement from env", from FromStr to the parse method introduces later in the stack. I don't I have ever seen a non-pure from_str so that feels weird to me
- Instead of having a #[clap(ignore)] OnceCell, add a email config to the reports service (probably as an Option<>), and just fill it once during init
LGTM, it's really similar to the previous diff, so I'm assuming any react native stuff will get solved there
LGTM on the backup api, not accepting because it seems like there is some discussion on react-native side, that I'm not very familiar
This is a larger change that we probably don't need to implement but what about creating something more like this:
const httpEndpoints = Object.freeze({ UPLOAD_BACKUP: () => { path: '/backups', method: 'POST', }, GET_USER_KEYS_AUTH: (backup_id) => { path: `/backups/${backup_id}/user_keys`, method: 'GET', },
Maybe even add an argument for auth identity, and make the returned objects contain headers?: string[], that would be added with spread operator to the other headers?
Aug 28 2023
Note that blob cleanup (if error occurs later during upload) will be added in another diff.