Page MenuHomePhabricator
Feed Advanced Search

Sep 11 2023

michal updated the diff for D9109: [web] Enable db for all users.

Rename shouldRestart, start db intialization on load, add comment for transform migration

Sep 11 2023, 1:25 AM
michal updated the diff for D9108: [web] Initialize database at startup on safari.

Change initError to notSupported, move safari key init after setting status to initInProgress

Sep 11 2023, 12:32 AM

Sep 8 2023

michal updated the diff for D9110: [web] Migrate drafts to db for everyone.

Instead of removing the previous migration, make it noop.

Sep 8 2023, 7:52 AM
michal requested review of D9111: [keyserver] Remove old current user info.
Sep 8 2023, 7:52 AM
michal requested review of D9110: [web] Migrate drafts to db for everyone.
Sep 8 2023, 7:12 AM
michal requested review of D9109: [web] Enable db for all users.
Sep 8 2023, 6:58 AM
michal requested review of D9108: [web] Initialize database at startup on safari.
Sep 8 2023, 6:07 AM
michal requested review of D9107: [web] Move safari db key init to database module.
Sep 8 2023, 5:54 AM
michal requested review of D9105: [web] Hide databaseModule behind a function.
Sep 8 2023, 4:20 AM

Sep 7 2023

michal updated the diff for D9066: [backup] Setup terraform.

Change temporary docker repo to commapp

Sep 7 2023, 2:30 AM
michal commandeered D9038: [terraform] Set up ECS Service Connect.
Sep 7 2023, 2:07 AM

Sep 5 2023

michal accepted D9078: [keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux top level.

LGTM, could you check that it still works with something like this:

Sep 5 2023, 5:56 AM
michal accepted D9075: [client-backup] set backup-service prod URL.
Sep 5 2023, 5:52 AM
michal accepted D9079: [lib][web][native] Start using lastCommunicatedPlatformDetailsSelector from keyserverStore.
Sep 5 2023, 5:49 AM
michal accepted D9077: [keyserver][lib][native] Add lastCommunicatedPlatformDetails to keyserverStore.
Sep 5 2023, 5:49 AM
michal accepted D9062: [web] Start persisting keyserverStore.
Sep 5 2023, 5:46 AM
michal accepted D9082: [client-backup] exclude non-password users.
Sep 5 2023, 5:29 AM
michal accepted D9080: [client-backup] rename `recentBackupHash` -> `mostRecentlyUploadedBackupHash`.
Sep 5 2023, 5:26 AM
michal accepted D9038: [terraform] Set up ECS Service Connect.
Sep 5 2023, 12:44 AM

Sep 4 2023

michal accepted D9010: [client-backup] add local settings to store.
Sep 4 2023, 8:34 AM
michal accepted D9003: [client-backup] implement backup handler.
Sep 4 2023, 8:31 AM
michal requested changes to D9062: [web] Start persisting keyserverStore.
Sep 4 2023, 4:10 AM

Sep 1 2023

michal requested review of D9066: [backup] Setup terraform.
Sep 1 2023, 7:39 AM
michal requested review of D9065: [backup] Make blob url configurable with env var.
Sep 1 2023, 7:34 AM
michal requested review of D9064: [backup] Add health endpoint.
Sep 1 2023, 7:33 AM
michal requested review of D9063: [backup] Update backup dockerfile.
Sep 1 2023, 7:32 AM
michal accepted D9062: [web] Start persisting keyserverStore.

LGTM

Sep 1 2023, 6:28 AM
michal accepted D9060: [lib] Refactor lastCommunicatedPlatformDetails to be PlatformDetails.
Sep 1 2023, 6:27 AM

Aug 31 2023

michal added inline comments to D9016: [backup] Improve attachment handling.
Aug 31 2023, 7:37 AM
michal updated the diff for D9016: [backup] Improve attachment handling.

More consistent vec creation

Aug 31 2023, 7:37 AM
michal added a comment to D9038: [terraform] Set up ECS Service Connect.

LGTM, would be good for someone working on identity to look over this

Aug 31 2023, 7:26 AM
michal accepted D9040: [terraform] Add reports service.

LGTM (would be nice to have ENG-4548)

Aug 31 2023, 7:26 AM
michal accepted D9037: [reports-service] Add Dockerfile.

Is there a reason for not building dependencies on another layer?

Aug 31 2023, 7:06 AM
michal added a comment to D9036: [dockerignore] Add missing entries.

The whole native, with some exceptions, is already added.

Aug 31 2023, 6:25 AM
michal accepted D9039: [secrets] Add e-mail config for reports.
Aug 31 2023, 2:53 AM
michal accepted D9036: [dockerignore] Add missing entries.

Can we also add native/native_rust_library/target?

Aug 31 2023, 2:25 AM
michal accepted D9035: [reports-service] Encrypt reports.
Aug 31 2023, 1:50 AM
michal accepted D9046: [terraform] Add workspace check.
Aug 31 2023, 1:41 AM
michal added 1 blocking reviewer(s) for D9034: [services-lib] Introduce crypto module: tomek.

Adding tomek as blocking because of new deps. Left some comments regarding the rust code side, but I'm not really familiar with crypto so hoping someone else will also look at it

Aug 31 2023, 1:38 AM

Aug 30 2023

michal added inline comments to D9002: [client-backup] implement initial restore backup protocol.
Aug 30 2023, 7:08 AM
michal accepted D9001: [client-backup] implement initial backup protocol.
Aug 30 2023, 7:04 AM
michal accepted D9023: [keyserver][lib][native][web] Remove connection field from redux.
Aug 30 2023, 6:15 AM
michal accepted D9022: [lib][native][web] Use connection from keyserverStore.
Aug 30 2023, 6:14 AM
michal accepted D9021: [keyserver][lib][native] Add connection to keyserverStore.
Aug 30 2023, 5:58 AM
michal accepted D9020: [lib][native] Stop persisting connection.
Aug 30 2023, 5:53 AM
michal accepted D9018: [kesyerver][lib][native][web] Move actualizedCalendarQuery out of connection.
Aug 30 2023, 5:52 AM
michal requested review of D9019: [backup] Update db constants.
Aug 30 2023, 3:02 AM
michal requested review of D9017: [backup] Cleanup utils.
Aug 30 2023, 2:50 AM
michal requested review of D9016: [backup] Improve attachment handling.
Aug 30 2023, 2:44 AM
michal added 1 blocking reviewer(s) for D8987: [reports-service] Add functions to send e-mails: tomek.
Aug 30 2023, 1:54 AM
michal added 1 blocking reviewer(s) for D8983: [reports-service] Introduce e-mail template: tomek.
Aug 30 2023, 1:53 AM
michal added 1 blocking reviewer(s) for D8975: [reports-service] Implement Blob storage: tomek.
Aug 30 2023, 1:53 AM
michal requested changes to D9014: [Commtest] Remove backup gRPC tests.

Landed D8966 so we can cancel this

Aug 30 2023, 1:28 AM
michal updated the diff for D8969: [Backup] Old backup cleanup.

Rebase, improve how we skip the latest backup when removing old backups (search for the backup with max creation time)

Aug 30 2023, 1:06 AM
michal updated the diff for D8963: [backup] Introduce upload endpoint.

Rebase, fix typos, introduce get_named_text_field function

Aug 30 2023, 12:58 AM
michal added a comment to D8978: [reports-service] Introduce emails config.

Would something like this work?

Aug 30 2023, 12:01 AM

Aug 29 2023

michal accepted D9014: [Commtest] Remove backup gRPC tests.

I'm probably going to land the test improvements this morning, but accepting if it's blocking someone. I will rebase over this diff if required. If I land first we cancel this

Aug 29 2023, 11:10 PM
michal added inline comments to D8962: [backup] Update `BlobItem`.
Aug 29 2023, 10:55 AM
michal updated the diff for D8953: [backup] Split database module.

Fix constant

Aug 29 2023, 10:53 AM
michal added inline comments to D8953: [backup] Split database module.
Aug 29 2023, 10:53 AM
michal added inline comments to D8952: [backup] Introduce backup error.
Aug 29 2023, 10:48 AM
michal added inline comments to D9003: [client-backup] implement backup handler.
Aug 29 2023, 10:34 AM
michal added inline comments to D8988: [reports-service] Send e-mails when received reports.
Aug 29 2023, 10:19 AM
michal accepted D8988: [reports-service] Send e-mails when received reports.
Aug 29 2023, 9:56 AM
michal accepted D8987: [reports-service] Add functions to send e-mails.

Adding @tomek because of a new dependency

Aug 29 2023, 9:49 AM
michal accepted D8986: [reports-service] E-mail: inconsistency report details.
Aug 29 2023, 9:45 AM
michal accepted D8985: [reports-service] E-mail: download links and JSON preview.
Aug 29 2023, 9:37 AM
michal accepted D8984: [reports-service] E-mail subject and summary text.
Aug 29 2023, 9:31 AM
michal accepted D8983: [reports-service] Introduce e-mail template.

Adding @tomek because of new dependency

Aug 29 2023, 9:19 AM
michal accepted D8994: [client-backup] implement API call to get BackupID.
Aug 29 2023, 9:08 AM
michal accepted D8990: [client-backup] add backup-service facts.
Aug 29 2023, 9:06 AM
michal added a reviewer for D8975: [reports-service] Implement Blob storage: tomek.

Adding @tomek because of new dependency while @ashoat is unavailable

Aug 29 2023, 9:05 AM
michal accepted D8980: [reports-service] Parse email config from CLI args.
Aug 29 2023, 8:46 AM
michal accepted D8978: [reports-service] Introduce emails config.

This and the next diffs seem a bit complicated for the email configuration. I'm going to accept them because this is probably more of a preference but what do you think about:

  1. Moving the "token replacement from env", from FromStr to the parse method introduces later in the stack. I don't I have ever seen a non-pure from_str so that feels weird to me
  2. Instead of having a #[clap(ignore)] OnceCell, add a email config to the reports service (probably as an Option<>), and just fill it once during init
Aug 29 2023, 8:45 AM
michal added inline comments to D9002: [client-backup] implement initial restore backup protocol.
Aug 29 2023, 8:02 AM
michal added inline comments to D9001: [client-backup] implement initial backup protocol.
Aug 29 2023, 8:02 AM
michal accepted D8996: [client-backup] implement API call to get UserData.

LGTM, it's really similar to the previous diff, so I'm assuming any react native stuff will get solved there

Aug 29 2023, 7:52 AM
michal added a comment to D8995: [client-backup] implement API call to get UserKeys.

LGTM on the backup api, not accepting because it seems like there is some discussion on react-native side, that I'm not very familiar

Aug 29 2023, 7:50 AM
michal added a comment to D8990: [client-backup] add backup-service facts.

This is a larger change that we probably don't need to implement but what about creating something more like this:

const httpEndpoints = Object.freeze({
  UPLOAD_BACKUP: () => {
    path: '/backups',
    method: 'POST',
  },
  GET_USER_KEYS_AUTH: (backup_id) => {
    path: `/backups/${backup_id}/user_keys`,
    method: 'GET',
  },

Maybe even add an argument for auth identity, and make the returned objects contain headers?: string[], that would be added with spread operator to the other headers?

Aug 29 2023, 7:44 AM
michal added inline comments to D8990: [client-backup] add backup-service facts.
Aug 29 2023, 7:39 AM
michal added inline comments to D8994: [client-backup] implement API call to get BackupID.
Aug 29 2023, 7:31 AM
michal added inline comments to D8990: [client-backup] add backup-service facts.
Aug 29 2023, 7:12 AM
michal accepted D8888: [client-backup] implement C++ functions for encoding/decoding string in `utf-8`.
Aug 29 2023, 5:59 AM
michal accepted D8786: [services-lib] Add HTTP client auth support.
Aug 29 2023, 5:35 AM
michal accepted D8974: [services-lib][blob-client] Use Bytes instead of Vec<u8>.
Aug 29 2023, 5:35 AM

Aug 28 2023

michal accepted D8973: [reports-service] Endpoint for listing reports.
Aug 28 2023, 6:53 AM
michal accepted D8972: [reports-service] Endpoint for Redux Devtools import.
Aug 28 2023, 6:51 AM
michal added inline comments to D8963: [backup] Introduce upload endpoint.
Aug 28 2023, 6:45 AM
michal added inline comments to D8965: [backup] Implement download latest endpoints.
Aug 28 2023, 6:33 AM
michal added inline comments to D8969: [Backup] Old backup cleanup.
Aug 28 2023, 6:32 AM
michal added inline comments to D8959: [blob-service] Remove gRPC service, change default port.
Aug 28 2023, 4:44 AM
michal accepted D8971: [reports-service] Endpoint for viewing single report.
Aug 28 2023, 4:33 AM
michal accepted D8970: [reports-service] Endpoint for uploading reports.
Aug 28 2023, 4:30 AM
michal accepted D8968: [reports-service] Add service error types.
Aug 28 2023, 4:16 AM
michal requested review of D8969: [Backup] Old backup cleanup.
Aug 28 2023, 2:55 AM
michal requested review of D8967: [backup] Revoke holders on upload error.
Aug 28 2023, 2:52 AM
michal requested review of D8965: [backup] Implement download latest endpoints.
Aug 28 2023, 2:19 AM
michal added a comment to D8963: [backup] Introduce upload endpoint.

Note that blob cleanup (if error occurs later during upload) will be added in another diff.

Aug 28 2023, 2:18 AM
michal requested review of D8964: [backup] Introduce download endpoints.
Aug 28 2023, 2:07 AM
michal requested review of D8963: [backup] Introduce upload endpoint.
Aug 28 2023, 1:52 AM