Page MenuHomePhabricator
Feed All Stories

Fri, Apr 26

marcin accepted D11726: [SQLite/lib] implement shared SQLite interface.
Fri, Apr 26, 7:15 AM
marcin accepted D11723: [SQLite] add queries to decrypted messages table.
Fri, Apr 26, 7:14 AM
marcin accepted D11722: [SQLite] add table to persist decrypted messages.
Fri, Apr 26, 7:13 AM
tomek planned changes to D11800: [lib] Properly handle hashing in progress.
Fri, Apr 26, 7:11 AM
tomek requested review of D11800: [lib] Properly handle hashing in progress.
Fri, Apr 26, 7:08 AM
marcin updated the diff for D11757: [SIWE] Differentiate content for social proof and backup message..

Use more specific type

Fri, Apr 26, 7:02 AM
inka accepted D11769: [lib] Don't set dataLoaded on authoritative keyserver auth.
Fri, Apr 26, 7:00 AM
inka accepted D11764: [lib][native][web] Rename useLogIn to useLegacyLogIn.

Should we rename siweAuthActionTypes to legacySiweAuthActionTypes and keyserverRegisterActionTypes to legacyKeyserverRegisterActionTypes?

Fri, Apr 26, 6:57 AM
marcin added inline comments to D11757: [SIWE] Differentiate content for social proof and backup message..
Fri, Apr 26, 6:56 AM
inka accepted D11768: [lib][native][web] Introduce useWalletLogIn hook.
Fri, Apr 26, 6:53 AM
inka accepted D11767: [native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity registration.
Fri, Apr 26, 6:27 AM
marcin updated the diff for D11735: Introduce new JSI call to retrieve backup message for latest siwe backup.
  1. Rename msg_backup to siwe_backup_message
  2. Fix JSI type
Fri, Apr 26, 6:26 AM
marcin updated the diff for D11734: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'.
  1. Rename msg_backup to siwe_backup_msg
  2. Simplify code.
Fri, Apr 26, 6:25 AM
marcin updated the diff for D11733: Update latest backup id search index to include 'msgBackup'.

Rename msgBackup to siweBackupMsg

Fri, Apr 26, 6:24 AM
marcin updated the diff for D11716: Enable backup creation and upload for SIWE users from JS.

Rebase

Fri, Apr 26, 6:23 AM
marcin updated the diff for D11715: Update native backup code to handle siwe backup message.
  1. Rename msg_backup to siwe_backup_msg
  2. Introcuce separate backup creation JSI calls for SIWE and password users to avoid macking empty string or potential crashes if dev forgets to specify null
Fri, Apr 26, 6:23 AM
marcin updated the diff for D11714: Introduce function to get path to a file to temporarily save backup message.

rename msgbackup to siweBackupMsg

Fri, Apr 26, 6:21 AM
marcin updated the diff for D11713: Introduce msg_backup field to BackupItem.
  1. Simplify code
  2. rename msg_backup to siwe_backup_msg
Fri, Apr 26, 6:20 AM
marcin updated the diff for D11782: Let the user skip backup message generation and record it in alert store.

Remove unecessary useState

Fri, Apr 26, 6:19 AM
marcin added a comment to D11714: Introduce function to get path to a file to temporarily save backup message.

Could you explain why we need backupID? The message to sign seems generic and wondering if we need a separate file for each backupID

For each backupID we specify backup message that was used to encrypt backup with backup id. Theoretically we can have distinct backup message for each backup id. However your suggestion would work. The reason for that is backup message stays the same as long as SIWE user is logged in. And when the user logs out we delete entire content of backup directory anyway. So for now it is not possible for the compaction files to be encrypted with different backup message. I am not suer however if this assumption could be broken in future. I will give it some thought.

Fri, Apr 26, 6:17 AM
inka accepted D11766: [lib][native] Defer saving user credentials until successful auth.
Fri, Apr 26, 6:04 AM
inka requested review of D11799: [lib] Search for users in thread list search.
Fri, Apr 26, 6:01 AM
inka accepted D11765: [lib][native][web] Introduce usePasswordLogIn hook.
Fri, Apr 26, 5:57 AM
inka accepted D11763: [native] Auth with authoritative keyserver directly from registration flow.
Fri, Apr 26, 5:38 AM
tomek accepted D11781: Move MissingRegistrationDataHandler to NavigationHandler.
Fri, Apr 26, 5:19 AM
marcin added inline comments to D11715: Update native backup code to handle siwe backup message.
Fri, Apr 26, 4:49 AM
inka updated the diff for D11780: [keyserver] Fix sending a user cookie when olm session creation failed.

Remove unnecessary code

Fri, Apr 26, 3:20 AM
inka added inline comments to D11780: [keyserver] Fix sending a user cookie when olm session creation failed.
Fri, Apr 26, 3:17 AM
marcin closed D11797: Bump backup service version.
Fri, Apr 26, 2:59 AM
marcin committed rCOMM5971c921d4af: Bump backup service version (authored by marcin).
Bump backup service version
Fri, Apr 26, 2:59 AM
marcin closed D11798: Update terraform hashes.
Fri, Apr 26, 2:59 AM
marcin committed rCOMM2659809835ad: Update terraform hashes (authored by marcin).
Update terraform hashes
Fri, Apr 26, 2:59 AM
inka added inline comments to D11780: [keyserver] Fix sending a user cookie when olm session creation failed.
Fri, Apr 26, 2:58 AM
inka updated the diff for D11780: [keyserver] Fix sending a user cookie when olm session creation failed.

Address review

Fri, Apr 26, 2:58 AM
bartek accepted D11798: Update terraform hashes.

I can confirm this works on my M1 Mac.
Some context why this is needed: https://stackoverflow.com/questions/67204811/terraform-failed-to-install-provider-doesnt-match-checksums-from-dependency-l

Fri, Apr 26, 2:58 AM
marcin published D11798: Update terraform hashes for review.
Fri, Apr 26, 2:57 AM
bartek accepted D11797: Bump backup service version.
Fri, Apr 26, 2:27 AM
marcin published D11797: Bump backup service version for review.
Fri, Apr 26, 2:27 AM
marcin added inline comments to D11782: Let the user skip backup message generation and record it in alert store.
Fri, Apr 26, 1:24 AM
bartek published D11778: [lib] Add device list signatures to Flow types for review.
Fri, Apr 26, 1:15 AM
bartek published D11777: [identity] Add device list signatures to serde for review.
Fri, Apr 26, 1:15 AM
bartek accepted D11796: [identity] delete all token data on user account deletion.
Fri, Apr 26, 1:14 AM
marcin accepted D11794: [native] Don't refetch nonce after SIWE is complete.
Fri, Apr 26, 1:10 AM
bartek accepted D11795: [identity] move access token table db methods to separate module.
Fri, Apr 26, 1:00 AM
kamil accepted D11716: Enable backup creation and upload for SIWE users from JS.
Fri, Apr 26, 12:40 AM
kamil added inline comments to D11715: Update native backup code to handle siwe backup message.
Fri, Apr 26, 12:39 AM
kamil accepted D11715: Update native backup code to handle siwe backup message.

I think you should rename the generic backup_message to siwe_backup_message

Fri, Apr 26, 12:36 AM
kamil added a comment to D11714: Introduce function to get path to a file to temporarily save backup message.

Two questions:

  1. Could you explain why we need backupID? The message to sign seems generic and wondering if we need a separate file for each backupID
  2. Is there an easy way to somehow unify getSIWEBackupMessagePath with getBackupUserKeysFilePath which is basically doing the same?
Fri, Apr 26, 12:25 AM
kamil accepted D11713: Introduce msg_backup field to BackupItem.
Fri, Apr 26, 12:20 AM

Thu, Apr 25

varun accepted D11711: [identity] Add verification for replacing a device.
Thu, Apr 25, 10:09 PM
will closed D11744: [identity] add env var conditional json tracing.
Thu, Apr 25, 9:28 PM
will committed rCOMM0b3bd2ef4147: [identity] add env var conditional json tracing (authored by will).
[identity] add env var conditional json tracing
Thu, Apr 25, 9:28 PM
will updated the diff for D11744: [identity] add env var conditional json tracing.

rebase

Thu, Apr 25, 9:25 PM
will updated the diff for D11744: [identity] add env var conditional json tracing.

rebase

Thu, Apr 25, 9:18 PM
will closed D11743: [terraform] Warning message typo.
Thu, Apr 25, 9:16 PM
will committed rCOMM36426c2b3761: [terraform] Warning message typo (authored by will).
[terraform] Warning message typo
Thu, Apr 25, 9:16 PM
will closed D11745: [identity] Convert unwraps in sync identity search to expects.
Thu, Apr 25, 9:15 PM
will committed rCOMMcf544ccfab3a: [identity] Convert unwraps in sync identity search to expects (authored by will).
[identity] Convert unwraps in sync identity search to expects
Thu, Apr 25, 9:15 PM
ashoat resigned from D11793: [native] introduce tag farcaster button.

Copy looks good!

Thu, Apr 25, 7:17 PM
varun requested review of D11796: [identity] delete all token data on user account deletion.
Thu, Apr 25, 5:00 PM
varun requested review of D11795: [identity] move access token table db methods to separate module.
Thu, Apr 25, 4:58 PM
ashoat requested review of D11794: [native] Don't refetch nonce after SIWE is complete.
Thu, Apr 25, 4:23 PM
ginsu added a reviewer for D11793: [native] introduce tag farcaster button: ashoat.

Adding @ashoat as a blocking reviewer since there are copy changes in this diff

Thu, Apr 25, 4:20 PM
ginsu attached a referenced file: F1664658: Screen Recording 2024-04-25 at 7.13.48 PM.mov.
Thu, Apr 25, 4:18 PM
ginsu updated the summary of D11793: [native] introduce tag farcaster button.
Thu, Apr 25, 4:17 PM
ashoat added a reverting change for D11771: [native] Don't refetch nonce from identity after identity auth: rCOMM57e75feedec7: Revert "[native] Don't refetch nonce from identity after identity auth".
Thu, Apr 25, 4:01 PM
ashoat added a reverting change for rCOMM7ad3d18e3433: [native] Don't refetch nonce from identity after identity auth: rCOMM57e75feedec7: Revert "[native] Don't refetch nonce from identity after identity auth".
Thu, Apr 25, 4:01 PM
ashoat committed rCOMM57e75feedec7: Revert "[native] Don't refetch nonce from identity after identity auth" (authored by ashoat).
Revert "[native] Don't refetch nonce from identity after identity auth"
Thu, Apr 25, 4:01 PM
ashoat added a comment to D11793: [native] introduce tag farcaster button.

No reviewers specified

Thu, Apr 25, 3:46 PM
ginsu requested review of D11793: [native] introduce tag farcaster button.
Thu, Apr 25, 3:38 PM
ginsu accepted D11782: Let the user skip backup message generation and record it in alert store.

alert code looks good, pls make sure to respond + address @ashoat's comments before landing

Thu, Apr 25, 3:11 PM
ashoat accepted D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.
Thu, Apr 25, 2:33 PM
atul requested review of D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.
Thu, Apr 25, 2:30 PM
ashoat accepted D11791: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.
Thu, Apr 25, 2:29 PM
ashoat accepted D11790: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `TextMessage`.
Thu, Apr 25, 2:28 PM
ashoat accepted D11789: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.
Thu, Apr 25, 2:28 PM
atul requested review of D11791: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.
Thu, Apr 25, 2:26 PM
atul requested review of D11790: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `TextMessage`.
Thu, Apr 25, 2:21 PM
atul requested review of D11789: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.
Thu, Apr 25, 2:15 PM
ashoat accepted D11788: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.
Thu, Apr 25, 2:13 PM
ashoat accepted D11787: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsButton`.
Thu, Apr 25, 2:12 PM
atul requested review of D11788: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.
Thu, Apr 25, 2:12 PM
atul requested review of D11787: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsButton`.
Thu, Apr 25, 2:11 PM
ashoat accepted D11786: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ViewInviteLinksScreen`.
Thu, Apr 25, 2:11 PM
atul requested review of D11786: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ViewInviteLinksScreen`.
Thu, Apr 25, 2:10 PM
ginsu requested review of D11785: [native] introduce TagFarcasterChannelParams.
Thu, Apr 25, 1:56 PM
ginsu requested review of D11784: [native] update selectedChannel state to be a FarcasterChannel type.
Thu, Apr 25, 1:51 PM
ginsu closed D11772: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag.
Thu, Apr 25, 1:31 PM
ginsu committed rCOMM5a19bd32d3c4: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag (authored by ginsu).
[keyserver] introduce barebones createOrUpdateFarcasterChannelTag
Thu, Apr 25, 1:31 PM
ginsu updated the diff for D11772: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag.

rebase before landing

Thu, Apr 25, 1:27 PM
ginsu added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
Thu, Apr 25, 12:42 PM
varun closed D11783: [terraform] enable debug logs by default on staging.
Thu, Apr 25, 12:00 PM
varun committed rCOMMbceadd1a6c21: [terraform] enable debug logs by default on staging (authored by varun).
[terraform] enable debug logs by default on staging
Thu, Apr 25, 12:00 PM
ginsu attached a referenced file: F1663812: Screenshot 2024-04-25 at 2.53.02 PM.png.
Thu, Apr 25, 11:57 AM
ginsu added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
Thu, Apr 25, 11:57 AM
ashoat added a reverting change for rCOMM35d519850c60: [native] Temporary changes for staff release: rCOMM7a33a7028ba9: Revert "[native] Temporary changes for staff release".
Thu, Apr 25, 11:35 AM
ashoat committed rCOMM7a33a7028ba9: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Thu, Apr 25, 11:35 AM
ashoat committed rCOMM976eefcb084a: [native] codeVersion -> 340 (authored by ashoat).
[native] codeVersion -> 340
Thu, Apr 25, 11:35 AM
ashoat committed rCOMM35d519850c60: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Thu, Apr 25, 11:35 AM
ashoat committed rCOMMcdd3244d138a: [native] codeVersion -> 339 (authored by ashoat).
[native] codeVersion -> 339
Thu, Apr 25, 11:35 AM