Use more specific type
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Fri, Apr 26
Should we rename siweAuthActionTypes to legacySiweAuthActionTypes and keyserverRegisterActionTypes to legacyKeyserverRegisterActionTypes?
- Rename msg_backup to siwe_backup_message
- Fix JSI type
- Rename msg_backup to siwe_backup_msg
- Simplify code.
Rename msgBackup to siweBackupMsg
Rebase
- Rename msg_backup to siwe_backup_msg
- Introcuce separate backup creation JSI calls for SIWE and password users to avoid macking empty string or potential crashes if dev forgets to specify null
rename msgbackup to siweBackupMsg
- Simplify code
- rename msg_backup to siwe_backup_msg
Remove unecessary useState
Could you explain why we need backupID? The message to sign seems generic and wondering if we need a separate file for each backupID
For each backupID we specify backup message that was used to encrypt backup with backup id. Theoretically we can have distinct backup message for each backup id. However your suggestion would work. The reason for that is backup message stays the same as long as SIWE user is logged in. And when the user logs out we delete entire content of backup directory anyway. So for now it is not possible for the compaction files to be encrypted with different backup message. I am not suer however if this assumption could be broken in future. I will give it some thought.
Remove unnecessary code
Address review
I can confirm this works on my M1 Mac.
Some context why this is needed: https://stackoverflow.com/questions/67204811/terraform-failed-to-install-provider-doesnt-match-checksums-from-dependency-l
I think you should rename the generic backup_message to siwe_backup_message
Two questions:
- Could you explain why we need backupID? The message to sign seems generic and wondering if we need a separate file for each backupID
- Is there an easy way to somehow unify getSIWEBackupMessagePath with getBackupUserKeysFilePath which is basically doing the same?
Thu, Apr 25
rebase
rebase
Copy looks good!
Adding @ashoat as a blocking reviewer since there are copy changes in this diff
No reviewers specified
alert code looks good, pls make sure to respond + address @ashoat's comments before landing
rebase before landing