Page MenuHomePhabricator
Differential D10722

[web] update add users list item ui
ClosedPublic
Actions

Authored by ginsu on Jan 18 2024, 12:18 PM.
Tags
None
Referenced Files
F3300756: D10722.id35844.diff
Sun, Nov 17, 9:41 PM
F3300755: D10722.id36104.diff
Sun, Nov 17, 9:41 PM
F3300663: D10722.id37171.diff
Sun, Nov 17, 8:37 PM
Unknown Object (File)
Thu, Oct 31, 8:59 AM
Unknown Object (File)
Thu, Oct 31, 8:59 AM
Unknown Object (File)
Thu, Oct 31, 8:59 AM
Unknown Object (File)
Thu, Oct 31, 8:59 AM
Unknown Object (File)
Thu, Oct 31, 8:59 AM
View All 86 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM9485ea0e81f4: [web] update add users list item ui
Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

The add users modal is getting a brand new ui + ux. This diff updates the add users list item ui to match the new checkbox ui/ux.

For context here is what the new add users modal looks like:

Screenshot 2024-01-18 at 2.58.18 PM.png (1×788 px, 130 KB)

Linear task: https://linear.app/comm/issue/ENG-5957/update-the-ui-of-add-friends-modal

Depends on D10719

Test Plan

Please see the screenshot below

Screenshot 2024-01-18 at 4.00.51 PM.png (3×5 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jan 18 2024, 12:18 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 18 2024, 12:18 PM
Harbormaster completed remote builds in B25924: Diff 35844.Jan 18 2024, 12:37 PM
ginsu requested review of this revision.Jan 18 2024, 12:37 PM
ginsu updated this revision to Diff 35847.Jan 18 2024, 12:58 PM

update

ginsu edited the summary of this revision. (Show Details)Jan 18 2024, 1:12 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D10719: [web] move the send friend request button to add users list modal.
ginsu attached a referenced file: F1071697: Screenshot 2024-01-18 at 4.00.51 PM.png. (Show Details)
ginsu attached a referenced file: F1071696: Screenshot 2024-01-18 at 2.58.18 PM.png. (Show Details)
Harbormaster completed remote builds in B25926: Diff 35847.Jan 18 2024, 1:17 PM
ginsu added inline comments.Jan 18 2024, 1:20 PM
web/settings/relationship/add-users-list.react.js
157 ↗(On Diff #35847)

A subsequent diff will handle fixing this, will tag the diff when it is in review.

I didn't include it in this diff, because I didn't want to make this diff more difficult to review + blow up the scope for this diff

web/theme.css
465 ↗(On Diff #35847)

Here is the linear task better tracking this todo: https://linear.app/comm/issue/ENG-6471/confirm-the-list-item-menu-light-mode-colors

ginsu added a child revision: D10735: [web] update add friends modal selection logic.Jan 18 2024, 2:50 PM
ginsu added inline comments.Jan 18 2024, 2:59 PM
web/settings/relationship/add-users-list.react.js
157 ↗(On Diff #35847)

D10735

atul accepted this revision.Jan 22 2024, 9:26 AM
atul added inline comments.
web/settings/relationship/add-users-list.react.js
157 ↗(On Diff #35847)

I don't know if we really have a convention for TODOs in the codebase (other than trying to avoid them), but might be good to do something like

TODO (ginsu): More descriptive comment about what needs to be fixed.
This revision is now accepted and ready to land.Jan 22 2024, 9:26 AM
ginsu updated this revision to Diff 36104.Jan 24 2024, 2:34 PM

address comments

Harbormaster completed remote builds in B26130: Diff 36104.Jan 24 2024, 2:53 PM
ginsu updated this revision to Diff 37171.Feb 15 2024, 12:56 AM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 1:18 AM
Closed by commit rCOMM9485ea0e81f4: [web] update add users list item ui (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM9485ea0e81f4: [web] update add users list item ui.
Harbormaster completed remote builds in B26880: Diff 37171.Feb 15 2024, 1:20 AM

Revision Contents
Changeset List

PathSize
web/
settings/
relationship/
32 lines
24 lines
3 lines
7 lines

Diff 35844

View Options

web/settings/relationship/add-users-list-item.react.js

Loading...
View Options

web/settings/relationship/add-users-list.css

Loading...
View Options

web/settings/relationship/add-users-list.react.js

Loading...
View Options

web/theme.css

Loading...