Page MenuHomePhabricator
Differential D11026

[web] cleanup alert modal
ClosedPublic
Actions

Authored by ginsu on Feb 11 2024, 10:47 PM.
Tags
None
Referenced Files
F3300204: D11026.diff
Sun, Nov 17, 6:44 PM
Unknown Object (File)
Thu, Oct 31, 6:25 AM
Unknown Object (File)
Sun, Oct 20, 4:05 AM
Unknown Object (File)
Oct 11 2024, 9:33 AM
Unknown Object (File)
Oct 6 2024, 7:55 PM
Unknown Object (File)
Oct 6 2024, 4:33 PM
Unknown Object (File)
Oct 6 2024, 1:58 PM
Unknown Object (File)
Oct 6 2024, 1:40 PM
View All 48 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM3233d77828b0: [web] cleanup alert modal
Summary

This diff cleans up the one off styles in the alert modal and replaces it with styles of the redesigned modal.

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D11025

Test Plan

Please see the screenshot below

Screenshot 2024-02-12 at 1.49.47 AM.png (2×3 px, 860 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Feb 11 2024, 10:47 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 11 2024, 10:47 PM
ginsu edited the summary of this revision. (Show Details)Feb 11 2024, 10:50 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11025: [web] cleanup UnsavedChangesModal.
ginsu attached a referenced file: F1144161: Screenshot 2024-02-12 at 1.49.47 AM.png. (Show Details)
Harbormaster completed remote builds in B26735: Diff 36967.Feb 11 2024, 11:02 PM
ginsu requested review of this revision.Feb 11 2024, 11:02 PM
ginsu added a child revision: D11027: [web] clean up user profiles modal.Feb 11 2024, 11:02 PM
atul accepted this revision.Feb 12 2024, 12:27 PM
atul added inline comments.
web/modals/alert.react.js
31

Wrapping children in <p> seems weird to me. That seems like something that should be handled "internally" to children?

That said, this is how it was, so out of scope for this diff.

This revision is now accepted and ready to land.Feb 12 2024, 12:27 PM
ginsu updated this revision to Diff 37208.Feb 15 2024, 2:13 AM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 2:26 AM
Closed by commit rCOMM3233d77828b0: [web] cleanup alert modal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM3233d77828b0: [web] cleanup alert modal.
Harbormaster completed remote builds in B26902: Diff 37208.Feb 15 2024, 2:28 AM

Revision Contents
Changeset List

PathSize
web/
modals/
10 lines
19 lines

Diff 36967

View Options

web/modals/alert.css

Loading...
View Options

web/modals/alert.react.js

Loading...