Page MenuHomePhabricator

[web] cleanup add keyserver modal
ClosedPublic

Authored by ginsu on Feb 12 2024, 1:35 AM.
Tags
None
Referenced Files
F3300772: D11029.id37210.diff
Sun, Nov 17, 9:47 PM
Unknown Object (File)
Thu, Oct 31, 6:25 AM
Unknown Object (File)
Sun, Oct 27, 12:55 AM
Unknown Object (File)
Thu, Oct 24, 4:41 PM
Unknown Object (File)
Mon, Oct 21, 8:50 AM
Unknown Object (File)
Oct 18 2024, 1:42 PM
Unknown Object (File)
Oct 18 2024, 8:52 AM
Unknown Object (File)
Oct 16 2024, 1:10 PM
Subscribers

Details

Summary

This diff cleans up the one off styles in the add keyserver modal and updates the modal to follow the conventions of the new modal api

Linear task: https://linear.app/comm/issue/ENG-5943/extendmodify-the-modal-props-api-to-follow-new-modal-designs

Depends on D11027

Test Plan

Please see screenshot below

Screenshot 2024-02-12 at 4.36.46 AM.png (2×3 px, 781 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu requested review of this revision.Feb 12 2024, 1:50 AM
This revision is now accepted and ready to land.Feb 12 2024, 12:28 PM
This revision was landed with ongoing or failed builds.Feb 15 2024, 2:26 AM
This revision was automatically updated to reflect the committed changes.