Page MenuHomePhabricator
Differential D10747

[web] update add user list header based on if searching users
ClosedPublic
Actions

Authored by ginsu on Jan 21 2024, 3:00 PM.
Tags
None
Referenced Files
F3300747: D10747.id37192.diff
Sun, Nov 17, 9:37 PM
F3300547: D10747.diff
Sun, Nov 17, 7:31 PM
Unknown Object (File)
Tue, Nov 12, 1:08 AM
Unknown Object (File)
Sat, Nov 9, 3:56 AM
Unknown Object (File)
Sat, Nov 9, 2:46 AM
Unknown Object (File)
Sat, Nov 9, 2:44 AM
Unknown Object (File)
Sat, Nov 9, 2:40 AM
Unknown Object (File)
Sat, Nov 9, 1:43 AM
View All 53 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMeaf557d14d64: [web] update add user list header based on if searching users
Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

When the user has inputted something into the search bar of the add user list, the UI should update to show that the user is in the "search mode"

For context here is what the figma design looks like:

Screenshot 2024-01-21 at 6.07.26 PM.png (1×1 px, 265 KB)

Linear task: https://linear.app/comm/issue/ENG-5959/search-users-ui-changes

Depends on D10746

Test Plan

Please see the screenshot below

Screenshot 2024-01-21 at 6.08.03 PM.png (3×5 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 21 2024, 3:00 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 21 2024, 3:00 PM
ginsu edited the summary of this revision. (Show Details)Jan 21 2024, 3:08 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D10746: [web] introduce clear all button to add users list.
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 21 2024, 3:31 PM
Harbormaster failed remote builds in B25968: Diff 35900!
ginsu requested review of this revision.Jan 22 2024, 7:02 AM

will make sure ci passes before landing

atul accepted this revision.Jan 22 2024, 9:47 AM
This revision is now accepted and ready to land.Jan 22 2024, 9:47 AM
ginsu added a child revision: D10819: [web] convert pendingUsersToAdd into a map.Jan 25 2024, 11:46 AM
ginsu edited the summary of this revision. (Show Details)Jan 25 2024, 12:37 PM
ginsu updated this revision to Diff 37177.Feb 15 2024, 1:03 AM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 1:18 AM
Closed by commit rCOMMeaf557d14d64: [web] update add user list header based on if searching users (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMeaf557d14d64: [web] update add user list header based on if searching users.
Harbormaster completed remote builds in B26886: Diff 37177.Feb 15 2024, 1:32 AM

Revision Contents
Changeset List

PathSize
web/
settings/
relationship/
37 lines

Diff 37192

View Options

web/settings/relationship/add-users-list.react.js

Loading...